1349279 - Heartbeats with "Show prompt until user interacts" or " Show after x days" are following the default recipe show logic

Status: RESOLVED WONTFIX

(Shield :: Heartbeat, defect)

Description

[Adrian Florinescu [:aflorinescu]]

[Preconditions:]

1. Obtain a copy of Firefox with the SHIELD recipe client system add-on installed. You can check about:support to ensure that you have it.
2. Set the extensions.shield-recipe-client.dev_mode preference to true to run recipes immediately on startup.
3. Set the extensions.shield-recipe-client.logging.level preference to 0 to enable more logging.
4. Set the security.content.signature.root_hash preference to DB:74:CE:58:E4:F9:D0:9E:E0:42:36:BE:6C:C5:C4:F6:6A:E7:74:7D:C0:21:42:7A:03:BC:2F:57:0C:8B:9B:90.
5. Set the preference value for extensions.shield-recipe-client.api_url set to https://normandy.stage.mozaws.net/api/v1

[Steps:]
1.Open Admin Interface. 
2.Create a heartbeat type recipe with option "How often should the prompt be shown? " set to "Show this prompt until the user clicks the button/stars, and then never again"
3.Set a filter and use a FF profile that it is certain to trigger the above created recipe.
4. Open a FF with a profile containing the preconditions.
5. Close the Heartbeat notification or/and restart the browser.

[Actual Result:}
The heartbeat recipe is not shown after the step 5 restart since it conflicts with the rule that only one heartbeat recipe should be executed in 24hrs.

[Expected Result:]
After the restart at step 5 the heartbeat should be shown again, since the "How often should the prompt be shown? " is set to "Show this prompt until the user clicks the button/stars, and then never again"

Comment 1

[Adrian Florinescu [:aflorinescu]]

Similar issue with the last recipe option: show after x days option.

Comment 2

[Osmose [:osmose, :mkelly]]

I checked with Matt Grimes, and he confirmed that this is expected; the rule that only one heartbeat notification should be shown every 24 hours should take precedence over the repeat options specified in the recipe. We can keep this behavior as it is.