1354125 - HeartBeat is shown again to the user earlier than 24hrs

Status: RESOLVED INVALID

(Shield :: Heartbeat, defect)

Description

[Adrian Florinescu [:aflorinescu]]

Based on https://bugzilla.mozilla.org/show_bug.cgi?id=1349279#c2, any heartbeat(no matter the type) shouldn't be shown to an user again sooner than 24hrs.

Using the following 
[Pe-requisites:]
1. Set the preference value for extensions.systemaddon.update.url set to https://aus5.mozilla.org/update/3/SystemAddons/53.0.0/20160922113459/default/en-US/beta-sysaddon/default/default/default/update.xml
2. Go to Tools -> Developer Tools -> Web Console -> Open "Toolbox Options" from "Advanced settings" mark as checked the last 3 available check boxes. (browser chrome....; remote debugging; worker debugging)
3. Open Browser Console and run this script: Components.utils.import("resource://gre/modules/AddonManager.jsm"); AddonManagerPrivate.backgroundUpdateCheck();
4. Set the preference value for extensions.shield-recipe-client.api_url set to https://normandy.stage.mozaws.net/api/v1
5. Set the extensions.shield-recipe-client.dev_mode preference to true to run recipes immediately on startup.
6. Set the extensions.shield-recipe-client.logging.level preference to 0 to enable more logging.
7. Set the security.content.signature.root_hash to DB:74:CE:58:E4:F9:D0:9E:E0:42:36:BE:6C:C5:C4:F6:6A:E7:74:7D:C0:21:42:7A:03:BC:2F:57:0C:8B:9B:90

[Steps:]
1. Open FF beta 53. 
2. When recipe-id 75 is shown, close it down.
3. Have the value for - "normandy-heartbeat":{"lastShown" from shield-recipe-client.json edited to a value signifying a date in the past. - this means a new recipe can be ran.
4. Restart FF.

[Actual Result]
The recipe-id 75 is executed again and the heartbeat is shown.

[Expected Result:]
The recipe-id 75 should not be executed for another 24hrs.

Comment 1

[Osmose [:osmose, :mkelly]]

Step 3 in the STR resets the date that we use to determine if a heartbeat was shown within the last 24 hours, so it's expected that the heartbeat bar is shown again. This is working as designed.