1349497 - Always create layer for nsDisplayBackgroundColor

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Ethan Lin[:ethlin]]

For QR, We should always create color layer for nsDisplayBackgroundColor.

Comment 1

[Ethan Lin[:ethlin]]

There are many reftest failures[1] if I turn it on. I'll see how to fix them.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=946897f6f615f881ed968efe1a3cda07523c3b33&selectedJob=85564562

Comment 2

[Ethan Lin[:ethlin]]

I fixed transform problem. Some failures should be original gecko problems. If I turn off WR and set 'layers.force-active=true' for creating colorLayer, I get the same failures. [1] is an instance and it looks like the border image's sides are wrong. I may set a pref for BackgroundColor for now and open another following bug to turn it on by default.

[1] layout/reftests/border-image/svg-as-border-image-2.html

Comment 3

[Ethan Lin[:ethlin]]

Attachment: Add pref to create color layer for nsDisplayBackgroundColor

Comment 4

[Ethan Lin[:ethlin]]

try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f389001d233c8907c45cd8503c0f119eaf2ab8b2

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/b26e81328f0d
Add pref to create color layer for nsDisplayBackgroundColor. r=mchang

Comment 6

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/mozilla-central/rev/b26e81328f0d