1349692 - Update webrender to dafe3579e8dc886e6584116dc52a9362b543c169

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

+++ This bug was initially created as a clone of Bug #1348913 +++

I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.

When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".

[1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh

Comment 1

[Kartikaya Gupta (email:[e-mail])]

WR @ fb7c5ec9ab89dd5c0c861256096c8d01c56a0513

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cc7c1e04cff074d42305ba8daf0438fc17c4623e

Good

Comment 2

[Kartikaya Gupta (email:[e-mail])]

WR @ b2dd9f792d0cb3dfc591567c105755f56f35956d

https://treeherder.mozilla.org/#/jobs?repo=try&revision=200056a20e31344275d6834f661c8488f4bbd8dd

Build bustage

Comment 3

[Nicolas Silva [:nical]]

One of the errors (update_image API change) can be fixed passing None as the last parameter that was added recently. It is just an optional dirty rectangle and we can come back later to take advantage of it.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

WR @ b2dd9f792d0cb3dfc591567c105755f56f35956d with fixup. In addition to the update_image API change I also stopped passing a clip to push_stacking_context.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=afb24eca07ce177292e761ef9e1b264524b19108

Still going, but looking ok so far.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

WR @ 09812761919455727d1344c9c1e6762e611780b8

https://treeherder.mozilla.org/#/jobs?repo=try&revision=273c312dee7901c91cd380b637c50eda7b4f9e0d

Two reftest failures, both look related to box shadows. Maybe they just need fuzzing, the max difference is pretty small on both.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

These are the commits in the regression range for comment 5:

0981276 Auto merge of #1010 - rlhunt:align-gradient-stops, r=kvark
74bda66 Auto merge of #966 - squarewave:master, r=kvark
b7b7c3a Adjust stops colors for aligned gradients relative to segment_rect
6fa2881 Fixup commit for gradient banding work
1a20785 Add gradient perf test to wrench
0775efe Add ordered dithering to gradient-like effects

Comment 7

[Kartikaya Gupta (email:[e-mail])]

74bda66 also has the R3 failures, so the regression came from servo/webrender#966

Comment 8

[Kartikaya Gupta (email:[e-mail])]

WR @ 95235a706b710baa3a073c29f64c6eab32dbc3f4

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ccd0c816f85e7ff0e4c62f8ade1b5d0bfba0c53e

Still ok except for the R3 fuzzies

Comment 9

[Kartikaya Gupta (email:[e-mail])]

WR @ 963bd36bb18b4d4800bb49fe9bd1a36f725ade6d

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d2250a194b2e0d2ee47d59a69528f4f68c7d209

Ditto

Comment 10

[Kartikaya Gupta (email:[e-mail])]

I want to get servo/webrender#1009, so I'm going to pull a WR update.

Comment 11

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1349692 - Update webrender to 5c2a9ff065665cb99b72809681b1b7d043363c28.

Review commit: https://reviewboard.mozilla.org/r/124372/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/124372/

Comment 12

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1349692 - Update webrender_bindings.

- API changes to update_image and push_stacking_context.
- Bump versions in Cargo.toml

Review commit: https://reviewboard.mozilla.org/r/124374/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/124374/

Comment 13

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1349692 - Revendor rust dependencies.

Review commit: https://reviewboard.mozilla.org/r/124376/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/124376/

Comment 14

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1349692 - Adjust fuzziness of a couple of reftests with webrender.

The fuzziness was introduced by https://github.com/servo/webrender/pull/966 and
might be fixed in the future, see discussion starting at
https://github.com/servo/webrender/pull/966#issuecomment-289332927

Review commit: https://reviewboard.mozilla.org/r/124378/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/124378/

Comment 15

[Kartikaya Gupta (email:[e-mail])]

Try push with (the equivalent of) these patches is at https://treeherder.mozilla.org/#/jobs?repo=try&revision=c0988ff439e95b5ac4118f574f2443cd9c14b8e5

Comment 16

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8852151 [details]
Bug 1349692 - Update webrender to 5c2a9ff065665cb99b72809681b1b7d043363c28.

https://reviewboard.mozilla.org/r/124372/#review126916

Comment 17

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8852152 [details]
Bug 1349692 - Update webrender_bindings.

https://reviewboard.mozilla.org/r/124374/#review126918

Comment 18

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8852153 [details]
Bug 1349692 - Revendor rust dependencies.

https://reviewboard.mozilla.org/r/124376/#review126924

Comment 19

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8852154 [details]
Bug 1349692 - Adjust fuzziness of a couple of reftests with webrender.

https://reviewboard.mozilla.org/r/124378/#review126926

Comment 20

[Kartikaya Gupta (email:[e-mail])]

Try push is showing a crash across most jobs in DisplayListBuilder::push_built_display_list. Since stuff was green in 963bd36bb18b4d4800bb49fe9bd1a36f725ade6d, this is the regression range:

5c2a9ff Auto merge of #1009 - sotaroikeda:feat-webgl, r=emilio
76cdf1d Auto merge of #1014 - jrmuizel:avoid-copy, r=kvark
d7c07eb Avoid copies when converting to blob
78af0cd Allow to not depend on offscreen_gl_context

Almost certainly due to the blob change, so I kicked off another try push with that backed out manually:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e29c485a48764cfced858132f83233f2d19751f3

Comment 21

[Kartikaya Gupta (email:[e-mail])]

Try push above confirmed that it was the blob change. Meanwhile Jeff pushed a PR with the fix, servo/webrender#1020. I'll pull that too.

Comment 22

[Kartikaya Gupta (email:[e-mail])]

New try push with Jeff's fix applied: https://treeherder.mozilla.org/#/jobs?repo=try&revision=96a1c9cbbc94687e3e4ac26a2be6a929a93fa1a6

Comment 23

[Kartikaya Gupta (email:[e-mail])]

It's looking good with the fix.

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/843561af313a
Update webrender to dafe3579e8dc886e6584116dc52a9362b543c169. r=jrmuizel
https://hg.mozilla.org/projects/graphics/rev/e0e0b41946f2
Adjust fuzziness of a couple of reftests with webrender. r=jrmuizel

Comment 25

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/mozilla-central/rev/843561af313a
https://hg.mozilla.org/mozilla-central/rev/e0e0b41946f2