Update webrender to dafe3579e8dc886e6584116dc52a9362b543c169

RESOLVED FIXED in Firefox 55



Graphics: WebRender
a year ago
a year ago


(Reporter: kats, Assigned: kats)


(Blocks: 1 bug)

Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)


(Whiteboard: [gfx-noted])

MozReview Requests


Submitter Diff Changes Open Issues Last Updated
Error loading review requests:


(4 attachments)

+++ This bug was initially created as a clone of Bug #1348913 +++

I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.

When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".

[1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh
One of the errors (update_image API change) can be fixed passing None as the last parameter that was added recently. It is just an optional dirty rectangle and we can come back later to take advantage of it.
WR @ b2dd9f792d0cb3dfc591567c105755f56f35956d with fixup. In addition to the update_image API change I also stopped passing a clip to push_stacking_context.


Still going, but looking ok so far.
WR @ 09812761919455727d1344c9c1e6762e611780b8


Two reftest failures, both look related to box shadows. Maybe they just need fuzzing, the max difference is pretty small on both.
These are the commits in the regression range for comment 5:

0981276 Auto merge of #1010 - rlhunt:align-gradient-stops, r=kvark
74bda66 Auto merge of #966 - squarewave:master, r=kvark
b7b7c3a Adjust stops colors for aligned gradients relative to segment_rect
6fa2881 Fixup commit for gradient banding work
1a20785 Add gradient perf test to wrench
0775efe Add ordered dithering to gradient-like effects
74bda66 also has the R3 failures, so the regression came from servo/webrender#966
WR @ 95235a706b710baa3a073c29f64c6eab32dbc3f4


Still ok except for the R3 fuzzies
Blocks: 1325298
I want to get servo/webrender#1009, so I'm going to pull a WR update.
Assignee: nobody → bugmail
No longer blocks: 1325298
Summary: Future webrender update bug → Update webrender to 5c2a9ff065665cb99b72809681b1b7d043363c28 (or newer)
Blocks: 1325298
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 16

a year ago
Comment on attachment 8852151 [details]
Bug 1349692 - Update webrender to 5c2a9ff065665cb99b72809681b1b7d043363c28.

Attachment #8852151 - Flags: review?(jmuizelaar) → review+

Comment 17

a year ago
Comment on attachment 8852152 [details]
Bug 1349692 - Update webrender_bindings.

Attachment #8852152 - Flags: review?(jmuizelaar) → review+

Comment 18

a year ago
Comment on attachment 8852153 [details]
Bug 1349692 - Revendor rust dependencies.

Attachment #8852153 - Flags: review?(jmuizelaar) → review+

Comment 19

a year ago
Comment on attachment 8852154 [details]
Bug 1349692 - Adjust fuzziness of a couple of reftests with webrender.

Attachment #8852154 - Flags: review?(jmuizelaar) → review+
Try push is showing a crash across most jobs in DisplayListBuilder::push_built_display_list. Since stuff was green in 963bd36bb18b4d4800bb49fe9bd1a36f725ade6d, this is the regression range:

5c2a9ff Auto merge of #1009 - sotaroikeda:feat-webgl, r=emilio
76cdf1d Auto merge of #1014 - jrmuizel:avoid-copy, r=kvark
d7c07eb Avoid copies when converting to blob
78af0cd Allow to not depend on offscreen_gl_context

Almost certainly due to the blob change, so I kicked off another try push with that backed out manually:

Try push above confirmed that it was the blob change. Meanwhile Jeff pushed a PR with the fix, servo/webrender#1020. I'll pull that too.
It's looking good with the fix.
Summary: Update webrender to 5c2a9ff065665cb99b72809681b1b7d043363c28 (or newer) → Update webrender to dafe3579e8dc886e6584116dc52a9362b543c169

Comment 24

a year ago
Pushed by kgupta@mozilla.com:
Update webrender to dafe3579e8dc886e6584116dc52a9362b543c169. r=jrmuizel
Adjust fuzziness of a couple of reftests with webrender. r=jrmuizel
Last Resolved: a year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.