Closed
Bug 1349709
Opened 7 years ago
Closed 7 years ago
TPS failure: test_sync.js: ASSERTION FAILED! Validation error for "passwords" of type "serverMissing"
Categories
(Testing Graveyard :: TPS, defect)
Testing Graveyard
TPS
Tracking
(firefox53 unaffected, firefox54 fixed, firefox55 fixed)
VERIFIED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox53 | --- | unaffected |
firefox54 | --- | fixed |
firefox55 | --- | fixed |
People
(Reporter: kthiessen, Assigned: lina)
References
Details
(Whiteboard: [sec-insecure-third-party-site-reviewed])
Attachments
(2 files)
18.84 KB,
text/plain
|
Details | |
59 bytes,
text/x-review-board-request
|
tcsc
:
review+
gchang
:
approval-mozilla-aurora+
|
Details |
This is the bug Kit and I saw when preparing the "light" run file to run TPS as a smoke check against prod. TPS stdout is attached.
Whiteboard: [sec-insecure-third-party-site-reviewed]
Assignee | ||
Updated•7 years ago
|
status-firefox53:
--- → unaffected
status-firefox54:
--- → affected
status-firefox55:
--- → affected
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8850266 [details] Bug 1349709 - Ensure `PasswordEngine` conforms to the new `pullAllChanges` interface. https://reviewboard.mozilla.org/r/122902/#review125504 ::: services/sync/modules/engines/passwords.js:104 (Diff revision 1) > }, > > pullAllChanges() { > - let changeset = new Changeset(); > + let changes = {}; > for (let [id, info] of Object.entries(this._store.getAllIDs())) { > - changeset.set(id, info.timePasswordChanged); > + changes[id] = info.timePasswordChanged / 1000; Glad you took this bug because I didn't realize there was a unit mismatch! ::: services/sync/tests/unit/test_password_engine.js:11 (Diff revision 1) > + "@mozilla.org/login-manager/loginInfo;1", Ci.nsILoginInfo, "init"); > + > +const PropertyBag = Components.Constructor( > + "@mozilla.org/hash-property-bag;1", Ci.nsIWritablePropertyBag); > + > +function serverForEngine(engine) { At some point we should move this function into one of the headers... But probably not this bug.
Attachment #8850266 -
Flags: review?(tchiovoloni) → review+
Pushed by kcambridge@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/88542bb64b97 Ensure `PasswordEngine` conforms to the new `pullAllChanges` interface. r=tcsc
Assignee | ||
Comment 4•7 years ago
|
||
Comment on attachment 8850266 [details] Bug 1349709 - Ensure `PasswordEngine` conforms to the new `pullAllChanges` interface. Approval Request Comment [Feature/Bug causing the regression]: Bug 1317223. [User impact if declined]: Password syncing is completely broken for new users. [Is this code covered by automated tests?]: Yes. [Has the fix been verified in Nightly?]: Not yet. Once this patch lands, it can be verified using the TPS test suite. [Needs manual test from QE? If yes, steps to reproduce]: No. [List of other uplifts needed for the feature/fix]: None. [Is the change risky?]: No. [Why is the change risky/not risky?]: Three-line change to fix a change introduced in bug 1317223; includes xpcshell test. [String changes made/needed]: None.
Attachment #8850266 -
Flags: approval-mozilla-aurora?
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/88542bb64b97
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Comment 6•7 years ago
|
||
Comment on attachment 8850266 [details] Bug 1349709 - Ensure `PasswordEngine` conforms to the new `pullAllChanges` interface. Fix a broken password syncing. Aurora54+.
Attachment #8850266 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 7•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/1bff0c493536
Comment 8•7 years ago
|
||
backed out for causing problems like https://treeherder.mozilla.org/logviewer.html#?job_id=86165032&repo=mozilla-aurora
Flags: needinfo?(kit)
Assignee | ||
Comment 9•7 years ago
|
||
Re-landed in https://hg.mozilla.org/releases/mozilla-aurora/rev/426f26d1a43efcbf9bed49a01a52afb4b8907c79, tests should pass now that bug 1345005 has been uplifted, too.
Flags: needinfo?(kit)
Updated•5 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•