1349898 - support browser_style in devtools, but using devtools styles

Status: RESOLVED WONTFIX

(WebExtensions :: Developer Tools, enhancement, P3)

Description

[Tim Nguyen :ntim]

Similarly to "browser_style": true/false for browser/page action, we should provide "devtools_style" true/false for devtools panels.

Comment 1

[Blake Winton (:bwinton) (:☕️)]

I've got a couple of questions about this…

1) Why is the devtools style different from the browser style?  At best that makes it seem like we're building an unrelated collection of random stuff, not a single product.

2) If they have to be different, why would "browser_style" not be the devtools style for devtools panels?  The intent of "browser_style" is fairly clearly "Make this look like part of the browser", so we should do that.

Comment 2

[Tim Nguyen :ntim]

(In reply to Blake Winton (:bwinton) (:☕️) from comment #1)
> I've got a couple of questions about this…
> 
> 1) Why is the devtools style different from the browser style?  At best that
> makes it seem like we're building an unrelated collection of random stuff,
> not a single product.

The advantage is that devtools_style will also integrate with whatever theme is selected.

> 2) If they have to be different, why would "browser_style" not be the
> devtools style for devtools panels?  The intent of "browser_style" is fairly
> clearly "Make this look like part of the browser", so we should do that.


browser_style as name is fine too.

Comment 3

[Andy McKay]

I don't think there's any need for discussion here. We've got a standard pattern for providing a style that matches the rest of the UI if the developer wants it. Let's do the same here.

Comment 4

[Shane Caraveo (:mixedpuppy)]

TBH given the amount of problems and limitations with browser_style I'm hesitant about this.  However, lets at least use "browser_style" for the name.

Comment 5

[Rob Wu [:robwu]]

Closing bug because support for browser_style feature is going to be removed (at least in MV3), see bug 1827910.