1350496 - add BUG_COMPONENT to docshell/* files

Status: RESOLVED FIXED

(Core :: DOM: Navigation, enhancement)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

this will help us map regressions to the right place and all that fun stuff :)

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: add BUG_COMPONENT to docshell/*

:overholt, apologies for the review, this should be thorough, but your advice is well heeled, so do r- and suggest anything that should change.

Comment 2

[Andrew Overholt [:overholt]]

Comment on attachment 8851183 [details] [diff] [review]
add BUG_COMPONENT to docshell/*

Review of attachment 8851183 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry, two back-to-back work weeks killed my productivity. I just have the tests to go through.

::: docshell/base/moz.build
@@ +22,5 @@
> +with Files('*LoadContext.*'):
> +    BUG_COMPONENT = ('Core', 'Networking')
> +
> +with Files('nsAboutRedirector.*'):
> +    BUG_COMPONENT = ('Core', 'Networking')

Let's put this in the ever-so-awesome Core::General.

Comment 3

[Andrew Overholt [:overholt]]

Comment on attachment 8851183 [details] [diff] [review]
add BUG_COMPONENT to docshell/*

Review of attachment 8851183 [details] [diff] [review]:
-----------------------------------------------------------------

Again, profuse apologies for the delay here. I didn't go through all the files you didn't have explicitly called out as exceptions but I'll assume either you did (wow!) or we're OK with the defaults picking the incorrect component here or there (probably totally fine). With the 2 minor changes here, r+.

::: docshell/test/moz.build
@@ +65,5 @@
> +    BUG_COMPONENT = ('Firefox', 'Private Browsing')
> +
> +
> +with Files('iframesandbox/**'):
> +    BUG_COMPONENT = ('Core', 'DOM: Security')

Some of these should go into Core : Security but it's probably OK to start with DOM: Security.

@@ +68,5 @@
> +with Files('iframesandbox/**'):
> +    BUG_COMPONENT = ('Core', 'DOM: Security')
> +
> +
> +with Files('Navigation/*13871.html'):

The directory "navigation" begins with a lowercase 'n' so this may break on case-sensistive filesystems.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

oh, thanks for the navigation lower case find!

I also changed iframesandbox to:
with Files('iframesandbox/**'):
    BUG_COMPONENT = ('Core', 'Security')

with Files('iframesandbox/*marquee_event_handlers*'):
    BUG_COMPONENT = ('Core', 'DOM: Security')

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0dbe18767bbf
add BUG_COMPONENT to docshell/* files. r=overholt

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/0dbe18767bbf