Closed Bug 1350496 Opened 3 years ago Closed 3 years ago

add BUG_COMPONENT to docshell/* files

Categories

(Core :: Document Navigation, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: jmaher, Assigned: jmaher)

References

Details

Attachments

(1 file)

this will help us map regressions to the right place and all that fun stuff :)
:overholt, apologies for the review, this should be thorough, but your advice is well heeled, so do r- and suggest anything that should change.
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Attachment #8851183 - Flags: review?(overholt)
Comment on attachment 8851183 [details] [diff] [review]
add BUG_COMPONENT to docshell/*

Review of attachment 8851183 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry, two back-to-back work weeks killed my productivity. I just have the tests to go through.

::: docshell/base/moz.build
@@ +22,5 @@
> +with Files('*LoadContext.*'):
> +    BUG_COMPONENT = ('Core', 'Networking')
> +
> +with Files('nsAboutRedirector.*'):
> +    BUG_COMPONENT = ('Core', 'Networking')

Let's put this in the ever-so-awesome Core::General.
Comment on attachment 8851183 [details] [diff] [review]
add BUG_COMPONENT to docshell/*

Review of attachment 8851183 [details] [diff] [review]:
-----------------------------------------------------------------

Again, profuse apologies for the delay here. I didn't go through all the files you didn't have explicitly called out as exceptions but I'll assume either you did (wow!) or we're OK with the defaults picking the incorrect component here or there (probably totally fine). With the 2 minor changes here, r+.

::: docshell/test/moz.build
@@ +65,5 @@
> +    BUG_COMPONENT = ('Firefox', 'Private Browsing')
> +
> +
> +with Files('iframesandbox/**'):
> +    BUG_COMPONENT = ('Core', 'DOM: Security')

Some of these should go into Core : Security but it's probably OK to start with DOM: Security.

@@ +68,5 @@
> +with Files('iframesandbox/**'):
> +    BUG_COMPONENT = ('Core', 'DOM: Security')
> +
> +
> +with Files('Navigation/*13871.html'):

The directory "navigation" begins with a lowercase 'n' so this may break on case-sensistive filesystems.
Attachment #8851183 - Flags: review?(overholt) → review+
oh, thanks for the navigation lower case find!

I also changed iframesandbox to:
with Files('iframesandbox/**'):
    BUG_COMPONENT = ('Core', 'Security')

with Files('iframesandbox/*marquee_event_handlers*'):
    BUG_COMPONENT = ('Core', 'DOM: Security')
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0dbe18767bbf
add BUG_COMPONENT to docshell/* files. r=overholt
https://hg.mozilla.org/mozilla-central/rev/0dbe18767bbf
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.