1350521 - Turn off xml:base for style attribute by default for all channels

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Xidorn Quan [:xidorn] UTC+10]

With bug 1349024, we are going to turn off xml:base for style attribute. If that doesn't lead to significant issues, we probably should have it ride the train to completely unship xml:base for style attribute.

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

miketaylr, have you seen any compat issue reported which may be related to bug 1349024 disabling xml:base for style attribute? If not, should we try moving forward in this bug to have it rid the train to beta and release?

Comment 2

[Julien Cristau [:jcristau]]

Adding this to the 55 tracking list so it's on the radar for release management.

Comment 3

[Mike Taylor [:miketaylr]]

I'm not aware of any reports. Dennis, Tom, anything I might have missed?

Comment 4

[Thomas Wisniewski]

Same here; I don't recall any reports related to this.

Comment 5

[Dennis Schubert [:denschub]]

Have not found or seen anything, no.

Comment 6

[Xidorn Quan [:xidorn] UTC+10]

OK, then let's do it.

Comment 7

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1350521 - Turn off xml:base for style attribute by default for all channels.

Review commit: https://reviewboard.mozilla.org/r/143652/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/143652/

Comment 8

[Xidorn Quan [:xidorn] UTC+10]

jet, although you suggested me that we only do this for beta for now, it doesn't seem to me it is a usual pattern to have separate settings for beta and release, and I think it makes sense. We probably want to keep beta and release consistent so that we know the status of release from beta.

Comment 9

[Jet Villegas (inactive)]

Comment on attachment 8872196 [details]
Bug 1350521 - Turn off xml:base for style attribute by default for all channels.

https://reviewboard.mozilla.org/r/143650/#review148210

r+

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8feddea7052d
Turn off xml:base for style attribute by default for all channels. r=jet

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8feddea7052d

Comment 12

[Chris Mills [:cmills]]

We've not even got any documentation for xml:base anymore (the page simply redirects to the page for <base>), so I've just added a note to the Fx55 rel notes:

https://developer.mozilla.org/en-US/Firefox/Releases/55#HTML

Let me know if that's OK. Thanks!

Comment 13

[Xidorn Quan [:xidorn] UTC+10]

That looks good, thanks!