Closed Bug 1350521 Opened 3 years ago Closed 3 years ago

Turn off xml:base for style attribute by default for all channels

Categories

(Core :: CSS Parsing and Computation, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 + fixed

People

(Reporter: xidorn, Assigned: xidorn)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-complete, site-compat)

Attachments

(1 file)

With bug 1349024, we are going to turn off xml:base for style attribute. If that doesn't lead to significant issues, we probably should have it ride the train to completely unship xml:base for style attribute.
Blocks: 1353967
miketaylr, have you seen any compat issue reported which may be related to bug 1349024 disabling xml:base for style attribute? If not, should we try moving forward in this bug to have it rid the train to beta and release?
Flags: needinfo?(miket)
Adding this to the 55 tracking list so it's on the radar for release management.
I'm not aware of any reports. Dennis, Tom, anything I might have missed?
Flags: needinfo?(twisniewski)
Flags: needinfo?(miket)
Flags: needinfo?(dschubert)
Same here; I don't recall any reports related to this.
Have not found or seen anything, no.
Flags: needinfo?(dschubert)
OK, then let's do it.
Flags: needinfo?(xidorn+moz)
jet, although you suggested me that we only do this for beta for now, it doesn't seem to me it is a usual pattern to have separate settings for beta and release, and I think it makes sense. We probably want to keep beta and release consistent so that we know the status of release from beta.
Flags: needinfo?(xidorn+moz)
Comment on attachment 8872196 [details]
Bug 1350521 - Turn off xml:base for style attribute by default for all channels.

https://reviewboard.mozilla.org/r/143650/#review148210

r+
Attachment #8872196 - Flags: review?(bugs) → review+
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8feddea7052d
Turn off xml:base for style attribute by default for all channels. r=jet
Flags: needinfo?(twisniewski)
Assignee: nobody → xidorn+moz
https://hg.mozilla.org/mozilla-central/rev/8feddea7052d
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
We've not even got any documentation for xml:base anymore (the page simply redirects to the page for <base>), so I've just added a note to the Fx55 rel notes:

https://developer.mozilla.org/en-US/Firefox/Releases/55#HTML

Let me know if that's OK. Thanks!
That looks good, thanks!
Blocks: 1406277
You need to log in before you can comment on or make changes to this bug.