1350535 - Location bar suggestions offset when in full screen

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Scott Macpherson]

Attachment: Screenshot showing offset location bar suggestions

When in full screen mode (macOS), the location bar dropdown is offset to the right.

This is most obvious when the "Would you like to improve your search experience…" message is shown.

Screenshot attached.

Firefox Developer Edition 54.0a2 (2017-03-25) 64-bit on macOS 10.12.3. Can also replicate with Firefox 52.0.1 (64-bit), same operating system.

Comment 1

[Marco Bonardo [:mak]]

I didn't try to reproduce yet, but it looks bad.

Comment 2

[me]

Attachment: Slight offset in the suggestions popover (left margin) in full-screen mode

This is still happening in Firefox 57.0b3 (64-bit) (also in Developer Edition).

Strangely enough, this does not happen when I have two windows in full-screeen side-by-side.

Comment 3

[me]

[Tracking Requested - why for this release]:

Comment 4

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Tracked for 57. I hope we get a fix soon.

Comment 5

[Marco Bonardo [:mak]]

hopefully bug 1402272 may help here, we're already working on that.

Comment 6

[Marco Bonardo [:mak]]

(In reply to me from comment #2)
> Created attachment 8912442 [details]
> Slight offset in the suggestions popover (left margin) in full-screen mode

hmm, I don't see anything wrong in this screenshot, can you help me?

Comment 7

[me]

Attachment: Slight offset in the suggestions dropdown

(In reply to Marco Bonardo [::mak] from comment #6)
> (In reply to me from comment #2)
> > Created attachment 8912442 [details]
> > Slight offset in the suggestions popover (left margin) in full-screen mode
> 
> hmm, I don't see anything wrong in this screenshot, can you help me?

My bad, I uploaded the wrong screenshot (the window is not in full screen mode). Here is the right one (and you can compare the differences).

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Andrei, can your team try to reproduce this for 57/58? Thanks. 
Is this actually a regression?  If it was happening in 52, it can't be too recent. 
But, in any case, unless this is a serious problem, too late to fix in 57.

Comment 9

[Hani Yacoub, Desktop QA]

I couldn't reproduce this issue on macOS 10.12 on the latest Nightly 58.0a1 and on Beta 57.0b12.
And I also couldn't reproduce it on Firefox Developer Edition 54.0a2 (2017-03-25) 64-bit and on Firefox 52.0.1 (64-bit), the build that were mentioned in the first comment.

Are there other steps that we could use to reproduce it?

Could you please download the latest Firefox Nightly from here: https://nightly.mozilla.org/ and retest the problem.
If you still have the issue please create a new profile, you have the steps here: https://support.mozilla.org/en-US/kb/profile-manager-create-and-remove-firefox-profiles?redirectlocale=en-US&redirectslug=Managing-profiles#w_starting-the-profile-manager

Thanks.

Comment 10

[Scott Macpherson]

Attachment: Nightly 58.0a1 (2017-10-30)

Reproducable in 58.0a1 (2017-10-30) (64-bit) under macOS 10.13.

I've spotted that it's got something to do with the fact that I have my macOS dock on the left-hand side of my screen. Even though the dock isn't visible full-screen, it's still shoving this element to the right.

If I hide the dock before going full-screen in Firefox, the issue does not present. Ditto if I move my dock to the bottom of the screen.

It's kind of similar to bug 1390125…

Comment 11

[Hani Yacoub, Desktop QA]

Attachment: docl on the right and on the left side.png

This issue is reproducible also on macOS 10.10 when the macOS dock is on the right or on the left side. (Please see the screenshot attached)

This issue was also reproducible on Firefox release version 48.

Comment 12

[Dão Gottwald [:dao]]

I guess this is fixed by bug 1551598.

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a regression, but please revert this change in case of error.