1551598 - Stop using a popup window for urlbar results

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P2)

Description

[Markus Stange [:mstange]]

The urlbar dropdown is a popup window at the moment. However, this causes some problems, and to the best of my knowledge, it does not need to be a popup window any more - it could just be a regular XUL/HTML element that is overlaid on top of the other browser elements, for example using a XUL stack or CSS positioning.

As far as I know, the main advantage of a XUL popup / panel is the fact that it can extend beyond the window that opened it. But the current design does not really require this ability: The panel is usually contained entirely within the browser window. The only exception I've found to this is the case where the browser window is very narrow vertically, and the panel extends a bit downwards below the browser window's bottom edge. I question whether this behavior makes a big difference in actual usage.

Using a regular XUL/HTML element instead would have the following advantages:

1. More predictable positioning and sizing behavior: Popup windows come with all kinds extra behavior that makes sense for context menus or tooltips, but which is not needed for the autocomplete panel. Regular CSS-controlled sizing would be easier to reason about, I think.
2. Performance: Popup windows are their own special thing when it comes to drawing. A popup gets its own OS window + layer manager + compositor, which has overhead, and depending on the platform this compositor might not be hardware accelerated. And animations of popup window sizes are not optimized. Basically, if you paint into the browser window itself, you get to take advantage of all the graphics optimization work that was done for websites. If you paint into a popup window, you're on your own, and a lot of that graphics work does not benefit you.

Chrome also does not use a separate OS window for its urlbar dropdown, it paints it into the browser window and constrains it to the browser window's bounds.

Comment 1

[Markus Stange [:mstange]]

In the distant past, it was not possible to paint on top of web content without using a popup. But this was fixed many years ago.

Comment 2

[:Gijs (he/him)]

Is this in-scope for quantumbar?

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Not in scope since we're in soft freeze and the QB release is considered done (modulo a couple minor issues), and anyway we should evaluate all the possible fallbacks from the change, especially related to a11y and edge cases.

This may actually help with bug 1542486 though.

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

I should have said "not in scope for the initial release", obviously if this change can be done without too much trouble, it would be good.

Comment 5

[Dão Gottwald [:dao]]

Attachment: Bug 1551598 - Stop using a popup window for urlbar results.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/580d975db590
Stop using a popup window for urlbar results. r=mak

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/580d975db590