1350649 - Misleading error "Video can't be played because the file is corrupt." due to Z3C OS bug

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Audio/Video, defect, P1)

Description

[Marco Castelluccio [:marco]]

+++ This bug was initially created as a clone of Bug #1350279 +++

Videos in web pages (from YouTube and other websites) are broken. The video element is replaced with an error message saying "Video can't be played because the file is corrupt.".
I'm pretty sure this used to work in the past, but I can't recall when.

I can reproduce on a Sony Xperia Z3 Compact, but not on a Nexus 5.

Setting "media.android-remote-codec.enabled" to false doesn't solve the problem.

Comment 1

[Kohei Yoshino [:kohei]]

I cannot reproduce the issue on my Nexus 5X phone nor Nexus 9 tablet, but let's track...

[Tracking Requested - why for this release]: Videos on YouTube and other sites are broken on certain Android devices.

Comment 2

[Kohei Yoshino [:kohei]]

(Oops, I guess 52 is not affected.)

Comment 3

[Kohei Yoshino [:kohei]]

Hmm, sorry, I should have read the comment carefully :/ Macro says "Setting "media.android-remote-codec.enabled" to false *doesn't* solve the problem."

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

who should be working on this? (and bug 1350279 for 54)

This is a 53 regression, and we're very close to final betas.

Comment 5

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

This issue happens frequently on the Z3C when the video decoder can't be recreated. Chrome is broken as well at the same time. Restarting the phone fixes the issue. I think we should get a front-end fix that gives a better error message.

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

(In reply to Anthony Jones (:kentuckyfriedtakahe, :k17e) from comment #5)
> This issue happens frequently on the Z3C when the video decoder can't be
> recreated. Chrome is broken as well at the same time. Restarting the phone
> fixes the issue. I think we should get a front-end fix that gives a better
> error message.

ok, can you file a bug on the frontend for a better error?   And rename this one, perhaps repurpose it to provide the front end with the info to give the better error?  Thanks!

Comment 7

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Blake - can I pass this onto you?

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

[Tracking Requested - why for this release]:

We can still take a patch for 53 and may want to fix this in esr52 as well.

Comment 9

[Blake Wu [:bwu][:blakewu]]

(In reply to Anthony Jones (:kentuckyfriedtakahe, :k17e) from comment #7)
> Blake - can I pass this onto you?
Of course! :-)

Comment 10

[Blake Wu [:bwu][:blakewu]]

Sadly, I cannot repro this bug with my Z3C. 
Sorina,
Can you help repro this bug with the devices you have?

Comment 11

[Blake Wu [:bwu][:blakewu]]

Anthony, 
Which Android version on you Z3C?

Comment 12

[Sorina Florean [:sflorean]]

Attachment: log1.Video can't be played.txt

Hello, tested with different versions of Android and here are the results:

- Huawei Honor (Android 5.1.1) on fandom.wikia.com the following message is displayed: log1. + https://i.imgur.com/gpFLNxi.png and on foxnews: https://i.imgur.com/1eJkaYM.png. On twitch.tv the video started to play but then the image freezes and sound don't, will be log2. 
Same results for Huawei MediaPad M2 (Android 5.1.1) and HTC Desire 820 (Android 6.0.1).

- Motorola Nexus 6 (Android 7.0): the video from fandom.wikia.com has the same behavior like twitch.tv, both are start playing then freeze, but the sound keeps playing. 

I didn't manage to reproduce on youtube videos, cnn.com videos, imdb, nbcnews.com, reddit, techcrunch.
If I can test some particular sites, please let me know.

Comment 13

[Sorina Florean [:sflorean]]

Attachment: log2.Video play but then freezes.txt

Comment 14

[Blake Wu [:bwu][:blakewu]]

Thanks for your prompt reply. 
Which version of Firefox you are using for testing? Can you help find which version of Firefox has this problem?

Comment 15

[Sorina Florean [:sflorean]]

Sorry for not write that down.
 I've tested on all latest versions that are affected at bug flags: 53, 54, 55 except version 52, witch I did't.But, I can test that too if is needed.  I saw now that I've got also the message: Error while decoding media resource, on twitch.tv, on Nightly.

Comment 16

[Blake Wu [:bwu][:blakewu]]

(In reply to Sorina Florean [:sorina] from comment #12)
> Created attachment 8853380 [details]
> log1.Video can't be played.txt
> 
> Hello, tested with different versions of Android and here are the results:
> 
> - Huawei Honor (Android 5.1.1) on fandom.wikia.com the following message is
> displayed: log1. + https://i.imgur.com/gpFLNxi.png and on foxnews:
> https://i.imgur.com/1eJkaYM.png. On twitch.tv the video started to play but
> then the image freezes and sound don't, will be log2. 
> Same results for Huawei MediaPad M2 (Android 5.1.1) and HTC Desire 820
> (Android 6.0.1).
> 
> - Motorola Nexus 6 (Android 7.0): the video from fandom.wikia.com has the
> same behavior like twitch.tv, both are start playing then freeze, but the
> sound keeps playing. 
> 
> I didn't manage to reproduce on youtube videos, cnn.com videos, imdb,
> nbcnews.com, reddit, techcrunch.
> If I can test some particular sites, please let me know.
I can see two kinds of problems in your testing result. One is an error message would appear and the other is playback freeze but sound keeps playing without error message. This bug focus on the first one. The second one should be a known issue on 54 and 55 (should not happen on 53).

Can you help me figure out how these two problems happen in different Firefox versions? In other words, does the first problem happen on all 53/54/55? How about the second problem?
Thank you.

Comment 17

[Sorina Florean [:sflorean]]

With Huawei Honor (Android 5.1.1) on fandom.vikia.com and the same video:
- Nightly - playback freeze but sound is on
- Aurora - message is displayed "Playback error..."
- Beta 7 - message is displayed "Playback error..."

Asus ZenPad 8 (Android 6.0.1) on fandom.vikia.com and the same video:
- Nightly - video is played with no issues, I played 3 videos
- Aurora - message is displayed "Playback error..."
- Beta 7 - message is displayed "Playback error..."

Motorola Nexus 6 (Android 7.0) on fandom.vikia.com and the same video:
- Nightly - playback freeze but sound is on
- Aurora - playback freeze but sound is on
- Beta 7 - video is played with no issues

So I see that what issue is displayed depends on Android versions. On 53 I only saw the message error. Hope this helps.

Comment 18

[Marco Castelluccio [:marco]]

(In reply to Sorina Florean [:sorina] from comment #12)
> Created attachment 8853380 [details]
> log1.Video can't be played.txt
> 
> Hello, tested with different versions of Android and here are the results:
> 
> - Huawei Honor (Android 5.1.1) on fandom.wikia.com the following message is
> displayed: log1. + https://i.imgur.com/gpFLNxi.png and on foxnews:
> https://i.imgur.com/1eJkaYM.png. On twitch.tv the video started to play but
> then the image freezes and sound don't, will be log2. 
> Same results for Huawei MediaPad M2 (Android 5.1.1) and HTC Desire 820
> (Android 6.0.1).
> 
> - Motorola Nexus 6 (Android 7.0): the video from fandom.wikia.com has the
> same behavior like twitch.tv, both are start playing then freeze, but the
> sound keeps playing. 
> 
> I didn't manage to reproduce on youtube videos, cnn.com videos, imdb,
> nbcnews.com, reddit, techcrunch.
> If I can test some particular sites, please let me know.

Do you have a Sony Xperia Z3 Compact? This bug should only be reproducible on these devices, according to Anthony.

The issues with wikia.com and twitch.tv should probably be filed as separate bugs, since they affect different Android versions and different devices.

Comment 19

[Sorina Florean [:sflorean]]

(In reply to Marco Castelluccio [:marco] (PTO until April 3) from comment #18)
> (In reply to Sorina Florean [:sorina] from comment #12)
> > Created attachment 8853380 [details]
> > log1.Video can't be played.txt
> > 
> > Hello, tested with different versions of Android and here are the results:
> > 
> > - Huawei Honor (Android 5.1.1) on fandom.wikia.com the following message is
> > displayed: log1. + https://i.imgur.com/gpFLNxi.png and on foxnews:
> > https://i.imgur.com/1eJkaYM.png. On twitch.tv the video started to play but
> > then the image freezes and sound don't, will be log2. 
> > Same results for Huawei MediaPad M2 (Android 5.1.1) and HTC Desire 820
> > (Android 6.0.1).
> > 
> > - Motorola Nexus 6 (Android 7.0): the video from fandom.wikia.com has the
> > same behavior like twitch.tv, both are start playing then freeze, but the
> > sound keeps playing. 
> > 
> > I didn't manage to reproduce on youtube videos, cnn.com videos, imdb,
> > nbcnews.com, reddit, techcrunch.
> > If I can test some particular sites, please let me know.
> 
> Do you have a Sony Xperia Z3 Compact? This bug should only be reproducible
> on these devices, according to Anthony.
> 
> The issues with wikia.com and twitch.tv should probably be filed as separate
> bugs, since they affect different Android versions and different devices.

No, I don't have a Sony Xperia device. Should I file another bugs?

Comment 20

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hi Blake, Dolske, Jesup suggested a better front end error message in comment 6. Thoughts?

I believe it is too late to take this in 53. I'd like to wontfix for 53 and hoping you guys will have something ready to uplift to Aurora54/Beta54 soon. Thanks!

Comment 21

[Marco Castelluccio [:marco]]

(In reply to Sorina Florean [:sorina] from comment #19)
> (In reply to Marco Castelluccio [:marco] (PTO until April 3) from comment
> #18)
> > (In reply to Sorina Florean [:sorina] from comment #12)
> > > Created attachment 8853380 [details]
> > > log1.Video can't be played.txt
> > > 
> > > Hello, tested with different versions of Android and here are the results:
> > > 
> > > - Huawei Honor (Android 5.1.1) on fandom.wikia.com the following message is
> > > displayed: log1. + https://i.imgur.com/gpFLNxi.png and on foxnews:
> > > https://i.imgur.com/1eJkaYM.png. On twitch.tv the video started to play but
> > > then the image freezes and sound don't, will be log2. 
> > > Same results for Huawei MediaPad M2 (Android 5.1.1) and HTC Desire 820
> > > (Android 6.0.1).
> > > 
> > > - Motorola Nexus 6 (Android 7.0): the video from fandom.wikia.com has the
> > > same behavior like twitch.tv, both are start playing then freeze, but the
> > > sound keeps playing. 
> > > 
> > > I didn't manage to reproduce on youtube videos, cnn.com videos, imdb,
> > > nbcnews.com, reddit, techcrunch.
> > > If I can test some particular sites, please let me know.
> > 
> > Do you have a Sony Xperia Z3 Compact? This bug should only be reproducible
> > on these devices, according to Anthony.
> > 
> > The issues with wikia.com and twitch.tv should probably be filed as separate
> > bugs, since they affect different Android versions and different devices.
> 
> No, I don't have a Sony Xperia device. Should I file another bugs?

Yes, I think so. Probably one bug per website, since they look like different problems (and if they end up being the same problem, they can be resolved as duplicates).

Comment 22

[Blake Wu [:bwu][:blakewu]]

Kaku,
Can you help on this bug?
Thanks.

Comment 23

[Blake Wu [:bwu][:blakewu]]

If the error: "Video can't be played because the file is corrupt." or "Playback error" is due to insufficient decoder resource, maybe decoder-shutdown can benefit this bug.

Comment 24

[Tzuhao Kuo [:kaku]]

Quick update here:

1. I can reproduce the case of "playback freeze but sound is on" at twitch.tv on almost devices and I think the root cause is a regression of OOP-decoding in fennec. The regression should already be resolved via bug 1349883, which is landed into m-c 10 hours ago.

2. I can reproduce the case shown in this screen shot, https://i.imgur.com/1eJkaYM.png, provided by :sorina. Looking into debug logs, I think this is something about supporting HLS in fennec. We're now working on supporting HLS natively and we should have already a work-around for play HLS with external APPs but somehow the work-around doesn't work at foxnews.com at the moment. 

3. I cannot reproduce the case shown in this screen shot, https://i.imgur.com/gpFLNxi.png, or any situation in the following list:
> With Huawei Honor (Android 5.1.1) on fandom.vikia.com and the same video:
> - Nightly - playback freeze but sound is on
> - Aurora - message is displayed "Playback error..."
> - Beta 7 - message is displayed "Playback error..."
> 
> Asus ZenPad 8 (Android 6.0.1) on fandom.vikia.com and the same video:
> - Nightly - video is played with no issues, I played 3 videos
> - Aurora - message is displayed "Playback error..."
> - Beta 7 - message is displayed "Playback error..."
May I have the exact link to the video which encounters this issue?

Keep myself in-ed.

Comment 25

[Tzuhao Kuo [:kaku]]

(In reply to Tzuhao Kuo [:kaku] from comment #24)
> Quick update here:
> 
> 1. I can reproduce the case of "playback freeze but sound is on" at
> twitch.tv on almost devices and I think the root cause is a regression of
> OOP-decoding in fennec. The regression should already be resolved via bug
> 1349883, which is landed into m-c 10 hours ago.
-> bug 1356539.

> 2. I can reproduce the case shown in this screen shot,
> https://i.imgur.com/1eJkaYM.png, provided by :sorina. Looking into debug
> logs, I think this is something about supporting HLS in fennec. We're now
> working on supporting HLS natively and we should have already a work-around
> for play HLS with external APPs but somehow the work-around doesn't work at
> foxnews.com at the moment. 
-> bug 1356942.

Comment 26

[Sorina Florean [:sflorean]]

(In reply to Tzuhao Kuo [:kaku] from comment #24)
> 
> 3. I cannot reproduce the case shown in this screen shot,
> https://i.imgur.com/gpFLNxi.png, or any situation in the following list:
> > With Huawei Honor (Android 5.1.1) on fandom.vikia.com and the same video:
> > - Nightly - playback freeze but sound is on
> > - Aurora - message is displayed "Playback error..."
> > - Beta 7 - message is displayed "Playback error..."
> > 
> > Asus ZenPad 8 (Android 6.0.1) on fandom.vikia.com and the same video:
> > - Nightly - video is played with no issues, I played 3 videos
> > - Aurora - message is displayed "Playback error..."
> > - Beta 7 - message is displayed "Playback error..."
> May I have the exact link to the video which encounters this issue?
> 
Tested again with Asus ZenPad 8 (Android 6.0.1) and Huawei Honor (Android 5.1.1):
 - On Nightly 55.0a1, on both devices, the video was played with no issues.  
 - On Aurora 54.0a2 with both devices
    - go to http://fandom.wikia.com/articles/orphan-black-trailer-will-die-season-5 and play the video;
    - scroll down to reach the "latest videos" section;
    - tap on first video (http://fandom.wikia.com/videos/7-upcoming-comic-book-movies-cant-miss) and I get the message "Playback error..."
    - On Aurora 54.0a2 with Asus ZenPad 8 (Android 6.0.1) the both videos was played with no issues
 - On 53 Beta 11 same behavior as 54.0a2 with both devices and following the same steps.

Comment 27

[Julien Cristau [:jcristau]]

fennec issue, clearing flags for esr52.

Comment 28

[Tzuhao Kuo [:kaku]]

(In reply to Sorina Florean [:sorina] from comment #26)
> (In reply to Tzuhao Kuo [:kaku] from comment #24)
> > 
> > 3. I cannot reproduce the case shown in this screen shot,
> > https://i.imgur.com/gpFLNxi.png, or any situation in the following list:
> > > With Huawei Honor (Android 5.1.1) on fandom.vikia.com and the same video:
> > > - Nightly - playback freeze but sound is on
> > > - Aurora - message is displayed "Playback error..."
> > > - Beta 7 - message is displayed "Playback error..."
> > > 
> > > Asus ZenPad 8 (Android 6.0.1) on fandom.vikia.com and the same video:
> > > - Nightly - video is played with no issues, I played 3 videos
> > > - Aurora - message is displayed "Playback error..."
> > > - Beta 7 - message is displayed "Playback error..."
> > May I have the exact link to the video which encounters this issue?
> > 
> Tested again with Asus ZenPad 8 (Android 6.0.1) and Huawei Honor (Android
> 5.1.1):
>  - On Nightly 55.0a1, on both devices, the video was played with no issues.  
>  - On Aurora 54.0a2 with both devices
>     - go to
> http://fandom.wikia.com/articles/orphan-black-trailer-will-die-season-5 and
> play the video;
>     - scroll down to reach the "latest videos" section;
>     - tap on first video
> (http://fandom.wikia.com/videos/7-upcoming-comic-book-movies-cant-miss) and
> I get the message "Playback error..."
>     - On Aurora 54.0a2 with Asus ZenPad 8 (Android 6.0.1) the both videos
> was played with no issues
I don't get the idea here, so the "Playback error..." can only be reproduced on Huawei Honor (Android 5.1.1)?
>  - On 53 Beta 11 same behavior as 54.0a2 with both devices and following the
> same steps.
Same here. Does this means that Asus ZenPad 8 (Android 6.0.1) is okay, but Huawei Honor (Android 5.1.1) cannot play the video?

Comment 29

[Sorina Florean [:sflorean]]

Here is the testing report more clearer. Sorry for any inconvenience. 

Tested again with Asus ZenPad 8 (Android 6.0.1) and Huawei Honor (Android 5.1.1):
 - On Nightly 55.0a1, on both devices, the video was played with no issues.  
 - On Aurora 54.0a2 with Asus ZenPad 8 (Android 6.0.1) and Huawei Honor (Android 5.1.1)
    - go to http://fandom.wikia.com/articles/orphan-black-trailer-will-die-season-5 and play the video;
    - scroll down to reach the "latest videos" section;
    - tap on first video (http://fandom.wikia.com/videos/7-upcoming-comic-book-movies-cant-miss) and I get the message "Playback error..."
 - On 53 Beta 11 with Asus ZenPad 8 (Android 6.0.1) and Huawei Honor (Android 5.1.1)
    - go to http://fandom.wikia.com/articles/orphan-black-trailer-will-die-season-5 and play the video;
    - scroll down to reach the "latest videos" section;
    - tap on first video (http://fandom.wikia.com/videos/7-upcoming-comic-book-movies-cant-miss) and I get the message "Playback error..."

Comment 30

[Liz Henry (:lizzard) (relman/hg->git project)]

Based on comment 29, marking this as fixed in nightly 55. 
Do we know what fixed this issue?  If we can figure that out we could still take a patch for 54.

Comment 31

[Marco Castelluccio [:marco]]

This bug is actually due to a OS bug with the Z3C (see comment 5 and 6). When this OS bug occurs, Firefox prints a misleading error message saying "Video can't be played because the file is corrupt".

The problems Sorina were seeing are different and should be filed as separate bugs.

Comment 32

[Justin Dolske [:Dolske]]

Is there anything Firefox can do about the actual error? If so we should probably have one bug for adding a better error message, and a separate bug about avoiding the error in the first place.

Also, ultimately the front-end can't display a better error unless the media back end gives us a specific error code. So that would need to happen first anyway.

Comment 33

[Gerry Chang [:gchang]]

Hi Blake,
Can you help shed some light here according to comment #31 & #32?

Comment 34

[Blake Wu [:bwu][:blakewu]]

John, 
Can you help check it?

Comment 35

[John Lin [:jhlin][:jolin]]

(In reply to Justin Dolske [:Dolske] from comment #32)
> Is there anything Firefox can do about the actual error? If so we should
> probably have one bug for adding a better error message, and a separate bug
> about avoiding the error in the first place.
> 
> Also, ultimately the front-end can't display a better error unless the media
> back end gives us a specific error code. So that would need to happen first
> anyway.

 I guess we could encode error condition in MediaError.message reported by media element for front-end to examine. Filed bug 1364343 for this.

 As for avoiding the error, bug 1350279 already has a fix for 55 (and 54 if uplifted). And as Blake said in comment 16, 53 shouldn't be affected by the Z3C bug (it falls back to SW decoder when HW fails to create).

Comment 36

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

as it's wontfix for 53

Comment 37

[Gerry Chang [:gchang]]

54 RC build is released. Mark 54 won't fix.

Comment 38

[Liz Henry (:lizzard) (relman/hg->git project)]

I think we can just close this bug since bug 1350279 (the actual error) is fixed, and we have bug 1364343 for what's left (changing the error message).