Closed
Bug 1350745
Opened 7 years ago
Closed 7 years ago
satchelFormListener's prefs observer is very expensive
Categories
(Toolkit :: Form Manager, defect)
Toolkit
Form Manager
Tracking
()
RESOLVED
DUPLICATE
of bug 1250473
Performance Impact | high |
People
(Reporter: ehsan.akhgari, Unassigned)
References
(Blocks 1 open bug)
Details
In this profile, the hash table lookup under AddObserver in the init() method is taking 91ms! https://perfht.ml/2nl6M4z This observer <http://searchfox.org/mozilla-central/rev/7419b368156a6efa24777b21b0e5706be89a9c2f/toolkit/components/satchel/formSubmitListener.js#28> is used to keep three boolean prefs uptodate.
Updated•7 years ago
|
Component: Password Manager → Form Manager
Updated•7 years ago
|
Whiteboard: [qf]
Reporter | ||
Comment 2•7 years ago
|
||
(In reply to Matthew N. [:MattN] (behind on bugmail; PM if requests are blocking you) from comment #1) > I suspect bug 1250473 would help to do this less often. Yes, I think you're right. In fact, isn't this bug just a dupe of bug 1250473?
Whiteboard: [qf] → [qf:p1]
Comment 3•7 years ago
|
||
Fixing bug 1250473 will fix this but I didn't know if there was a more targeted fix wanted here so that's why I didn't dupe. I think it makes sense to just do bug 1250473 though.
Reporter | ||
Comment 4•7 years ago
|
||
Agreed.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
Updated•2 years ago
|
Performance Impact: --- → P1
Whiteboard: [qf:p1]
You need to log in
before you can comment on or make changes to this bug.
Description
•