Closed Bug 1250473 Opened 6 years ago Closed 5 years ago

[e10s] convert formSubmitListener.js to a process script instead of a frame script

Categories

(Toolkit :: Form Manager, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
e10s + ---
firefox55 --- fixed

People

(Reporter: Gijs, Assigned: ehsan.akhgari)

References

(Blocks 3 open bugs)

Details

(Keywords: meta, Whiteboard: [qf:p1])

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1195386 +++

It seems to me this should be a process script. There is nothing tab-specific about it, all it does is send up a message to the parent to deal with the login entry / form entries, for processing there. Right now every content frame gets its own copy of it, including the memory overhead, the pref observer, and the earlyformsubmit observer.
The satchel component is "Form Manager"
Component: Password Manager → Form Manager
Blocks: 1350745
Whiteboard: [qf]
Whiteboard: [qf] → [qf:p1]
Duplicate of this bug: 1350745
Blocks: UIJank
This saves the cost of loading this script once per frame.
Attachment #8858447 - Flags: review?(MattN+bmo)
Assignee: nobody → ehsan
Comment on attachment 8858447 [details] [diff] [review]
Convert formSubmitListener.js to a process script instead of a frame script

Review of attachment 8858447 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8858447 - Flags: review?(MattN+bmo) → review+
Thank you for the quick review!
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3d8a235f1789
Convert formSubmitListener.js to a process script instead of a frame script; r=MattN
https://hg.mozilla.org/mozilla-central/rev/3d8a235f1789
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.