Closed
Bug 1250473
Opened 9 years ago
Closed 8 years ago
[meta] [e10s] convert formSubmitListener.js to a process script instead of a frame script
Categories
(Toolkit :: Form Manager, defect, P3)
Toolkit
Form Manager
Tracking
()
People
(Reporter: Gijs, Assigned: ehsan.akhgari)
References
(Blocks 3 open bugs)
Details
(Keywords: meta)
Attachments
(1 file)
|
5.11 KB,
patch
|
MattN
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1195386 +++ It seems to me this should be a process script. There is nothing tab-specific about it, all it does is send up a message to the parent to deal with the login entry / form entries, for processing there. Right now every content frame gets its own copy of it, including the memory overhead, the pref observer, and the earlyformsubmit observer.
|
||
Updated•9 years ago
|
|
||
Comment 1•9 years ago
|
||
The satchel component is "Form Manager"
Component: Password Manager → Form Manager
|
||
Updated•8 years ago
|
Whiteboard: [qf]
|
|
||
Updated•8 years ago
|
Whiteboard: [qf] → [qf:p1]
|
Assignee | |
Comment 3•8 years ago
|
||
This saves the cost of loading this script once per frame.
Attachment #8858447 -
Flags: review?(MattN+bmo)
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → ehsan
|
|
||
Comment 4•8 years ago
|
||
Comment on attachment 8858447 [details] [diff] [review] Convert formSubmitListener.js to a process script instead of a frame script Review of attachment 8858447 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8858447 -
Flags: review?(MattN+bmo) → review+
|
|
Assignee | |
Comment 5•8 years ago
|
||
Thank you for the quick review!
Pushed by eakhgari@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/3d8a235f1789 Convert formSubmitListener.js to a process script instead of a frame script; r=MattN
|
|
||
Comment 7•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/3d8a235f1789
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
||
Updated•3 years ago
|
Performance Impact: --- → P1
Whiteboard: [qf:p1]
|
||
Updated•3 years ago
|
Summary: [e10s] convert formSubmitListener.js to a process script instead of a frame script → [meta] [e10s] convert formSubmitListener.js to a process script instead of a frame script
You need to log in
before you can comment on or make changes to this bug.
Description
•