Closed
Bug 1350766
Opened 7 years ago
Closed 7 years ago
Use Songti TC and Songti SC as default font in the default font list
Categories
(Core :: Graphics: Text, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla57
People
(Reporter: timdream, Assigned: timdream)
References
Details
Attachments
(1 file)
Songti TC and Songti SC should be used ahead of STSong or LiSong Pro, for zh-TW/HK and zh-CN.
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•7 years ago
|
||
More context here: Songti TC/SC are new fonts since OS X Mavericks. Given that it's possible to disable/remove old system fonts in the new macOS, we should get this listed in our default font list to avoid fallback to incorrect font (for example, w/ our current list user will see Heiti TC (a sans-serif font) if LiSong Pro was uninstalled). It is unclear to me how LiSong Pro was uninstalled from my system, but I pretty sure it does on it's own maybe when I checked the available storage. Songti is noticeably looks heaver. I would say it's better but this can be a subjective opinion.
Assignee | ||
Updated•7 years ago
|
Attachment #8852374 -
Flags: review?(jfkthame)
Comment 3•7 years ago
|
||
How about default font of Chrome and Safari? Do they changes to Songti TC and Songti SC?
Assignee | ||
Comment 4•7 years ago
|
||
I can confirm Chrome and Safari both use Songti TC/SC.
Assignee | ||
Comment 5•7 years ago
|
||
Kato, could you steal review?
Comment 6•7 years ago
|
||
(In reply to Tim Guan-tin Chien [:timdream] (please needinfo) from comment #5) > Kato, could you steal review? We should use EARLY_BETA_OR_EARLIER like Bug 548311 when changing default font at first. 1st reason is for web compatibility and 2nd reason is that new font might have unexpected another bug (see comment of MacOSFontEntry::ReadCMAP()).
Comment hidden (mozreview-request) |
Comment 8•7 years ago
|
||
mozreview-review |
Comment on attachment 8852374 [details] Bug 1350766 - Add Songti TC/SC to zh-CN/HK/TW default serif font list for MacOS, https://reviewboard.mozilla.org/r/124620/#review182218 If there is no ciritical issue after this,let's turn on this on release chnanel of 58 or 59.
Attachment #8852374 -
Flags: review?(m_kato) → review+
Comment 9•7 years ago
|
||
Also, we should post this change to dev.platform.
Assignee | ||
Comment 10•7 years ago
|
||
Intent to ship sent. Will land this tomorrow.
Assignee | ||
Updated•7 years ago
|
status-firefox56:
--- → wontfix
Comment 11•7 years ago
|
||
Pushed by timdream@gmail.com: https://hg.mozilla.org/integration/autoland/rev/8a1c6347f795 Add Songti TC/SC to zh-CN/HK/TW default serif font list for MacOS, r=m_kato
Comment 12•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8a1c6347f795
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•