1419277 - Use Songti TC/SC in release

Status: RESOLVED FIXED

(Core :: Graphics: Text, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Follow up to bug 1350766.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Bug 1419277 - Set Songti TC/SC as default zh-{CN/HK/TW} font in release

Review commit: https://reviewboard.mozilla.org/r/201488/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/201488/

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Bug 1419277 - Follow-up, remove old & duplicate fonts from macOS default

Given that we only support macOS >= 10.9 nowadays, we don't need
to consider fallbacks on old systems anymore.

Removing LiHei Pro & LiSong Pro because they are old.
Removing STSong & STHeiti because they are simply old font names aliased to new Songti/Heiti SC.

Review commit: https://reviewboard.mozilla.org/r/201490/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/201490/

Comment 3

[Makoto Kato [:m_kato]]

Comment on attachment 8930350 [details]
Bug 1419277 - Set Songti TC/SC as default zh-{CN/HK/TW} font in release

https://reviewboard.mozilla.org/r/201488/#review206776

Comment 4

[Makoto Kato [:m_kato]]

Comment on attachment 8930351 [details]
Bug 1419277 - Follow-up, remove old & duplicate fonts from macOS default

https://reviewboard.mozilla.org/r/201490/#review206784

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fb7168d4da8c
Set Songti TC/SC as default zh-{CN/HK/TW} font in release r=m_kato
https://hg.mozilla.org/integration/autoland/rev/c5326ebf17f2
Follow-up, remove old & duplicate fonts from macOS default r=m_kato

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/fb7168d4da8c
https://hg.mozilla.org/mozilla-central/rev/c5326ebf17f2

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8930350 [details]
Bug 1419277 - Set Songti TC/SC as default zh-{CN/HK/TW} font in release

Approval Request Comment
[Feature/Bug causing the regression]: feature
[User impact if declined]: not seeing default font updated
[Is this code covered by automated tests?]: N/A
[Has the fix been verified in Nightly?]: none
[Needs manual test from QE? If yes, steps to reproduce]: none
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: just a pref change that has lived in nightly for more than a cycle already
[String changes made/needed]: none

Comment 8

[Eric Rahm [:erahm]]

(In reply to Tim Guan-tin Chien [:timdream] (please needinfo) from comment #7)
> Comment on attachment 8930350 [details]
> Bug 1419277 - Set Songti TC/SC as default zh-{CN/HK/TW} font in release
> 
> Approval Request Comment
> [Feature/Bug causing the regression]: feature
> [User impact if declined]: not seeing default font updated
> [Is this code covered by automated tests?]: N/A
> [Has the fix been verified in Nightly?]: none
> [Needs manual test from QE? If yes, steps to reproduce]: none
> [List of other uplifts needed for the feature/fix]: none
> [Is the change risky?]: no
> [Why is the change risky/not risky?]: just a pref change that has lived in
> nightly for more than a cycle already
> [String changes made/needed]: none

Can we hold off on the uplift until we understand the memory regression?

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to (Out until Dec 5) Eric Rahm [:erahm] (please no mozreview requests) from comment #8)
> Can we hold off on the uplift until we understand the memory regression?

Definitely.