1350774 - [e10s] Background on <select> options is blue when opened for the first time

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[blinky]

Steps to reproduce:

1. Go to https://onedrive.live.com/download?cid=F96BA52A2AF70D03&resid=F96BA52A2AF70D03%21762&authkey=AI0V7mSlwtks0cs.
2. Open the <select> element.


Actual results:

The background is blue when opened for the first time.

Screenshot https://1drv.ms/i/s!AgMN9yoqpWv5hXu_yh3fvw_dWgy_

Comment 1

[blinky]

Regression range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=9da1857374780d5fc4c8babf11bf2d1ac8443bd4&tochange=4dafc922f1cbfef52fbd736f6b6cb5c15d9bd3f1

Regressed by: bug 1336301

Comment 2

[blinky]

(In reply to blinky from comment #1)
> Regression range:
> https://hg.mozilla.org/integration/autoland/
> pushloghtml?fromchange=9da1857374780d5fc4c8babf11bf2d1ac8443bd4&tochange=4daf
> c922f1cbfef52fbd736f6b6cb5c15d9bd3f1
> 
> Regressed by: bug 1336301

Oops, I posted the wrong range.

Comment 3

[blinky]

Regression range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0ab9adff3faf4c52b0e1dc52b0f61bd3add3cff4&tochange=4a98ffe94e12f9ece29bbccdaf278fff66874627

Regressed by: bug 1349701

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1350774 - Some pages may style their <option> elements based on the :focus of the <select>, so :focus should be locked on the <select> during color computation.

Review commit: https://reviewboard.mozilla.org/r/124388/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/124388/

Comment 5

[Dave Townsend [:mossop]]

Comment on attachment 8852160 [details]
Bug 1350774 - Some pages may style their <option> elements based on the :focus of the <select>, so :focus should be locked on the <select> during color computation.

https://reviewboard.mozilla.org/r/124388/#review126972

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f4b0863cd843
Some pages may style their <option> elements based on the :focus of the <select>, so :focus should be locked on the <select> during color computation. r=mossop

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f4b0863cd843

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8852160 [details]
Bug 1350774 - Some pages may style their <option> elements based on the :focus of the <select>, so :focus should be locked on the <select> during color computation.

Approval Request Comment
[Feature/Bug causing the regression]: regression from bug 910022
[User impact if declined]: <select> menus may look broken on some webpages
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: not "verified" but it has been on nightly for some time now with no bugs filed against it and the bug reporter has done an amazing job hunting for bugs with the feature
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: this patch must be applied on top of the patch from bug 1350662
[Is the change risky?]: no
[Why is the change risky/not risky?]: limited to just select popups, this is following other patches that have been uplifted to for bug 910022
[String changes made/needed]: none

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #8)
> [Has the fix been verified in Nightly?]: not "verified" but it has been on
> nightly for some time now with no bugs filed against it and the bug reporter
> has done an amazing job hunting for bugs with the feature

Sorry, scratch the above. This just landed on Nightly yesterday, though after letting it sit on Nightly for a few days we should be able to uplift it.

Comment 10

[Gerry Chang [:gchang]]

Comment on attachment 8852160 [details]
Bug 1350774 - Some pages may style their <option> elements based on the :focus of the <select>, so :focus should be locked on the <select> during color computation.

Fix a regression related to <select> element and was verified in comment #13 of bug 1348617. Aurora54+.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a2f248438fc2