Closed
Bug 1350912
Opened 7 years ago
Closed 7 years ago
TIAS can be below the minimum bitrate for high-resolution streams (especially screensharing)
Categories
(Core :: WebRTC: Networking, enhancement, P1)
Tracking
()
RESOLVED
FIXED
mozilla55
People
(Reporter: jesup, Assigned: jesup)
References
Details
Attachments
(1 file)
|
2.47 KB,
patch
|
drno
:
review+
|
Details | Diff | Splinter Review |
If you have for example TIAS of 600Kbps, and are sharing a 1900x1200 screen, the TIAS rate can be below the minimum rate selected in SelectBitrates, and this can lead to invalid bitrate options fed to webrtc.org code. We should respect the TIAS rate, even if it's silly.
|
Assignee | |
Comment 1•7 years ago
|
||
MozReview-Commit-ID: DH1rFn53sNN
Attachment #8851598 -
Flags: review?(drno)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8851598 [details] [diff] [review] Set min and start bandwidth according to b=TIAS, instead of only max Review of attachment 8851598 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #8851598 -
Flags: review?(drno) → review+
Pushed by rjesup@wgate.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/13eb53195041 Set min and start bandwidth according to b=TIAS, instead of only max r=drno
|
||
Updated•7 years ago
|
Rank: 19
Priority: -- → P1
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/13eb53195041
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
||
Comment 5•7 years ago
|
||
I'm assuming this doesn't need to go in 54, feel free to reset the flag and request uplift if I got this wrong.
You need to log in
before you can comment on or make changes to this bug.
Description
•