1350974 - Cancelling installer UAC prompt closes installer

Status: VERIFIED FIXED

(Firefox :: Installer, defect)

Description

[Molly Howell (she/her) (mostly inactive)]

STR:
1) Run a Firefox installer (stub or full, any channel)
2) Cancel the resulting UAC prompt

Expected behavior:
The installer offers a default install path inside the user's home directory, then installation proceeds as normal without ever requiring elevation.

Actual behavior:
The installer exits.

Comment 1

[Molly Howell (she/her) (mostly inactive)]

Attachment: Bug 1350974 - Continue installing unelevated if the UAC prompt is rejected, and don't prompt a second time in the stub installer.

Review commit: https://reviewboard.mozilla.org/r/123922/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/123922/

Comment 2

[Molly Howell (she/her) (mostly inactive)]

Comment on attachment 8851661 [details]
Bug 1350974 - Continue installing unelevated if the UAC prompt is rejected, and don't prompt a second time in the stub installer.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/123922/diff/1-2/

Comment 3

[Molly Howell (she/her) (mostly inactive)]

Comment on attachment 8851661 [details]
Bug 1350974 - Continue installing unelevated if the UAC prompt is rejected, and don't prompt a second time in the stub installer.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/123922/diff/2-3/

Comment 4

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

Comment on attachment 8851661 [details]
Bug 1350974 - Continue installing unelevated if the UAC prompt is rejected, and don't prompt a second time in the stub installer.

https://reviewboard.mozilla.org/r/123922/#review126536

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ecd628a7910
Continue installing unelevated if the UAC prompt is rejected, and don't prompt a second time in the stub installer. r=agashlin

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0ecd628a7910

Comment 7

[Romain Testard [:RT]]

Please confirm the user experience when declining the UAC prompt, does the stub just launch? 
Chrome prompts the user "Google Chrome can be installed without administrative right. Continue?"

Comment 8

[Romain Testard [:RT]]

Michael, this is about allowing a fall-back to users who decline the UAC prompt, so that Firefox gets installed into the user's home directory instead of C:\Program Files. Are you OK with just launching the stub when the user declines the UAC?

Comment 9

[Romain Testard [:RT]]

Now with NI to Michael

Comment 10

[Romain Testard [:RT]]

Actually I am told this is a regression, removing the NI to Michael since we'll implement it the following way:
- User dismisses the UAC prompt
- Installer launches and installs to the user's home directory

Comment 12

[Saddam Hossain]

I have reproduced this Bug on Nightly 55.0a1(2017-03-27) on Windows 10, 64-bit 

The bug's fix is now verified on latest  Nightly 55.0a1 (2017-05-24)

Nightly 55.0a1:
Build ID 	20170524030204
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0

[bugday-20170524]

Comment 13

[Camelia Badau [:cbadau], Desktop Test Engineering]

I've reproduced the initial issue on Windows 7 x64 using Nightly 55.oa1 (2017-03-27).
Verified fixed on Windows 7 x64 and Windows 10 x86 using Firefox 55 Beta 3 (buildID: 20170619071723).

Comment 14

[Chris More [:cmore]]

Romain: can you verify if this is a regression or valid post Quantum stub installer?

Comment 15

[Romain Testard [:RT]]

(In reply to Chris More [:cmore] from comment #14)
> Romain: can you verify if this is a regression or valid post Quantum stub
> installer?

Just tested it's still fixed in Win10 x64  - AFAIK this has been fixed since 55. 
Works as intended:
1 User dismisses the UAC prompt
2 Installer launches and installs to the user's home directory