This parameter appears to have been superseded by `is_nightly`.
Comment on attachment 8851735 [details] Bug 1351011: remove unused triggered_by property; https://reviewboard.mozilla.org/r/123964/#review126496 I don't see anything in-tree that is *reading* this value, based on grepping. The --triggered-by option isn't set in cron tasks, nor in `.taskcluster.yml`. It will cause a little inconvenience for users who will need to get a new parameters.yml file for testing, but aside from that I don't think this should cause any issues. Aside from a try push, can you think of any worthwhile ways to double-check?
Comment on attachment 8851735 [details] Bug 1351011: remove unused triggered_by property; https://reviewboard.mozilla.org/r/123964/#review126780 Clearing review for now: https://github.com/mozilla/releasetasks/blob/acf9ee39ca27aa2aadb59d5623872aee500e44c4/releasetasks/templates/fennec/candidates_fennec.yml.tmpl and its also currently in the fennec hook (I need to bump this to use cron) https://tools.taskcluster.net/hooks/#project-releng/nightly-fennec-dev I would support either option of figuring out these deps first, or leaving the option as valid but with "deprecated (ignored)"
Attachment #8851735 - Flags: review?(bugspam.Callek)
I can wait :) Can you link this bug appropriately?
Hey Dustin, I think this is able to be worked on now, I sadly forgot to link bugz.
Flags: needinfo?(dustin) → needinfo?(bugspam.Callek)
Comment on attachment 8851735 [details] Bug 1351011: remove unused triggered_by property; https://reviewboard.mozilla.org/r/123964/#review146438
Attachment #8851735 - Flags: review+
Let's just run that in try one more time :)
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/ae7d78d08816 remove unused triggered_by property; r=Callek
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
and this broke fennec betas because ... releasetasks which uses taskgraph outside of tree: https://github.com/mozilla-releng/releasetasks/blob/master/releasetasks/templates/mobile/candidates_fennec.yml.tmpl#L43 sigh, one day in the glorious future everything will be perfect.
You need to log in before you can comment on or make changes to this bug.