Remove the `triggered_by` parameter

RESOLVED FIXED in mozilla55

Status

task
RESOLVED FIXED
2 years ago
Last year

People

(Reporter: dustin, Assigned: dustin)

Tracking

unspecified
mozilla55
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

This parameter appears to have been superseded by `is_nightly`.
Comment hidden (mozreview-request)
Assignee

Comment 2

2 years ago
mozreview-review
Comment on attachment 8851735 [details]
Bug 1351011: remove unused triggered_by property;

https://reviewboard.mozilla.org/r/123964/#review126496

I don't see anything in-tree that is *reading* this value, based on grepping.  The --triggered-by option isn't set in cron tasks, nor in `.taskcluster.yml`.  It will cause a little inconvenience for users who will need to get a new parameters.yml file for testing, but aside from that I don't think this should cause any issues.  Aside from a try push, can you think of any worthwhile ways to double-check?

Comment 3

2 years ago
mozreview-review
Comment on attachment 8851735 [details]
Bug 1351011: remove unused triggered_by property;

https://reviewboard.mozilla.org/r/123964/#review126780

Clearing review for now:

https://github.com/mozilla/releasetasks/blob/acf9ee39ca27aa2aadb59d5623872aee500e44c4/releasetasks/templates/fennec/candidates_fennec.yml.tmpl

and its also currently in the fennec hook (I need to bump this to use cron)

https://tools.taskcluster.net/hooks/#project-releng/nightly-fennec-dev

I would support either option of figuring out these deps first, or leaving the option as valid but with "deprecated (ignored)"
Attachment #8851735 - Flags: review?(bugspam.Callek)
I can wait :)

Can you link this bug appropriately?
Hey Dustin, I think this is able to be worked on now, I sadly forgot to link bugz.
Flags: needinfo?(dustin)
Thanks
Flags: needinfo?(dustin) → needinfo?(bugspam.Callek)

Comment 7

2 years ago
mozreview-review
Comment on attachment 8851735 [details]
Bug 1351011: remove unused triggered_by property;

https://reviewboard.mozilla.org/r/123964/#review146438
Attachment #8851735 - Flags: review+
Flags: needinfo?(bugspam.Callek)
Let's just run that in try one more time :)

Comment 9

2 years ago
Pushed by dmitchell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ae7d78d08816
remove unused triggered_by property; r=Callek

Comment 10

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ae7d78d08816
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
and this broke fennec betas because ... releasetasks which uses taskgraph outside of tree: https://github.com/mozilla-releng/releasetasks/blob/master/releasetasks/templates/mobile/candidates_fennec.yml.tmpl#L43

sigh, one day in the glorious future everything will be perfect.
Depends on: 1372487
Depends on: 1372491

Updated

Last year
Product: TaskCluster → Firefox Build System
You need to log in before you can comment on or make changes to this bug.