1351011 - Remove the `triggered_by` parameter

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

This parameter appears to have been superseded by `is_nightly`.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: Bug 1351011: remove unused triggered_by property;

The purpose of this parameter has been superseded by the `include_nightly`
property.

Review commit: https://reviewboard.mozilla.org/r/123964/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/123964/

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8851735 [details]
Bug 1351011: remove unused triggered_by property;

https://reviewboard.mozilla.org/r/123964/#review126496

I don't see anything in-tree that is *reading* this value, based on grepping.  The --triggered-by option isn't set in cron tasks, nor in `.taskcluster.yml`.  It will cause a little inconvenience for users who will need to get a new parameters.yml file for testing, but aside from that I don't think this should cause any issues.  Aside from a try push, can you think of any worthwhile ways to double-check?

Comment 3

[Justin Wood (:Callek)]

Comment on attachment 8851735 [details]
Bug 1351011: remove unused triggered_by property;

https://reviewboard.mozilla.org/r/123964/#review126780

Clearing review for now:

https://github.com/mozilla/releasetasks/blob/acf9ee39ca27aa2aadb59d5623872aee500e44c4/releasetasks/templates/fennec/candidates_fennec.yml.tmpl

and its also currently in the fennec hook (I need to bump this to use cron)

https://tools.taskcluster.net/hooks/#project-releng/nightly-fennec-dev

I would support either option of figuring out these deps first, or leaving the option as valid but with "deprecated (ignored)"

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

I can wait :)

Can you link this bug appropriately?

Comment 5

[Justin Wood (:Callek)]

Hey Dustin, I think this is able to be worked on now, I sadly forgot to link bugz.

Comment 6

[Dustin J. Mitchell [:dustin] (he/him)]

Thanks

Comment 7

[Justin Wood (:Callek)]

Comment on attachment 8851735 [details]
Bug 1351011: remove unused triggered_by property;

https://reviewboard.mozilla.org/r/123964/#review146438

Comment 8

[Dustin J. Mitchell [:dustin] (he/him)]

Let's just run that in try one more time :)

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae7d78d08816
remove unused triggered_by property; r=Callek

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ae7d78d08816

Comment 11

[Jordan Lund (:jlund)]

and this broke fennec betas because ... releasetasks which uses taskgraph outside of tree: https://github.com/mozilla-releng/releasetasks/blob/master/releasetasks/templates/mobile/candidates_fennec.yml.tmpl#L43

sigh, one day in the glorious future everything will be perfect.