1372487 - remove reference to triggered_by in releasetasks for beta

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, enhancement)

Description

[Jordan Lund (:jlund)]

current fennec betas post merge are broken.

[task 2017-06-13T05:39:23.376815Z] The taskgraph command does not accept the arguments: --triggered-by=nightly

22:40:48 we need to change the releasetasks decision task template
22:46:02 
<•jlund> Jordan Lund how is taskgraph and releasetasks both used here?
22:46:25 
<•aki> https://github.com/mozilla-releng/releasetasks/blob/master/releasetasks/templates/mobile/candidates_fennec.yml.tmpl
22:46:35 we have to remove --triggered-by=nightly on beta, but not release

Comment 1

[Jordan Lund (:jlund)]

Attachment: github releasetasks - only uses triggered-by when doing a beta release

Comment 2

[Mihai Tabara [:mtabara]⌚️GMT]

Comment on attachment 8877022 [details] [review]
github releasetasks - only uses triggered-by when doing a beta release

Patch looks good but as far as I understand the problem as per https://bugzilla.mozilla.org/show_bug.cgi?id=1372487#c0 we need to allow the triggered-by on release but allow it on beta. So I suppose it should be {% if branch == "mozilla-release" %} here instead.

Sadly, I don't have write access to releasetasks so I can't review/merge. Nor can I follow-up there with the fix so I'll just manually tweak this in production to unblock us and we'll deal with this later on when ET/PST folks come online.

Comment 3

[Mihai Tabara [:mtabara]⌚️GMT]

Attachment: Bug 1372487 - keep reference to triggered_by in releasetasks for 54 release only.

Comment 4

[Mihai Tabara [:mtabara]⌚️GMT]

Comment on attachment 8877131 [details] [review]
Bug 1372487 - keep reference to triggered_by in releasetasks for 54 release only.

https://github.com/mozilla-releng/releasetasks/commit/7c30f9c0d807b62b4a66a88dbb4de2e06d9baace

updated both bm{83,85} + restarted supervisor.

Comment 5

[Mihai Tabara [:mtabara]⌚️GMT]

Successfully triggered a Fennec 55.0b1 earlier with this change so I think it's safe to close this for now.
The 55.0 removal of the parameter is tracked in bug 1372491.

Comment 6

[Jordan Lund (:jlund)]

(In reply to Mihai Tabara [:mtabara]⌚️GMT from comment #2)
> Patch looks good but as far as I understand the problem as per
> https://bugzilla.mozilla.org/show_bug.cgi?id=1372487#c0 we need to allow the
> triggered-by on release but allow it on beta. So I suppose it should be {%
> if branch == "mozilla-release" %} here instead.

I blame the wine and time of day. Thanks for driving it through