1351242 - Add wr support for nsDisplayBackgroundImage image type

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Ethan Lin[:ethlin]]

Bug 1341101 handle the gradient type for nsDisplayBackgroundImage. This bug is for image type.

Comment 1

[Ethan Lin[:ethlin]]

Attachment: add wr for background image type

WR doesn't support sub-image, so the display will be wrong if the background-position is not zero. I think we should push sub-image to WR for this case. I will create another bug for it.

Comment 2

[Mason Chang [Inactive] [:mchang]]

Comment on attachment 8855180 [details] [diff] [review]
add wr for background image type

Review of attachment 8855180 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/painting/nsImageRenderer.cpp
@@ +616,5 @@
> +    case eStyleImageType_Image:
> +    {
> +      RefPtr<layers::ImageContainer> container = mImageContainer->GetImageContainer(aLayer->WrManager(),
> +                                                                                    ConvertImageRendererToDrawFlags(mFlags));
> +      if (!container) {

probably for now, we can add debug warnings that the container or external image container don't work.

Comment 3

[Ethan Lin[:ethlin]]

(In reply to Mason Chang [:mchang] from comment #2)
> Comment on attachment 8855180 [details] [diff] [review]
> add wr for background image type
> 
> Review of attachment 8855180 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: layout/painting/nsImageRenderer.cpp
> @@ +616,5 @@
> > +    case eStyleImageType_Image:
> > +    {
> > +      RefPtr<layers::ImageContainer> container = mImageContainer->GetImageContainer(aLayer->WrManager(),
> > +                                                                                    ConvertImageRendererToDrawFlags(mFlags));
> > +      if (!container) {
> 
> probably for now, we can add debug warnings that the container or external
> image container don't work.

Okay, I will add NS_WARNING here.

Comment 4

[Ethan Lin[:ethlin]]

try result looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=bc548a096602d07497e9cf76d5da0b54a6a45f94

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/cff3cf898836
Add webrender support for nsDisplayBackgroundImage image type. r=mchang

Comment 6

[Mason Chang [Inactive] [:mchang]]

This is great and seems to be the most impactful display item type for WR. From what I'm seeing, we often hit the this path [1] then this fast path [2]. Any idea what work needs to be done here to turn this on by default? Thanks!

[1] http://searchfox.org/mozilla-central/source/layout/painting/nsImageRenderer.cpp#515
[2] http://searchfox.org/mozilla-central/source/layout/base/nsLayoutUtils.cpp#6809

Comment 7

[Ethan Lin[:ethlin]]

So far as I know, the background-position support should be necessary and I'll work on this. I suppose there will be some clipping/masking problems. We can have more discussions in bug 1359242.

Comment 8

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/mozilla-central/rev/cff3cf898836