1351511 - Convert nsDisplaySolidColorRegion to WR DisplayItems

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P1)

Comment 2

[Peter Chang[:pchang]]

Michael will help on this case.

Comment 3

[Michael Leu[:Lenzak](UTC+8)]

Attachment: Bug 1351511 - Support nsDisplaySolidColorRegion to WR DisplayItems

Review commit: https://reviewboard.mozilla.org/r/168652/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/168652/

Comment 4

[Michael Leu[:Lenzak](UTC+8)]

Comment on attachment 8897345 [details]
Bug 1351511 - Support nsDisplaySolidColorRegion to WR DisplayItems

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/168652/diff/1-2/

Comment 5

[Michael Leu[:Lenzak](UTC+8)]

Comment on attachment 8897345 [details]
Bug 1351511 - Support nsDisplaySolidColorRegion to WR DisplayItems

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/168652/diff/2-3/

Comment 6

[Michael Leu[:Lenzak](UTC+8)]

Hi Markus

Do you know what circumstances will utilize this display item?

I want to test its correctness, but got no luck entering this part of code.

Comment 7

[Markus Stange [:mstange]]

It's used for the "modal" find bar UI, which you can enable by flipping the pref findbar.modalHighlight to true. If you then search for a word on a page which occurs multiple times, you can see the whole page except for those word occurences go darker. This darkening is achieved by putting an nsDisplaySolidColorRegion with partially-transparent black on top of the page.

Comment 8

[Michael Leu[:Lenzak](UTC+8)]

Attachment: compare_modal_highlight.png

BTW, I found something strange when I enable modal highlight.

The left side is Firefox Beta, and the right one is nightly, webrender is not enabled on both browser.

I use cmd+F to search "wiki" and "free", the left side will clean old highlights when I change my keyword while right side won't.

I have tried webrender/layers-free on/off but it seems that they are irrelevant.

Is that an expected behavior?

Comment 9

[Markus Stange [:mstange]]

That's not expected behavior. Can you still reproduce this? I can't.

Comment 10

[Markus Stange [:mstange]]

Comment on attachment 8897345 [details]
Bug 1351511 - Support nsDisplaySolidColorRegion to WR DisplayItems

https://reviewboard.mozilla.org/r/168652/#review182762

Comment 11

[Michael Leu[:Lenzak](UTC+8)]

Attachment: Screen Shot 2017-09-11 at 10.19.14 AM.png

Yes, still reproducible, both "wiki" and "free" are highlighted after I change my cmd+F keyword

Comment 12

[Michael Leu[:Lenzak](UTC+8)]

(In reply to Michael Leu[:Lenzak](UTC+8) from comment #11)
> Created attachment 8906435 [details]
> Screen Shot 2017-09-11 at 10.19.14 AM.png
> 
> Yes, still reproducible, both "wiki" and "free" are highlighted after I
> change my cmd+F keyword

It also reproducible on Ubuntu, too.

Comment 13

[Markus Stange [:mstange]]

Ah, I couldn't reproduce it because I had the "Highlight All" button checked. Can you please file a new bug for this and make it block bug 1312008? Thanks.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/52e22eaebe72
Support nsDisplaySolidColorRegion to WR DisplayItems r=mstange

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/52e22eaebe72