1398717 - Modal Highlight does not clean old highlight when changing search keyword

Status: NEW

(Core :: Layout, defect, P3)

Description

[Michael Leu[:Lenzak](UTC+8)]

Attachment: compare_modal_highlight.png

The screenshot in attachment demonstrates this problem.


It seems to be a regression.

The left side is Firefox Beta, and the right one is nightly.

I use cmd+F to search "wiki" and "free", the left side will clean old highlights when I change my keyword while right side won't.

It is not platform-dependent, I can reproduce on Ubuntu and Windows as well.

I found it when looking into bug 1351511.

Comment 1

[Michael Leu[:Lenzak](UTC+8)]

OK, it's not a regression, the I accidentally enabled "highlight all" in beta so the issue will be hidden.

So the STR is:

1. Enable "findbar.modalHighlight" in about:config
2. Go to wikipedia.org
3. cmd+f/ctrl+f to invoke search bar, making sure "Hightlight all" is *not* checked
4. Search "wiki", press enter multiple times to make it hightlight several "wiki" strings
5. Search "free", press enter multiple times as well.
6. Hightlight on "wiki" does not disappear