1351621 - [ShowFor] {for fx51} content does not show for Firefox version 51 and above

Status: RESOLVED INVALID

(support.mozilla.org - Lithium :: Knowledge Base Software, defect, P1)

Description

[Alice Wyman]

+++ This bug was initially created as a clone of Bug #1336834 +++

A "Customize this article" picker for Firefox Version 51 is available but doesn't seem to be working (bug 1341813 was filed on a missing version picker in fx52 and above).  Any{for not fx51} content is shown for all Firefox versions. Any {for fx51} content is hidden for all versions.

Examples:

This article (as reported in bug 1336834 comment 9) should display different {for fx51} and {for not fx51} screenshots and related content, under the "Data choices tab" section:
https://support.mozilla.org/t5/Manage-preferences-and-add-ons/Advanced-panel-Accessibility-browsing-network-updates-and-other/ta-p/3333
The {for not fx51} Data Choices tab screenshot and "Enable Crash Reporter ..." paragraph is being shown for all Firefox versions, including 51 or above.  The {for fx51} Data Choices tab screenshot and paragraph, "Allow Firefox to send backlogged crash reports on your behalf ..." is not being shown for Firefox version 51 or above.  I posted a screenshot of the {for fx51} content on 1/24/2017 in the Comments section of that article. I added another comment on 01-27-2017, after updating the article with the new content (both comments appear on page 2).

This article shows the {for not fx51} content, "This is a new feature that is available starting in Firefox version 51." for all versions:
https://support.mozilla.org/t5/Protect-your-privacy/Insecure-password-warning-in-Firefox/ta-p/27861

This article (before my revision to remove the fx51 markup) was not showing the {for fx51} content for Linux, related to PulseAudio:
https://support.mozilla.org/t5/Videos-sound-pictures-and/Fix-common-audio-and-video-issues/ta-p/401
... which I asked about on 03-12-2017 in this discussion thread:
https://support.mozilla.org/t5/Knowledge-Base-L10n-Discussions/Need-help-tracking-localized-versions-of-these-articles/m-p/1372860
(quote)
"@jsavage I just published a new revision to the Fix common audio and video issues article and checked off Needs l10n.  I fixed the showfor issue by removing "for fx51" from the Linux PulseAudio section.  Apparently, setting the section {for fx51, linux} was preventing anyone from seeing it.  Joni, can you check this out and file/update any of the related showfor bugs?"

This article was also not showing for fx51 content, before I revised it to remove for fx51 markup:
https://support.mozilla.org/t5/Display-and-appearance/Font-size-and-zoom-increase-the-size-of-web-pages/tac-p/1382583
I posted the following under the article comments section on 03-27-2017:
(Quote)
"Fx51 showfor isn't working in this article.  As a workaround, I made the address bar screenshot and related text above it viewable for all versions".

Comment 1

[Alice Wyman]

Bug 1336834 covers {for not fx**} content incorrectly shown for all versions so I'll limit this bug to {for fx51} content that does not show for Firefox version 51 and above and I'll update the summary.

Comment 2

[Alice Wyman]

Another article with missing content for fx51+ 

https://hwsfp35778.lithium.com/t5/Procedures-to-diagnose-and-fix/Use-the-Troubleshooting-Information-page-to-help-fix-Firefox/ta-p/3735

The above article shows an image for fx51 and below but the image for fx51 and above is missing, 
https://hwsfp35778.lithium.com/legacyfs/online/sumo-media/gallery/images/2017-01-25-05-18-48-4e28a7.png


as shown in the article HTML:

<span class="for" data-for="fx51"> <img class="wiki-image frameless lazy" src="/legacyfs/online/sumo-media/gallery/images/2017-01-25-05-18-48-4e28a7.png" alt="Fx51aboutsupport" title="" border="0"> </span>

The above image was added to the article on January 25, 2017, before the Lithium migration:
https://support.mozilla.org/en-US/kb/use-troubleshooting-information-page-fix-firefox

Comment 3

[Alice Wyman]

(from comment #2)
> Another article with missing content for fx51+ 
> https://hwsfp35778.lithium.com/t5/Procedures-to-diagnose-and-fix/Use-the-Troubleshooting-Information-page-to-help-fix-Firefox/ta-p/3735 
> The above article shows an image for fx51 and below but the image for fx51 and above is missing 

correction: 
The above article shows an image for fx50 and below but the image for fx51 and above is missing

Comment 4

[Alice Wyman]

See bug 1341813 comment 16 -17.  Looks like this bug has been fixed (thanks to Roland)!

Comment 5

[Alice Wyman]

(from comment #4)
> See bug 1341813 comment 16 -17.  Looks like this bug has been fixed (thanks to Roland)!

Spoke too soon.  See bug 1341813 comment 18 (KB articles in some locations are still broken).

Comment 6

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

(In reply to Alice Wyman from comment #5)
> (from comment #4)
> > See bug 1341813 comment 16 -17.  Looks like this bug has been fixed (thanks to Roland)!
> 
> Spoke too soon.  See bug 1341813 comment 18 (KB articles in some locations
> are still broken).

I am still working on it! didn't expect it to be finished and working for everything, thanks for re-testing.
I think that showfor.json has to be copied and pasted to too many places. I am trying to minimize it via inheritance e.g. I believe for example that the showfor.json for "Firefox -> Fix and Repair Problems" should inherit from the showfor.json for "Firefox". If inheritance doesn't work I will copy and paste it into all the places.