1341813 - New Firefox versions and new default version in showfor.json aren't showing up "Customize this article" version picker (freemarker problem?)

Status: RESOLVED INVALID

(support.mozilla.org - Lithium :: Knowledge Base Software, defect, P1)

Description

[Joni Chan]

Attachment: FirefoxScreenSnapz001.png

We added 52 to the showfor JSON but it's not showing up in the showfor UI.

(see attached screenshot).

Comment 1

[scott.riley]

@Tyson. Is the Tiny MCE editor button tied to the JSON update, separate, can be updated elsewhere, other?

Comment 2

[Alice Wyman]

Attachment: PlatformVersionTool-fx52fx53.png

The showfor UI for Firefox 52 and 53, both the "Customize this article" version picker and the Platform-Version editing tool, does work, but only for KB articles in certain locations, including:
https://support.mozilla.org/t5/Documents-Archive/tkb-p/documents-archive
https://support.mozilla.org/t5/Templates/ct-p/Templates
https://support.mozilla.org/t5/Contributor-Knowledge-Base/tkb-p/contributor-kb
https://support.mozilla.org/t5/Bookmarks-and-Tabs/tkb-p/Bookmarks-Tabs-fireFox
(The "Bookmarks and Tabs" location is under the "Archive -> Basic Browsing" folder.)

See my comments today in bug 1337596.  The KB article I used for the PlatformVersionTool-fx52fx53.png screenshot was reported in bug 1339484 comment 4 regarding the now fixed "Freemarker" error:
https://support.mozilla.org/t5/Bookmarks-and-Tabs/How-do-I-restore-my-tabs-from-last-time/ta-p/4158

Comment 3

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

Another bug that has to be looked at once redirects are done!

(un-needinfo'ing tyson because again not sure who on lithium is working with us on showfor post launch)

Comment 5

[Alice Wyman]

(In reply to Roland Tanglao :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland from comment #3)
> Another bug that has to be looked at once redirects are done!
> 
> (un-needinfo'ing tyson because again not sure who on lithium is working with
> us on showfor post launch)

This bug prevents including showfor content for Fx52 and fx53. This will affect articles being edited on kitsune that will eventually be migrated back to Lithium (bug 1360005). 

Should this bug be considered a blocker as far as moving back to Lithium?  It's not one of the three Showfor bugs listed in the May 4 platform meeting notes, https://docs.google.com/document/d/1iz1xp2Iie4dvdy5WKC6aL8Nyx1tbLZE_6WQop4htTw8/edit#

Comment 6

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

(In reply to Alice Wyman from comment #5)
> (In reply to Roland Tanglao :rolandtanglao, :mohnkuchen, :adobo, :sinigang,
> :roland from comment #3)
> > Another bug that has to be looked at once redirects are done!
> > 
> > (un-needinfo'ing tyson because again not sure who on lithium is working with
> > us on showfor post launch)
> 
> This bug prevents including showfor content for Fx52 and fx53. This will
> affect articles being edited on kitsune that will eventually be migrated
> back to Lithium (bug 1360005). 
> 
> Should this bug be considered a blocker as far as moving back to Lithium? 
> It's not one of the three Showfor bugs listed in the May 4 platform meeting
> notes,
> https://docs.google.com/document/d/
> 1iz1xp2Iie4dvdy5WKC6aL8Nyx1tbLZE_6WQop4htTw8/edit#

Hi Alice: you are right. This bug may be blocking (somehow I thought we had fixed this or we could manually fix the json). I am going to assign this bug to myself and investigate. Cheers! ...Roland

Comment 7

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

made fx53 the default (default was formerly fx50) and uploaded it as per March 2, 2017 procedure:
https://github.com/rtanglao/rt-showfor.json/blob/master/README.md#march-2-2017

but it's still showing fx50 as the default (I tested with this article: https://hwsfp35778.lithium.com/t5/Manage-preferences-and-add-ons/How-to-change-your-default-browser-in-Windows-10/ta-p/35222 )

Still investigating.

Comment 8

[Alice Wyman]

Roland, Did you see my comment #2 (the showfor UI for Firefox 52 and 53 does work, but only for articles in certain locations)?

Comment 9

[John Hesling [:John99] (NeedInfo me)]

NI Roland

Does the change of title totally change the scope of the problem that will be fixed ?
May it be better if 
> New default Firefox versions in showfor.json aren't showing up "Customize this article" version picker in the right sidebar (freemarker problem?)
became a new separate bug.

Because we still need to address and fix
> New Firefox versions in showfor.json aren't showing up "Customize this article" version picker in the right sidebar (freemarker problem?)

May I remind people we may write or revise articles in advance of a Release, so it is useful to be able to do that with the correct showfor picker behaviours. We also need to maintain and revise current articles and have those display correctly when seen by end users.

Comment 10

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

Hi John:

No I don't think it changes the scope John. We still have to manually add new versions to showfor.json and manually set the default version also in showfor.json. Both are broken on Lithium it seems and I am guessing  they are the same problem and I think both will be fixed here i.e. this bug but feel free to file a separate bug for adding new firefox versions.

I look at articles, edit and work on them with the fab Joni (and before that the fab Michael Verdi) and others every single week and in fact every single week since Thunderbird started using Kitsune in 2010 so I'm acquainted :-) with how this whole cycle of SUMO KB articles on Kitsune works. But I'm always willing to learn if I am missing something.

Cheers!

...Roland

Comment 11

[Alice Wyman]

(In reply to Roland Tanglao :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland from comment #10)
 
> No I don't think it changes the scope John. We still have to manually add
> new versions to showfor.json and manually set the default version also in
> showfor.json. Both are broken on Lithium it seems and I am guessing  they
> are the same problem and I think both will be fixed here i.e. this bug but
> feel free to file a separate bug for adding new firefox versions.

I updated the summary to cover both issues (new versions, new default).

Comment 12

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

(In reply to Alice Wyman from comment #8)
> Roland, Did you see my comment #2 (the showfor UI for Firefox 52 and 53 does
> work, but only for articles in certain locations)?

after a quick check i don't see it working for those articles [1] from comment 2, but i'll double check!

...Roland
[1]
https://support.mozilla.org/t5/Documents-Archive/tkb-p/documents-archive
https://support.mozilla.org/t5/Templates/ct-p/Templates
https://support.mozilla.org/t5/Contributor-Knowledge-Base/tkb-p/contributor-kb
https://support.mozilla.org/t5/Bookmarks-and-Tabs/tkb-p/Bookmarks-Tabs-fireFox

Comment 13

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

(In reply to Roland Tanglao :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland from comment #12)
> (In reply to Alice Wyman from comment #8)
> > Roland, Did you see my comment #2 (the showfor UI for Firefox 52 and 53 does
> > work, but only for articles in certain locations)?
> 
> after a quick check i don't see it working for those articles [1] from
> comment 2, but i'll double check!
> 
> ...Roland
> [1]
> https://support.mozilla.org/t5/Documents-Archive/tkb-p/documents-archive
> https://support.mozilla.org/t5/Templates/ct-p/Templates
> https://support.mozilla.org/t5/Contributor-Knowledge-Base/tkb-p/contributor-
> kb
> https://support.mozilla.org/t5/Bookmarks-and-Tabs/tkb-p/Bookmarks-Tabs-
> fireFox

hmmmm i was wrong in comment 12!

it *IS* working in https://hwsfp35778.lithium.com/t5/Documents-Archive/quot-This-Connection-is-Untrusted-quot-error-message-appears/ta-p/589

At least desktop default set to 53 is working! Will check the rest tomorrow !

Comment 14

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

no real progress but I added the showfor code to github: 
https://github.com/rtanglao/rt-showfor.json/blob/master/custom.show-for.xml

from:

https://support-stage.allizom.org/t5/bizapps/page/tab/community%3Astudio%3Acustom-content?component=custom.show-for

Also: I am clearing tyson's needinfo since I'm not sure he'll be look at this!

Comment 15

[Alice Wyman]

https://hwsfp35778.lithium.com/t5/Firefox/Template-PluginSupportEOL/ta-p/28718 is a good example of showfor fx52 that works in the https://hwsfp35778.lithium.com/t5/Templates/ct-p/Templates location.  It displays correct "for not fx52" and "for fx52" content, when you use the "Customize this article" picker and choose either fx51 (or below) or fx52-fx53. The content of that template is included in many Firefox articles in locations where fx52 showfor is NOT working, such as 
https://hwsfp35778.lithium.com/t5/Videos-sound-pictures-and/Troubleshoot-issues-with-plugins-like-Flash-or-Java-to-fix/ta-p/1157  

(Lithium doesn't have a "What links here" feature, which is bug 1328849.  Articles that use the PluginSupportEOL template on Kitsune are listed here: https://support.mozilla.org/kb/templatepluginsupporteol/links )

Comment 16

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

it looks the showfor.json was broken when we tried to add iOS. I used the unbroken version (i.e. without iOS) from Templates->Contributor Resources ->Firefox and fixed it to use 53 as the default and pasted it into Firefox -> Fix Problems and it worked! more details:
https://github.com/rtanglao/rt-showfor.json/blob/master/README.md

Comment 17

[Alice Wyman]

Hey, Roland! Looks like this bug is fixed! Good job! fx52 showfor is now working in 
https://hwsfp35778.lithium.com/t5/Videos-sound-pictures-and/Troubleshoot-issues-with-plugins-like-Flash-or-Java-to-fix/ta-p/1157 

Bug 1351621 also seems to be fixed!

Comment 18

[Alice Wyman]

(from comment #17)
> Hey, Roland! Looks like this bug is fixed! Good job! fx52 showfor is now
> working in 
> https://hwsfp35778.lithium.com/t5/Videos-sound-pictures-and/Troubleshoot-
> issues-with-plugins-like-Flash-or-Java-to-fix/ta-p/1157 
> 
> Bug 1351621 also seems to be fixed!

I spoke too soon.  KB articles in some locations are still broken, such as 
https://hwsfp35778.lithium.com/t5/Protect-your-privacy/tkb-p/Protect-Privacy
For example:
https://hwsfp35778.lithium.com/t5/Protect-your-privacy/Insecure-password-warning-in-Firefox/ta-p/27861

Comment 19

[Alice Wyman]

Copied from Roland's reply in bug 1351621 comment 6
(quote)
"I am still working on it! didn't expect it to be finished and working for everything, thanks for re-testing.
I think that showfor.json has to be copied and pasted to too many places. I am trying to minimize it via inheritance e.g. I believe for example that the showfor.json for "Firefox -> Fix and Repair Problems" should inherit from the showfor.json for "Firefox". If inheritance doesn't work I will copy and paste it into all the places."