If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Port bug 713680 to TB - TEST-UNEXPECTED-FAIL | mail/base/test/unit/test_windows_font_migration.js | verifier - [verifier : 58] "Consolas" == "Courier New"

REOPENED
Assigned to

Status

Thunderbird
General
REOPENED
6 months ago
6 months ago

People

(Reporter: Jorg K (GMT+2), Assigned: Jorg K (GMT+2))

Tracking

unspecified
Thunderbird 55.0
All
Windows

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 months ago
In bug 713680 M-C changed the default windows monospace font from "Courier New" to "Consolas".

This caused an Xpcshell test failure:
TEST-UNEXPECTED-FAIL | mail/base/test/unit/test_windows_font_migration.js | verifier - [verifier : 58] "Consolas" == "Courier New"
(Assignee)

Comment 1

6 months ago
Created attachment 8852594 [details] [diff] [review]
1351721-consolas.patch

Test passes with this patch.
Assignee: nobody → jorgk
Status: NEW → ASSIGNED
(Assignee)

Comment 2

6 months ago
https://hg.mozilla.org/comm-central/rev/8b55aa58ba5dfbec264c42dccc4db7b5e313c866
Status: ASSIGNED → RESOLVED
Last Resolved: 6 months ago
OS: Unspecified → Windows
Hardware: Unspecified → All
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 55.0
(Assignee)

Comment 3

6 months ago
Bug 713680 got backed out, so it's back to "Courier New" and the test fails again :-(

Backout:
https://hg.mozilla.org/comm-central/rev/bee0697a1d3709df1db982f8320e7cac4a0b62c5
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 4

6 months ago
Not causing failures right now.
Whiteboard: [Thunderbird-testfailure: X Windows]

Comment 5

6 months ago
What does this particular test test?
It pretends the migration is run on some Windows versions (XP and Vista) but those are no longer supported. Does it test anything useful? What about dropping the XP path and update the Vista path to check NT version 6.1 and test that migration on Win 7 works?
(Assignee)

Comment 6

6 months ago
(In reply to :aceman from comment #5)
> What does this particular test test? ... Does it test anything useful?
No idea. But I know that when bug 713680 lands again, I need to land the patch here ;-)
Unless you delete the test first.
You need to log in before you can comment on or make changes to this bug.