1351721 - Port bug 713680 to TB - TEST-UNEXPECTED-FAIL | mail/base/test/unit/test_windows_font_migration.js | verifier - [verifier : 58] "Consolas" == "Courier New"

Status: REOPENED

(Thunderbird :: Upstream Synchronization, enhancement)

Description

[Jorg K (CEST = GMT+2)]

In bug 713680 M-C changed the default windows monospace font from "Courier New" to "Consolas".

This caused an Xpcshell test failure:
TEST-UNEXPECTED-FAIL | mail/base/test/unit/test_windows_font_migration.js | verifier - [verifier : 58] "Consolas" == "Courier New"

Comment 1

[Jorg K (CEST = GMT+2)]

Attachment: 1351721-consolas.patch

Test passes with this patch.

Comment 2

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/8b55aa58ba5dfbec264c42dccc4db7b5e313c866

Comment 3

[Jorg K (CEST = GMT+2)]

Bug 713680 got backed out, so it's back to "Courier New" and the test fails again :-(

Backout:
https://hg.mozilla.org/comm-central/rev/bee0697a1d3709df1db982f8320e7cac4a0b62c5

Comment 4

[Jorg K (CEST = GMT+2)]

Not causing failures right now.

Comment 5

[:aceman]

What does this particular test test?
It pretends the migration is run on some Windows versions (XP and Vista) but those are no longer supported. Does it test anything useful? What about dropping the XP path and update the Vista path to check NT version 6.1 and test that migration on Win 7 works?

Comment 6

[Jorg K (CEST = GMT+2)]

(In reply to :aceman from comment #5)
> What does this particular test test? ... Does it test anything useful?
No idea. But I know that when bug 713680 lands again, I need to land the patch here ;-)
Unless you delete the test first.

Comment 7

[Takanori MATSUURA]

Upstream bug 713680 has been fixed as the duplicate of bug 1607913.
And bug 1607913 has been fixed.