1351978 - stylo: Fully support canvas

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P1)

Description

[Shing Lyu [:shinglyu]]

Attachment: Failing test cases

Many canvas reftests are failing, also blocking Talos test (Bug 1330589)

Comment 1

[Joel Maher ( :jmaher ) (UTC -8) (PTO'ish until July 5)]

should we turn off the talos test until this is fixed?  we have limited hardware resources, so running jobs that are not expected to pass is not ideal.

Comment 2

[Bobby Holley (:bholley)]

(In reply to Joel Maher ( :jmaher) from comment #1)
> should we turn off the talos test until this is fixed?  we have limited
> hardware resources, so running jobs that are not expected to pass is not
> ideal.

I thought these were running on central, but they don't appear to be?

Comment 3

[Hiroyuki Ikezoe (:hiro)]

I haven't checked all of tests in comment 0, but most of them might be affected by an assertion 'stylo: cannot resolve style for canvas from a ServoStyleSet yet' (bug 1324700).

Comment 4

[Hiroyuki Ikezoe (:hiro)]

There are two remaining failures:

* size-1.html (unknown reason, does not fail locally)
* size-change-1.html (bug 1356916)

Comment 5

[Hiroyuki Ikezoe (:hiro)]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #4)
> There are two remaining failures:
> 
> * size-1.html (unknown reason, does not fail locally)

OK, this one depends on scrollbar.

Comment 6

[Hiroyuki Ikezoe (:hiro)]

layout/reftests/forms/input/text/size-1.html has been fixed by bug 1361632.

Comment 7

[Hiroyuki Ikezoe (:hiro)]

All canvas reftest passed now. A rest of issue is font serialization (bug 1362914).

Comment 8

[Bobby Holley (:bholley)]

Great!