Closed Bug 1351978 Opened 5 years ago Closed 5 years ago

stylo: Fully support canvas

Categories

(Core :: CSS Parsing and Computation, defect, P1)

x86_64
Linux
defect

Tracking

()

RESOLVED FIXED

People

(Reporter: shinglyu, Assigned: hiro)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached file Failing test cases
Many canvas reftests are failing, also blocking Talos test (Bug 1330589)
should we turn off the talos test until this is fixed?  we have limited hardware resources, so running jobs that are not expected to pass is not ideal.
(In reply to Joel Maher ( :jmaher) from comment #1)
> should we turn off the talos test until this is fixed?  we have limited
> hardware resources, so running jobs that are not expected to pass is not
> ideal.

I thought these were running on central, but they don't appear to be?
Priority: -- → P1
I haven't checked all of tests in comment 0, but most of them might be affected by an assertion 'stylo: cannot resolve style for canvas from a ServoStyleSet yet' (bug 1324700).
Depends on: 1324700
Assignee: nobody → hikezoe
Depends on: 1354876
Depends on: 1356916
There are two remaining failures:

* size-1.html (unknown reason, does not fail locally)
* size-change-1.html (bug 1356916)
(In reply to Hiroyuki Ikezoe (:hiro) from comment #4)
> There are two remaining failures:
> 
> * size-1.html (unknown reason, does not fail locally)

OK, this one depends on scrollbar.
Depends on: 1321769
layout/reftests/forms/input/text/size-1.html has been fixed by bug 1361632.
Depends on: 1361632
No longer depends on: 1321769
Depends on: 1362914
All canvas reftest passed now. A rest of issue is font serialization (bug 1362914).
Great!
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.