Closed
Bug 1361632
Opened 7 years ago
Closed 7 years ago
stylo: full support of -moz-appearance
Categories
(Core :: CSS Parsing and Computation, enhancement)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: hiro, Assigned: hiro)
References
Details
Attachments
(1 file, 1 obsolete file)
59 bytes,
text/x-review-board-request
|
Details |
-moz-gtk-info-bar -moz-mac-active-source-list-selection -moz-mac-disclosure-button-closed -moz-mac-disclosure-button-open -moz-mac-fullscreen-button -moz-mac-help-button -moz-mac-source-list -moz-mac-source-list-selection -moz-mac-vibrancy-dark -moz-mac-vibrancy-light dialog scrollbar scrollbar-horizontal scrollbar-small scrollbar-vertical window These are listed in nsCSSProps::kMozAppearanceKTable but not in keyword list of -moz-appearance for stylo.
Assignee | ||
Comment 1•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a8ec263b267b0447574e7c426a3393a1dab73d15 Surprise! Lots of tests passed!
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → hikezoe
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 4•7 years ago
|
||
Ting-Yu, would you mind reviewing these patches? Now the keyword list for -moz-appearance should have the same values of nsCSSProps::kMozAppearanceKTable (If I am not missing some). FYI: another try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a17a0ab74104a42f3138d356c81b5ab645344983&selectedJob=96194849 There seems to be some intermittent failures, I guess it's caused by lacks of some properties supports on stylo. Thank you!
Assignee | ||
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8864057 [details] Bug 1361632 - Support all properties for -moz-appearance. https://reviewboard.mozilla.org/r/135772/#review138800 ::: servo/components/style/properties/longhand/box.mako.rs:2404 (Diff revision 1) > ${helpers.single_keyword("-moz-appearance", > """none button button-arrow-down button-arrow-next button-arrow-previous button-arrow-up > button-bevel button-focus caret checkbox checkbox-container checkbox-label checkmenuitem > + dialog > dualbutton groupbox listbox listitem menuarrow menubar menucheckbox menuimage menuitem This list is not formatted yet, I will format it before I will send a PR.
Assignee | ||
Comment 6•7 years ago
|
||
Changing dependency.
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8864057 [details] Bug 1361632 - Support all properties for -moz-appearance. https://reviewboard.mozilla.org/r/135772/#review138924 Wow, this is awesome! Great job hiro.
Attachment #8864057 -
Flags: review+
Comment 8•7 years ago
|
||
mozreview-review |
Comment on attachment 8864058 [details] Bug 1361632 - Adjust reftest expectation for -moz-appearance. https://reviewboard.mozilla.org/r/135774/#review138926 So many passes!
Attachment #8864058 -
Flags: review+
Assignee | ||
Comment 9•7 years ago
|
||
Thank for the review! https://github.com/servo/servo/pull/16715
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8864057 -
Attachment is obsolete: true
Attachment #8864057 -
Flags: review?(tlin)
Comment hidden (mozreview-request) |
Comment 12•7 years ago
|
||
Pushed by hikezoe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6ee8241b984e Adjust reftest expectation for -moz-appearance. r=bholley
Comment 13•7 years ago
|
||
Pushed by ihsiao@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/d19472763d1d Adjust reftest expectation for -moz-appearance. r=bholley. a=merge
Comment 14•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d19472763d1d
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Comment 15•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6ee8241b984e
You need to log in
before you can comment on or make changes to this bug.
Description
•