1361632 - stylo: full support of -moz-appearance

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Hiroyuki Ikezoe (:hiro)]

-moz-gtk-info-bar
-moz-mac-active-source-list-selection
-moz-mac-disclosure-button-closed
-moz-mac-disclosure-button-open
-moz-mac-fullscreen-button
-moz-mac-help-button
-moz-mac-source-list
-moz-mac-source-list-selection
-moz-mac-vibrancy-dark
-moz-mac-vibrancy-light
dialog
scrollbar
scrollbar-horizontal
scrollbar-small
scrollbar-vertical
window

These are listed in nsCSSProps::kMozAppearanceKTable but not in keyword list of -moz-appearance for stylo.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a8ec263b267b0447574e7c426a3393a1dab73d15

Surprise! Lots of tests passed!

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1361632 - Support all properties for -moz-appearance.

Now all properties in nsCSSProps::kMozAppearanceKTable are in
keyword list of -moz-appearance.

Review commit: https://reviewboard.mozilla.org/r/135772/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/135772/

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1361632 - Adjust reftest expectation for -moz-appearance.

Review commit: https://reviewboard.mozilla.org/r/135774/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/135774/

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Ting-Yu, would you mind reviewing these patches?
Now the keyword list for -moz-appearance should have the same values of nsCSSProps::kMozAppearanceKTable (If I am not missing some).

FYI: another try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a17a0ab74104a42f3138d356c81b5ab645344983&selectedJob=96194849

There seems to be some intermittent failures, I guess it's caused by lacks of some properties supports on stylo.

Thank you!

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8864057 [details]
Bug 1361632 - Support all properties for -moz-appearance.

https://reviewboard.mozilla.org/r/135772/#review138800

::: servo/components/style/properties/longhand/box.mako.rs:2404
(Diff revision 1)
>  ${helpers.single_keyword("-moz-appearance",
>                           """none button button-arrow-down button-arrow-next button-arrow-previous button-arrow-up
>                              button-bevel button-focus caret checkbox checkbox-container checkbox-label checkmenuitem
> +                            dialog
>                              dualbutton groupbox listbox listitem menuarrow menubar menucheckbox menuimage menuitem

This list is not formatted yet, I will format it before I will send a PR.

Comment 6

[Hiroyuki Ikezoe (:hiro)]

Changing dependency.

Comment 7

[Bobby Holley (:bholley)]

Comment on attachment 8864057 [details]
Bug 1361632 - Support all properties for -moz-appearance.

https://reviewboard.mozilla.org/r/135772/#review138924

Wow, this is awesome! Great job hiro.

Comment 8

[Bobby Holley (:bholley)]

Comment on attachment 8864058 [details]
Bug 1361632 - Adjust reftest expectation for -moz-appearance.

https://reviewboard.mozilla.org/r/135774/#review138926

So many passes!

Comment 9

[Hiroyuki Ikezoe (:hiro)]

Thank for the review!

https://github.com/servo/servo/pull/16715

Comment 10

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8864058 [details]
Bug 1361632 - Adjust reftest expectation for -moz-appearance.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/135774/diff/1-2/

Comment 11

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8864058 [details]
Bug 1361632 - Adjust reftest expectation for -moz-appearance.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/135774/diff/2-3/

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ee8241b984e
Adjust reftest expectation for -moz-appearance. r=bholley

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/d19472763d1d
Adjust reftest expectation for -moz-appearance. r=bholley. a=merge

Comment 14

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/d19472763d1d

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6ee8241b984e