1352115 - CSS_SELECTOR(s) and TOOLBAR_EYEDROPPER are missing in Histograms.json

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P3)

Description

[firefish6000]

devtools/client/shared/telemetry.js references the histograms
DEVTOOLS_COPY_FULL_CSS_SELECTOR_OPENED_COUNT,
DEVTOOLS_COPY_UNIQUE_CSS_SELECTOR_OPENED_COUNT,
DEVTOOLS_TOOLBAR_EYEDROPPER_OPENED_COUNT

however, they are not yet in Histograms.json.
lack of DEVTOOLS_COPY_FULL_CSS_SELECTOR_OPENED_COUNT is also mentioned in https://bugzilla.mozilla.org/show_bug.cgi?id=1346310

Comment 1

[Patrick Brosset <:pbro>]

Some explanation about the change I'm about to make:

- DEVTOOLS_TOOLBAR_EYEDROPPER_OPENED_COUNT:
this was part of a group of eyedropper probes that got added/changed a while ago in bug 1262437. There are 4 related probes, and I had just forgotten to add this one. So, I'm going to add it and use the same properties as the other eyedropper probes.

- DEVTOOLS_COPY_FULL_CSS_SELECTOR_OPENED_COUNT, DEVTOOLS_COPY_UNIQUE_CSS_SELECTOR_OPENED_COUNT:
These are 2 new probes that got added in bug 1323700 but not declared in Histograms.json until now.
They will be useful for us to know whether people actually use these features, and if one is more useful than the other so that, perhaps, we can remove one at some stage.
I'll just make these 2 expire in 57, no need to keep gathering the data all the time.

Comment 2

[Patrick Brosset <:pbro>]

Attachment: Bug 1352115 - Adding missing probes to Histograms.json;

Review commit: https://reviewboard.mozilla.org/r/128464/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/128464/

Comment 4

[Patrick Brosset <:pbro>]

Bryan: does comment 1 sound good to you? At least for the css selector features.
For the eyedropper, I was looking at some of the data and filed bug 1355080 as a result. Might be interested for you to look at.

Comment 5

[Bryan Clark (DevTools PM) [:clarkbw]]

pbro: sounds good to me!

Comment 6

[Benjamin Smedberg]

Comment on attachment 8856512 [details]
Bug 1352115 - Adding missing probes to Histograms.json;

https://reviewboard.mozilla.org/r/128464/#review131614

data-r=me

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/65cf36aa783f
Adding missing probes to Histograms.json; r=bsmedberg

Comment 8

[Carsten Book [:Tomcat]]

backed out for bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=90949702&repo=autoland

Comment 9

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d80c517658f5
Backed out changeset 65cf36aa783f for bustage

Comment 10

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

I needed to implement this as part of bug 1356223 so I will grab this.

Comment 11

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Bug 1352115 - Add scalars for toolbareyedropper, copyuniquecssselector and copyfullcssselector

Review commit: https://reviewboard.mozilla.org/r/131558/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/131558/

Comment 12

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8859565 [details]
Bug 1352115 - Add scalars for toolbareyedropper, copyuniquecssselector and copyfullcssselector

@bsmedberg: It would be awesome if you could let us know if you are happy with the probes I have added to toolkit/components/telemetry/Scalars.yaml.

Comment 13

[Benjamin Smedberg]

Comment on attachment 8859565 [details]
Bug 1352115 - Add scalars for toolbareyedropper, copyuniquecssselector and copyfullcssselector

https://reviewboard.mozilla.org/r/131558/#review134314

data-r=me (I did not review the code)

Comment 14

[Patrick Brosset <:pbro>]

Comment on attachment 8859565 [details]
Bug 1352115 - Add scalars for toolbareyedropper, copyuniquecssselector and copyfullcssselector

https://reviewboard.mozilla.org/r/131558/#review134778

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ab7f74c36a2
Add scalars for toolbareyedropper, copyuniquecssselector and copyfullcssselector r=bsmedberg,pbro

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7ab7f74c36a2