1352379 - Add a test for URLSearchParams and record<> CTOR

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Comment 1

[Andrea Marchesini [:baku]]

Attachment: part 1 - indentation

Comment 2

[Andrea Marchesini [:baku]]

Attachment: part 2 - the real test

Comment 3

[Boris Zbarsky [:bzbarsky]]

That test doesn't check what sort of string conversion happens on the keys.  In particular, it should check whether they're treated as ByteString, DOMString, or USVString.  That means you need key names containing non-ASCII-range things, and some unpaired surrogates or something.

And this should be a web platform test, not a mochitest.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/48c4cf6ed127
Remove an extra 2 spaces in urlSearchParams_commons.js, r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/d80e127d7323
Add a test for URLSearchParams and record<> CTOR, r=qdot

Comment 5

[Boris Zbarsky [:bzbarsky]]

This test doesn't test the things I asked for it to test.  See comment 3.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/48c4cf6ed127
https://hg.mozilla.org/mozilla-central/rev/d80e127d7323

Comment 7

[Boris Zbarsky [:bzbarsky]]

I filed bug 1353197 on what this bug was _supposed_ to be about.