Closed
Bug 1353197
Opened 7 years ago
Closed 7 years ago
Add a test for URLSearchParams handling of non-ASCII keys in the record<> ctor
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: baku)
References
Details
Attachments
(1 file)
|
1.45 KB,
patch
|
Details | Diff | Splinter Review |
This is what bug 1352379 was _supposed_ to be about...
|
Reporter | |
Comment 1•7 years ago
|
||
See bug 1352379 comment 3.
|
Assignee | |
Comment 2•7 years ago
|
||
Attachment #8854371 -
Flags: review?(annevk)
|
||
Comment 3•7 years ago
|
||
You should also test that something like \uFFFF or \u1234 stays the same per bz's feedback (non-ASCII bit). Also, the title could be improved maybe something like "object with NULL, non-ASCII, and surrogate keys". r+ with that.
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/72f31ba9e92b Add a test for URLSearchParams handling of non-ASCII keys in the record<> ctor, r=annevk
|
|
||
Comment 5•7 years ago
|
||
Comment on attachment 8854371 [details] [diff] [review] usp.patch Review of attachment 8854371 [details] [diff] [review]: ----------------------------------------------------------------- Clearing review request per above comments. Landed patch looks good.
Attachment #8854371 -
Flags: review?(annevk)
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/72f31ba9e92b
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•