1352618 - Enable tracking annotations and network de-prioritization

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect, P2)

Description

[François Marier [:francois]]

In bug 1344981, we disabled privacy.trackingprotection.annotate_channels in aurora.

Once bug 1339050 fixes the suspected source of the perf regression we found in bug 1334616, we'll be able to rely on this to enable privacy.trackingprotection.lower_network_priority.

Comment 1

[François Marier [:francois]]

I'm going to land annotations and network deprioritization separately.

Comment 2

[François Marier [:francois]]

My mistake. Annotations are already enabled on central: https://searchfox.org/mozilla-central/rev/624d25b2980cf5f83452b040e6d664460f9b7ec5/modules/libpref/init/all.js#1270

That was done in bug 1334241 and only reverted in aurora in bug 1344981.

Comment 3

[François Marier [:francois]]

Attachment: Bug 1352618 - Enable network de-prioritization based on tracking annotations.

Review commit: https://reviewboard.mozilla.org/r/129108/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/129108/

Comment 4

[Chris Peterson [:cpeterson]]

Comment on attachment 8857164 [details]
Bug 1352618 - Enable network de-prioritization based on tracking annotations.

https://reviewboard.mozilla.org/r/129108/#review131624

LGTM, assuming bug 1339050 fixed the perf regression reported in IsTrackerWhitelisted bug 1334616.

Comment 5

[François Marier [:francois]]

Should I land this now or do you want to have a chat with others folks first?

Comment 6

[Chris Peterson [:cpeterson]]

(In reply to François Marier [:francois] from comment #5)
> Should I land this now or do you want to have a chat with others folks first?

Sorry, I r+'d that too soon. I need to get sign-off first. I will switch back to r? until I get sign-off.

Comment 7

[François Marier [:francois]]

Comment on attachment 8857164 [details]
Bug 1352618 - Enable network de-prioritization based on tracking annotations.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/129108/diff/1-2/

Comment 8

[François Marier [:francois]]

Comment on attachment 8857164 [details]
Bug 1352618 - Enable network de-prioritization based on tracking annotations.

The latest revision only enables this in Nightly (not riding the trains).

Comment 9

[Chris Peterson [:cpeterson]]

Comment on attachment 8857164 [details]
Bug 1352618 - Enable network de-prioritization based on tracking annotations.

LGTM. We are ready to land on Nightly for testing, but need more telemetry measurements before we ride the trains.

MozReview is a little confused. This patch already has r=cpeterson in Review Board, so I can't r+ it again there. So I am setting r+ in Bugzilla.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4636f4ae8c9d
Enable network de-prioritization based on tracking annotations. r=cpeterson

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4636f4ae8c9d