Closed Bug 1352618 Opened 3 years ago Closed 3 years ago

Enable tracking annotations and network de-prioritization

Categories

(Toolkit :: Safe Browsing, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: francois, Assigned: francois)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

In bug 1344981, we disabled privacy.trackingprotection.annotate_channels in aurora.

Once bug 1339050 fixes the suspected source of the perf regression we found in bug 1334616, we'll be able to rely on this to enable privacy.trackingprotection.lower_network_priority.
Blocks: CDP
Assignee: hchang → francois
See Also: → 1141814
I'm going to land annotations and network deprioritization separately.
Keywords: leave-open
My mistake. Annotations are already enabled on central: https://searchfox.org/mozilla-central/rev/624d25b2980cf5f83452b040e6d664460f9b7ec5/modules/libpref/init/all.js#1270

That was done in bug 1334241 and only reverted in aurora in bug 1344981.
Keywords: leave-open
Comment on attachment 8857164 [details]
Bug 1352618 - Enable network de-prioritization based on tracking annotations.

https://reviewboard.mozilla.org/r/129108/#review131624

LGTM, assuming bug 1339050 fixed the perf regression reported in IsTrackerWhitelisted bug 1334616.
Attachment #8857164 - Flags: review?(cpeterson) → review+
Should I land this now or do you want to have a chat with others folks first?
Flags: needinfo?(cpeterson)
(In reply to François Marier [:francois] from comment #5)
> Should I land this now or do you want to have a chat with others folks first?

Sorry, I r+'d that too soon. I need to get sign-off first. I will switch back to r? until I get sign-off.
Flags: needinfo?(cpeterson)
Comment on attachment 8857164 [details]
Bug 1352618 - Enable network de-prioritization based on tracking annotations.

The latest revision only enables this in Nightly (not riding the trains).
Attachment #8857164 - Flags: review+ → review?(cpeterson)
Comment on attachment 8857164 [details]
Bug 1352618 - Enable network de-prioritization based on tracking annotations.

LGTM. We are ready to land on Nightly for testing, but need more telemetry measurements before we ride the trains.

MozReview is a little confused. This patch already has r=cpeterson in Review Board, so I can't r+ it again there. So I am setting r+ in Bugzilla.
Attachment #8857164 - Flags: review?(cpeterson) → review+
Pushed by fmarier@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4636f4ae8c9d
Enable network de-prioritization based on tracking annotations. r=cpeterson
https://hg.mozilla.org/mozilla-central/rev/4636f4ae8c9d
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.