1352765 - Urlbar loses focus when switching to a tab with permission panel

Status: NEW

(Firefox :: Site Identity, defect, P5)

Description

[684sigma]

User Agent 	Mozilla/5.0 (Windows NT 6.1; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0

I have a problem with Firefox Beta 53. It also happens in Nightly 55. Doesn't happen in Beta 52, ESR 45.
Sometimes when switching to tab with site identity block, location bar (unpredictably) looses focus.
Here's a ways to reproduce the bug:

1. Open https://bugzilla.mozilla.org in a new tab.
2. Open https://permission.site/ in the last tab, click button "Location" on the page
3. Type anything in location bar
4. Switch to the tab with https://bugzilla.mozilla.org , then switch back to the tab with https://permission.site/ 

Result: Location bar looses focus.
Expected: Location bar should preserve focus.

Probably related bug: Bug 1349453.

Comment 1

[Hani Yacoub, Desktop QA]

I did a regression range on Windows 10 x64 and here is the regression window: 

Last good revision: 771f1590f03efec066b2118cad52f11fd17d43ce
First bad revision: 785314dbec5772bc3b0f0bc18f6ab63fec750193
Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=771f1590f03efec066b2118cad52f11fd17d43ce&tochange=785314dbec5772bc3b0f0bc18f6ab63fec750193

Looks like the following bug has the  changes which introduced the regression:
https://bugzilla.mozilla.org/show_bug.cgi?id=1328304

Comment 2

[Liz Henry (:lizzard) (relman/hg->git project)]

Sounds like another fairly minor regression from bug 1328304. Since that is a privacy issue I don't want to back it out this late in beta. Johann, what do you think? Can we live with this for 53 and do you want to have a stab at fixing it for 54/55?

Comment 3

[Johann Hofmann [:johannh]]

Yeah, sorry, our triage process is a bit delayed due to some re-organization (and Photon) right now. I'll make the call that this is minor enough to ignore for 53.

Pdol, do you think this is something we should track for 54?

Comment 4

[Peter Dolanjski [:pdol]]

(In reply to Johann Hofmann [:johannh] from comment #3)
> Pdol, do you think this is something we should track for 54?

Yes, that seems like the right call.  Adding elan to track.

Comment 5

[Marcia Knous [:marcia]]

Tracking 54+ based on Comment 4.

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Johann, Peter, can you find someone to actually work on this issue? All that "tracking" it is going to do, is bring it up for release management to triage again in order to make sure someone's assigned.  

Since we're already past early beta 54 let's defer this to 55.

Comment 7

[Johann Hofmann [:johannh]]

I'm making the call that this is too minor for anyone from the team to look into right now. We'll happily take patches.