1352771 - stylo: Wrong justify-content value name in parse_content_distribution in align.rs

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P1)

Description

[Hiroyuki Ikezoe (:hiro)]

https://hg.mozilla.org/mozilla-central/file/7a3f514cf849/servo/components/style/values/specified/align.rs#l357

It should be concatinated with '-' instead of '_'.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bed940db5471f5da590c40f4574010a494c727bb

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1352771 - Update mochitest expectations.

Review commit: https://reviewboard.mozilla.org/r/125788/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125788/

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1352771 - modify flexbox reftest expectations.

Review commit: https://reviewboard.mozilla.org/r/125790/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125790/

Comment 3

[Bobby Holley (:bholley)]

That's a lot of passing tests! \o/

Comment 4

[Bobby Holley (:bholley)]

Comment on attachment 8853709 [details]
Bug 1352771 - Update mochitest expectations.

https://reviewboard.mozilla.org/r/125788/#review128298

Comment 5

[Bobby Holley (:bholley)]

Comment on attachment 8853710 [details]
Bug 1352771 - modify flexbox reftest expectations.

https://reviewboard.mozilla.org/r/125790/#review128300

Comment 6

[Hiroyuki Ikezoe (:hiro)]

Thanks for really quick reviewing!

I am not sure we can land patches which has r+ by other person different from 'r?' flag in commit message, but I will try it.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f3311ae2d4e
Fix justify-content values. r=bholley
https://hg.mozilla.org/integration/autoland/rev/ac9530e359b3
modify flexbox reftest expectations. r=bholley

Comment 8

[Hiroyuki Ikezoe (:hiro)]

We can. :-)

Comment 9

[Manish Goregaokar [:manishearth]]

Yeah, mozreview will just overwrite whatever you write in the reviewer section.

Comment 10

[Hiroyuki Ikezoe (:hiro)]

I did forget that the change includes servo side change.  Need to back it out.

Comment 11

[Manish Goregaokar [:manishearth]]

Closed Servo tree until you can do the backouts; if vcsssync attempts to sync over those servo changes things will break.

Comment 12

[Hiroyuki Ikezoe (:hiro)]

Thank you Manish.  I tried to back it out, but couldn't.

: ************************************************************************
: you do not have permissions to modify files under servo/
:
: the servo/ directory is kept in sync with the canonical upstream
: repository at https://github.com/servo/servo
:
: changes to servo/ are only allowed by the syncing tool and by sheriffs
: performing cross-repository "merges"
:
: to make changes to servo/, submit a Pull Request against the servo/servo
: GitHub project
: ***********************************************************************

Comment 13

[Hiroyuki Ikezoe (:hiro)]

I am going to hole these patch until Monday for the safety.
Thank you Manish for quick helping!

Comment 14

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8853710 [details]
Bug 1352771 - modify flexbox reftest expectations.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/125790/diff/1-2/

Comment 15

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8853709 [details]
Bug 1352771 - Update mochitest expectations.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/125788/diff/1-2/

Comment 16

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8853709 [details]
Bug 1352771 - Update mochitest expectations.

https://reviewboard.mozilla.org/r/125788/#review128326

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/433ddda62563
modify flexbox reftest expectations. r=bholley
https://hg.mozilla.org/integration/autoland/rev/83bc93264621
Update mochitest expectations. r=bholley

Comment 18

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/433ddda62563
https://hg.mozilla.org/mozilla-central/rev/83bc93264621