stylo: flexbox layout is wrong under stylo

RESOLVED FIXED

Status

()

Core
CSS Parsing and Computation
P1
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: shinglyu, Assigned: hiro)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

a year ago
Created attachment 8852799 [details]
Failing test cases

Various flexbox reftest has wrong layout, need further investigation.
This is a lot of tests, so bumping the priority. I'll try to find an owner soon.
Priority: -- → P1
(Assignee)

Updated

a year ago
Depends on: 1352771
(Assignee)

Updated

a year ago
Depends on: 1352781
Looks like Hiro is already working on this - thanks Hiro!

After the two dependencies are fixed, how many remaining from comment 0 are failing? If it's only a handful, we can probably close this bug and come back to them later.
Assignee: nobody → hikezoe
Flags: needinfo?(hikezoe)
(Assignee)

Comment 3

a year ago
Created attachment 8854319 [details]
Updated failing test cases

The remaining are 27 tests (I might miss some though).

I guess a reason of most of failures in layout/reftests/flexbox/  is that we don't handle '-moz-max-content' or 'moz-min-content' properly.

I am not sure about reasons of failure tests in layout/reftests/w3c-css/submitted/align3/, need to investigate respectively.
Attachment #8852799 - Attachment is obsolete: true
Flags: needinfo?(hikezoe)
(Assignee)

Comment 4

a year ago
(In reply to Hiroyuki Ikezoe (:hiro) from comment #3)
> I am not sure about reasons of failure tests in
> layout/reftests/w3c-css/submitted/align3/, need to investigate respectively.

Rest of failures in this directory use 'display: grid'.  It needs bug 1341802.
So now I think flex-box issues has been solved.
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.