Closed Bug 1352850 Opened 3 years ago Closed 3 years ago

Switch to Google for Geolocation services in all builds

Categories

(SeaMonkey :: Preferences, enhancement)

enhancement
Not set

Tracking

(seamonkey2.48 wontfix, seamonkey2.49esr fixed, seamonkey2.50 wontfix, seamonkey2.51 fixed, seamonkey2.52 fixed)

RESOLVED FIXED
seamonkey2.52
Tracking Status
seamonkey2.48 --- wontfix
seamonkey2.49esr --- fixed
seamonkey2.50 --- wontfix
seamonkey2.51 --- fixed
seamonkey2.52 --- fixed

People

(Reporter: rsx11m.pub, Assigned: rsx11m.pub)

References

Details

Attachments

(1 file)

We are currently using the Mozilla service for Geolocation, but only in beta/aurora/trunk builds. Google is used for releases only. This bug should consistently use the Google service for all builds.
Hmm, apparently we are using https://location.services.mozilla.com/v1/geolocate?key=%MOZILLA_API_KEY% for geo.wifi.uri in /all/ builds; the distinction was made in its firefox.js counterpart, bug 1216662.
Summary: Use Google for Geolocation services also in beta and nightly builds → Switch to Google for Geolocation services in all builds
Ok, makes sense now, I'll check what those other prefs are doing (likely "false" by default then).
As discussed in the morning, this switches geo.wifi.uri from the Mozilla to the Google server, assuming the respective API key being present.

As for the other three variables, those are platform-provided geolocation services. Firefox has switched them off by default for release builds as some of them are apparently not yet stable. These services are:

 - On MacOSX, CoreLocation (which is actually part of the iOS SDK)
 - On Windows 8+, its own MS-specific geolocation service
 - On Linux, the GPS daemon (which may or may not be running)

For consistency (and simplification), I'll leave them false for all build types - interested users can always turn they on if they desire to test those.
Attachment #8853829 - Flags: review?(iann_bugzilla)
Attachment #8853829 - Flags: feedback?(frgrahl)
Comment on attachment 8853829 [details] [diff] [review]
Proposed pref changes and additions

Looks good to me. Stealing review. 

Should imho go into 2.49 so you should ask for approval.
Attachment #8853829 - Flags: review?(iann_bugzilla)
Attachment #8853829 - Flags: review+
Attachment #8853829 - Flags: feedback?(frgrahl)
Attachment #8853829 - Flags: feedback+
Thanks, pushed as https://hg.mozilla.org/comm-central/rev/2e7618a2932d
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.52
Attachment #8853829 - Flags: approval-comm-release?
Attachment #8853829 - Flags: approval-comm-beta?
Attachment #8853829 - Flags: approval-comm-aurora?
Comment on attachment 8853829 [details] [diff] [review]
Proposed pref changes and additions

No point keeping the comm-aurora request around...
Attachment #8853829 - Flags: approval-comm-aurora?
Comment on attachment 8853829 [details] [diff] [review]
Proposed pref changes and additions

Ewong, unless you want this for 2.48 already, the comm-release request is actually for 2.49.x and thus comm-esr52 (we don't have separate flags yet for SeaMonkey).
Flags: needinfo?(ewong)
(In reply to rsx11m from comment #7)
> Comment on attachment 8853829 [details] [diff] [review]
> Proposed pref changes and additions
> 
> Ewong, unless you want this for 2.48 already, the comm-release request is
> actually for 2.49.x and thus comm-esr52 (we don't have separate flags yet
> for SeaMonkey).

We'll just do this for 2.48. I'm hesitant in introducing a change to something
that wasn't in beta.

Edmund
Flags: needinfo?(ewong)
Comment on attachment 8853829 [details] [diff] [review]
Proposed pref changes and additions

Switching approval-comm-release? to approval-comm-esr52? now that we have it.
Attachment #8853829 - Flags: approval-comm-release? → approval-comm-esr52?
Comment on attachment 8853829 [details] [diff] [review]
Proposed pref changes and additions

a=me for c-b and c-esr52
Attachment #8853829 - Flags: approval-comm-esr52+
Attachment #8853829 - Flags: approval-comm-beta?
Attachment #8853829 - Flags: approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.