Closed Bug 1352910 Opened 8 years ago Closed 8 years ago

"Forecastfox (fix version)" no longer works on Trunk

Categories

(WebExtensions :: General, defect)

defect
Not set
normal

Tracking

(firefox55 fix-optional)

RESOLVED WORKSFORME
Tracking Status
firefox55 --- fix-optional

People

(Reporter: wgianopoulos, Assigned: pag77)

References

Details

(Keywords: regression)

The popular add-on "Forecastfox (fix version)" no longer works with the fix for bug 1145470.
Component: Security → Add-ons
Product: Core → Tech Evangelism
This sounds like a great plan!
That last comment was supposed to be in Bug 1352513 which is proposing adding a preference to toggle the behavior in bug 1145470, which would provide a temporary workaround until Firefox 57 because that version is scheduled to drop support for XPCOM-based add-ons completely. SO there would be a security setting that the user could choose to flip to keep this add-on working.
Depends on: 1352513
Summary: "Forecast (fix version)" no longer works on Trunk → "Forecastfox (fix version)" no longer works on Trunk
The mozillazine thread for this add-on mentions a preliminary e10s-compatible version http://forums.mozillazine.org/viewtopic.php?f=48&t=2913287&sid=74f1532a841d3d173871929169968cfd&start=375, which apparently still works on Nightly? Don't know if that's a webextension or something else.
(In reply to :Gijs from comment #3) > The mozillazine thread for this add-on mentions a preliminary > e10s-compatible version > http://forums.mozillazine.org/viewtopic. > php?f=48&t=2913287&sid=74f1532a841d3d173871929169968cfd&start=375, which > apparently still works on Nightly? Don't know if that's a webextension or > something else. That version did not seem to work any better for me.
(In reply to :Gijs from comment #3) > The mozillazine thread for this add-on mentions a preliminary > e10s-compatible version > http://forums.mozillazine.org/viewtopic. > php?f=48&t=2913287&sid=74f1532a841d3d173871929169968cfd&start=375, which > apparently still works on Nightly? Don't know if that's a webextension or > something else. As near as I can tell this is just a restartless add-on that uses the same security loopholes to work. I suspect those who posted it fixes the issue did not really test that assertion.
(In reply to Bill Gianopoulos [:WG9s] from comment #5) > (In reply to :Gijs from comment #3) > > The mozillazine thread for this add-on mentions a preliminary > > e10s-compatible version > > http://forums.mozillazine.org/viewtopic. > > php?f=48&t=2913287&sid=74f1532a841d3d173871929169968cfd&start=375, which > > apparently still works on Nightly? Don't know if that's a webextension or > > something else. > > As near as I can tell this is just a restartless add-on that uses the same > security loopholes to work. I suspect those who posted it fixes the issue > did not really test that assertion. Hmm but actually i can't get this to work even with bug 1145470 backed out. I wonder if the real issue is that the restartless less add-on does not work at all under Linux.
Forecastfox (fix version) Current version 2.4.8 - xul This is the version for WebExtensions: Next Listed Version: 3.4 Queue Position: 128 of 267 But All WebExtensions there is an incompatibility with the current version of NoScript 5.0.2: XMLHttpRequest now does not work from local requests I reported this to the author and he made changes: https://noscript.net/getit#devel ============================================================= v 5.0.3rc2 x Fixed XHR regression (thanks Oleksandr Popov for reporting) ============================================================= v 5.0.3rc1 x Fixed compatibility issues with some WebExtensions (thanks Oleksandr Popov for reporting) ============================================================= It sounds strange, but I'm very glad that the Forecastfox 3.4 preview is delayed And I really hope that NoScript will make the release 5.0.3 BEFORE Mozilla-moderators approval of Forecastfox 3.4!
(In reply to Oleksandr from comment #7) > Forecastfox (fix version) > > Current version 2.4.8 - xul > > This is the version for WebExtensions: > Next Listed Version: 3.4 > Queue Position: 128 of 267 > > But All WebExtensions there is an incompatibility with the current version > of NoScript 5.0.2: XMLHttpRequest now does not work from local requests > > I reported this to the author and he made changes: > https://noscript.net/getit#devel > ============================================================= > v 5.0.3rc2 > x Fixed XHR regression (thanks Oleksandr Popov for reporting) > > ============================================================= > v 5.0.3rc1 > x Fixed compatibility issues with some WebExtensions (thanks Oleksandr Popov > for reporting) > ============================================================= > > > It sounds strange, but I'm very glad that the Forecastfox 3.4 preview is > delayed > And I really hope that NoScript will make the release 5.0.3 BEFORE > Mozilla-moderators approval of Forecastfox 3.4! Sorry I don't run noscript this just does not seem to work under Linux at all.
I tested in Window, Ubuntu, MacOs Unfortunately I do not see any problems Your Linux name? Your browser name? Your browser version? you can open this uri: http://forecastfox3.accuweather.com/adcbin/forecastfox3/current-conditions.asp?location=cityId%3A349727&metric=0&langId=1&tdq=1485801967147 ? Can you add more details with screenshots about your problem? also you can try version 3.4 (for Firefox 51+)? https://www.dropbox.com/s/9ame7cu7e6fv2gl/forecastfox_fix_version-3.4.xpi a). uninstall current version b) restart firefox c) type in address-bar: about:debugging#addons click to load temporary extension select forecastfox_fix_version-3.4.xpi
(In reply to Oleksandr from comment #9) > I tested in Window, Ubuntu, MacOs > Unfortunately I do not see any problems > Your Linux name? Your browser name? Your browser version? This is reported against Firefox nightly, so https://nightly.mozilla.org/ - version 55. That'll be the difference.
Firefox Nightly 55.0a1 (2017-04-03) Forecastfox 3.4 I tested in Window, Ubuntu, MacOs Unfortunately I do not see any problems Please see screenshots: Windows: https://snag.gy/4kNmQV.jpg Ubuntu: https://snag.gy/XprWmx.jpg MacOs: https://snag.gy/37tQUl.jpg I do not understand what exactly does not work for you. Can you add more details (with screenshots) about your problem "step-by-step"?
(In reply to Oleksandr from comment #11) > Firefox Nightly 55.0a1 (2017-04-03) > Forecastfox 3.4 > I tested in Window, Ubuntu, MacOs > Unfortunately I do not see any problems > Please see screenshots: > > Windows: https://snag.gy/4kNmQV.jpg > Ubuntu: https://snag.gy/XprWmx.jpg > MacOs: https://snag.gy/37tQUl.jpg > > I do not understand what exactly does not work for you. > Can you add more details (with screenshots) about your problem > "step-by-step"? I apologize. I did not realize the new extension does not work the same. I was looking for the forcastfox bar at screen bottom and not the toolbar icon. This works just fine with current nightlies.
OK. SO what remains here I guess is to get the version 3.4 on the official add-ons site and properly signed so that it will work in Beta and Release versions.
Version 3.4 is in conflict with NoScript As soon as the author makes an update to NoScript 5.0.3 - then I will release 3.4
OK so once that is accomplished, please close this bug as fixed with a comment saying "Fixed by posting version 3.x to AMO".
Assignee: nobody → pag77
Status: NEW → ASSIGNED
OS: Unspecified → All
Hardware: Unspecified → All
No longer depends on: 1352513
I do not have the right to change the status, I can only leave a comment
Status: ASSIGNED → NEW
Silly me would have thought if i assigned the bug to you you could change the status. Just add a comment. I can close it.
Given Comment #6, it seems like this isn't a regression caused by Firefox, but an addon issue (possibly a conflict with NoScript)? Is that the case Bill? (If so, we can probably remove the regression keyword)
Flags: needinfo?(wgianopoulos)
(In reply to Mike Taylor [:miketaylr] from comment #18) > Given Comment #6, it seems like this isn't a regression caused by Firefox, > but an addon issue (possibly a conflict with NoScript)? Is that the case > Bill? > > (If so, we can probably remove the regression keyword) I don't run NoScript. The currently available version of this add-on is not compatible with the change for bug 1145470. The new, not yet released version does not work with NoScript and will be released as soon as the NoScript compatibility issue is resolved.
Flags: needinfo?(wgianopoulos)
OK, thanks Bill. Let's continue to track for 55, since it serves as a useful signal that we need to back out Bug 1145470.
The NoScript author no longer answers my letters. Can anyone find out does he when it's planned to release NoScript 5.0.3? This is a critical error in addon and absolutely all WebExtensions can not do XMLHttpRequest, since NoScript blocks all calls by default
Andy, is this an extension compat issue we should be tracking?
Flags: needinfo?(amckay)
The bug that caused this, bug 1145470 has this marked as compat issue. So that means we'll let authors know about it. I agree with Jorge that it would have been nice to wait till 57, but here we are.
Flags: needinfo?(amckay)
It also looks like in bug 1352513 a pref was added for that, perhaps the add-on could set that pref and see if it works.
(In reply to Andy McKay [:andym] from comment #23) > The bug that caused this, bug 1145470 has this marked as compat issue. So > that means we'll let authors know about it. I agree with Jorge that it would > have been nice to wait till 57, but here we are. If there is serious breakage in more add-ons, I'm happy to switch the default value of the pref on non-nightly. As it is, in this case it sounds like the add-on has already been fixed but it's being blocked by the effect noscript has on webextensions? That seems like an issue that will need resolving irrespective of what we do with 1145470 / the pref.
I haven't seen any more breakage yet, I would leave the pref as is. cc'ing in the NoScript author.
NoScript 5.0.3 is in AMO's review queue right now.(In reply to Oleksandr from comment #21) > Can anyone find out does he when it's planned to release NoScript 5.0.3? NoScript 5.0.3 is in AMO's review queue right now.
Thank you Giorgio!
Forecastfox (fix version) Listed Version: 2.4.8 Next Listed Version: 3.4 Queue Position: 66 of 268 Version 3.4 is awaiting approval from March 16, 2017... Can any way speed up the approval? Or wait until November 2017? :)
The latest version of the add-on is now live on AMO.
(In reply to Bill Gianopoulos [:WG9s] from comment #17) > Silly me would have thought if i assigned the bug to you you could change > the status. Just add a comment. I can close it. (In reply to Jorge Villalobos [:jorgev] from comment #30) > The latest version of the add-on is now live on AMO. Thank you!
Resolving per the earlier comments.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WORKSFORME
See Also: → 1460685
Component: Add-ons → General
Product: Tech Evangelism → WebExtensions
You need to log in before you can comment on or make changes to this bug.