Closed Bug 1460685 Opened 2 years ago Closed 2 years ago

Remove the "security.allow_chrome_frames_inside_content" pref that was added for XUL extension compat

Categories

(Core :: Security: CAPS, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: bgrins, Assigned: bgrins)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

AFAICT the patch landed in Bug 1352513 can be removed now that we don't support XUL extensions
Gijs: this can be removed now, right?
Flags: needinfo?(gijskruitbosch+bugs)
Yep!
Flags: needinfo?(gijskruitbosch+bugs)
(So sadly this isn't just a straight backout, you need to undo the pref-y bits of https://hg.mozilla.org/mozilla-central/rev/14c22e5dbf01 ; bug 1320124 )
(In reply to :Gijs (he/him) from comment #6)
> (So sadly this isn't just a straight backout, you need to undo the pref-y
> bits of https://hg.mozilla.org/mozilla-central/rev/14c22e5dbf01 ; bug
> 1320124 )

Alright, thanks for catching that. I think I've cleaned that part out in the first patch now, but will do a try push to confirm it didn't break anything.
Comment on attachment 8975201 [details]
Bug 1460685 - Remove security.allow_chrome_frames_inside_content case from nsDocument;

https://reviewboard.mozilla.org/r/243550/#review249528
Attachment #8975201 - Flags: review?(gijskruitbosch+bugs) → review+
Comment on attachment 8975034 [details]
Bug 1460685 - Backed out changeset 09ee763947c3 (bug 1352513);

https://reviewboard.mozilla.org/r/243396/#review249530

Thanks!
Attachment #8975034 - Flags: review?(gijskruitbosch+bugs) → review+
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cdc2998c1d65
Remove security.allow_chrome_frames_inside_content case from nsDocument;r=Gijs
https://hg.mozilla.org/integration/autoland/rev/642464c62241
Backed out changeset 09ee763947c3 (bug 1352513);r=Gijs
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2916d6d70f27
Remove security.allow_chrome_frames_inside_content case from nsDocument;r=Gijs
https://hg.mozilla.org/integration/mozilla-inbound/rev/f915e7d86ab8
Backed out changeset 09ee763947c3 (bug 1352513);r=Gijs
https://hg.mozilla.org/mozilla-central/rev/cdc2998c1d65
https://hg.mozilla.org/mozilla-central/rev/642464c62241
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
QA Whiteboard: [good first verify]
You need to log in before you can comment on or make changes to this bug.