Closed
Bug 1460685
Opened 6 years ago
Closed 6 years ago
Remove the "security.allow_chrome_frames_inside_content" pref that was added for XUL extension compat
Categories
(Core :: Security: CAPS, enhancement)
Core
Security: CAPS
Tracking
()
RESOLVED
FIXED
mozilla62
Tracking | Status | |
---|---|---|
firefox62 | --- | fixed |
People
(Reporter: bgrins, Assigned: bgrins)
References
Details
Attachments
(2 files)
AFAICT the patch landed in Bug 1352513 can be removed now that we don't support XUL extensions
Assignee | ||
Comment 1•6 years ago
|
||
Gijs: this can be removed now, right?
Flags: needinfo?(gijskruitbosch+bugs)
Comment hidden (mozreview-request) |
Assignee | ||
Comment 4•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=96d501f30f10e80c48f7e2f1692114971fbc6b23
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Comment 5•6 years ago
|
||
mozreview-review |
Comment on attachment 8975034 [details] Bug 1460685 - Backed out changeset 09ee763947c3 (bug 1352513); https://reviewboard.mozilla.org/r/243396/#review249396 This misses https://dxr.mozilla.org/mozilla-central/rev/0cd106a2eb78aa04fd481785257e6f4f9b94707b/dom/base/nsDocument.cpp#286 and its uses. :-)
Attachment #8975034 -
Flags: review?(gijskruitbosch+bugs) → review-
Comment 6•6 years ago
|
||
(So sadly this isn't just a straight backout, you need to undo the pref-y bits of https://hg.mozilla.org/mozilla-central/rev/14c22e5dbf01 ; bug 1320124 )
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 9•6 years ago
|
||
(In reply to :Gijs (he/him) from comment #6) > (So sadly this isn't just a straight backout, you need to undo the pref-y > bits of https://hg.mozilla.org/mozilla-central/rev/14c22e5dbf01 ; bug > 1320124 ) Alright, thanks for catching that. I think I've cleaned that part out in the first patch now, but will do a try push to confirm it didn't break anything.
Comment 10•6 years ago
|
||
mozreview-review |
Comment on attachment 8975201 [details] Bug 1460685 - Remove security.allow_chrome_frames_inside_content case from nsDocument; https://reviewboard.mozilla.org/r/243550/#review249528
Attachment #8975201 -
Flags: review?(gijskruitbosch+bugs) → review+
Comment 11•6 years ago
|
||
mozreview-review |
Comment on attachment 8975034 [details] Bug 1460685 - Backed out changeset 09ee763947c3 (bug 1352513); https://reviewboard.mozilla.org/r/243396/#review249530 Thanks!
Attachment #8975034 -
Flags: review?(gijskruitbosch+bugs) → review+
Comment 12•6 years ago
|
||
Pushed by bgrinstead@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cdc2998c1d65 Remove security.allow_chrome_frames_inside_content case from nsDocument;r=Gijs https://hg.mozilla.org/integration/autoland/rev/642464c62241 Backed out changeset 09ee763947c3 (bug 1352513);r=Gijs
Comment 13•6 years ago
|
||
Pushed by csabou@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/2916d6d70f27 Remove security.allow_chrome_frames_inside_content case from nsDocument;r=Gijs https://hg.mozilla.org/integration/mozilla-inbound/rev/f915e7d86ab8 Backed out changeset 09ee763947c3 (bug 1352513);r=Gijs
Comment 14•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/cdc2998c1d65 https://hg.mozilla.org/mozilla-central/rev/642464c62241
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Comment 15•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2916d6d70f27 https://hg.mozilla.org/mozilla-central/rev/f915e7d86ab8
Updated•6 years ago
|
QA Whiteboard: [good first verify]
You need to log in
before you can comment on or make changes to this bug.
Description
•