1460685 - Remove the "security.allow_chrome_frames_inside_content" pref that was added for XUL extension compat

Status: RESOLVED FIXED

(Core :: Security: CAPS, enhancement)

Description

[Brian Grinstead [:bgrins]]

AFAICT the patch landed in Bug 1352513 can be removed now that we don't support XUL extensions

Comment 1

[Brian Grinstead [:bgrins]]

Gijs: this can be removed now, right?

Comment 2

[:Gijs (out for now; he/him)]

Yep!

Comment 3

[Brian Grinstead [:bgrins]]

Attachment: Bug 1460685 - Backed out changeset 09ee763947c3 (bug 1352513);

The security.allow_chrome_frames_inside_content pref was added to support
XUL extension compat after the hiddenWindow special case was removed in
Bug 1145470. Since we don't need to support that use-case anymore, this
changeset backs out the change that relanded the special case with the pref.

Review commit: https://reviewboard.mozilla.org/r/243396/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/243396/

Comment 4

[Brian Grinstead [:bgrins]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=96d501f30f10e80c48f7e2f1692114971fbc6b23

Comment 5

[:Gijs (out for now; he/him)]

Comment on attachment 8975034 [details]
Bug 1460685 - Backed out changeset 09ee763947c3 (bug 1352513);

https://reviewboard.mozilla.org/r/243396/#review249396

This misses https://dxr.mozilla.org/mozilla-central/rev/0cd106a2eb78aa04fd481785257e6f4f9b94707b/dom/base/nsDocument.cpp#286 and its uses. :-)

Comment 6

[:Gijs (out for now; he/him)]

(So sadly this isn't just a straight backout, you need to undo the pref-y bits of https://hg.mozilla.org/mozilla-central/rev/14c22e5dbf01 ; bug 1320124 )

Comment 7

[Brian Grinstead [:bgrins]]

Attachment: Bug 1460685 - Remove security.allow_chrome_frames_inside_content case from nsDocument;

This pref will be removed in the following changeset.

Review commit: https://reviewboard.mozilla.org/r/243550/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/243550/

Comment 8

[Brian Grinstead [:bgrins]]

Comment on attachment 8975034 [details]
Bug 1460685 - Backed out changeset 09ee763947c3 (bug 1352513);

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/243396/diff/1-2/

Comment 9

[Brian Grinstead [:bgrins]]

(In reply to :Gijs (he/him) from comment #6)
> (So sadly this isn't just a straight backout, you need to undo the pref-y
> bits of https://hg.mozilla.org/mozilla-central/rev/14c22e5dbf01 ; bug
> 1320124 )

Alright, thanks for catching that. I think I've cleaned that part out in the first patch now, but will do a try push to confirm it didn't break anything.

Comment 10

[:Gijs (out for now; he/him)]

Comment on attachment 8975201 [details]
Bug 1460685 - Remove security.allow_chrome_frames_inside_content case from nsDocument;

https://reviewboard.mozilla.org/r/243550/#review249528

Comment 11

[:Gijs (out for now; he/him)]

Comment on attachment 8975034 [details]
Bug 1460685 - Backed out changeset 09ee763947c3 (bug 1352513);

https://reviewboard.mozilla.org/r/243396/#review249530

Thanks!

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cdc2998c1d65
Remove security.allow_chrome_frames_inside_content case from nsDocument;r=Gijs
https://hg.mozilla.org/integration/autoland/rev/642464c62241
Backed out changeset 09ee763947c3 (bug 1352513);r=Gijs

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2916d6d70f27
Remove security.allow_chrome_frames_inside_content case from nsDocument;r=Gijs
https://hg.mozilla.org/integration/mozilla-inbound/rev/f915e7d86ab8
Backed out changeset 09ee763947c3 (bug 1352513);r=Gijs

Comment 14

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/cdc2998c1d65
https://hg.mozilla.org/mozilla-central/rev/642464c62241

Comment 15

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/2916d6d70f27
https://hg.mozilla.org/mozilla-central/rev/f915e7d86ab8