1353073 - context menus do not work when webextensions.remote=true

Status: RESOLVED FIXED

(WebExtensions :: Frontend, defect)

Description

[Shane Caraveo (:mixedpuppy)]

content.js calls sendRpcMessage which is normally picked up by tabbrowser.  However, when a webextension panel is remote, tabbrowser does not receive the message (at least in sidebar, unable to test popup due to bug 1353060).  

Simply relaying the message also does not work so we need to handle the contextmenu message in the sidebar panel.

Comment 1

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1353073 handle contextmenu in sidebar when remote=true,

Review commit: https://reviewboard.mozilla.org/r/126050/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/126050/

Comment 2

[Kris Maglione [:kmag]]

Comment on attachment 8854069 [details]
Bug 1353073 handle contextmenu in sidebar when remote=true,

https://reviewboard.mozilla.org/r/126050/#review130604

::: browser/base/content/webext-panels.js:16
(Diff revision 1)
>    promiseEvent,
>  } = ExtensionUtils;
>  
>  const XUL_NS = "http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul";
>  
> +function handleContentContextMenu(aMessage) {

It would be nice if we didn't have to duplicate all of this. Can we add a helper to `nsContextMenu` instead?

Comment 3

[Kris Maglione [:kmag]]

Sorry for the delay. I'm not in the habit of looking at my feedback queue.

Comment 4

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8854069 [details]
Bug 1353073 handle contextmenu in sidebar when remote=true,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/126050/diff/1-2/

Comment 5

[Kris Maglione [:kmag]]

Comment on attachment 8854069 [details]
Bug 1353073 handle contextmenu in sidebar when remote=true,

https://reviewboard.mozilla.org/r/126050/#review133060

Comment 6

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8854069 [details]
Bug 1353073 handle contextmenu in sidebar when remote=true,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/126050/diff/2-3/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc91bd1a27a7
handle contextmenu in sidebar when remote=true, r=kmag

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out for eslint failures like https://public-artifacts.taskcluster.net/RxRKHCfPQd-_TLs9ctx74A/0/public/logs/live_backing.log

Error hiding in full log:
[task 2017-04-15T07:27:18.629452Z] Error: ENOENT: no such file or directory, open '/home/worker/checkouts/gecko/browser/base/content/browser.js nsContextMenu.js'

https://hg.mozilla.org/integration/autoland/rev/9a16c329034e

Comment 9

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8854069 [details]
Bug 1353073 handle contextmenu in sidebar when remote=true,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/126050/diff/3-4/

Comment 10

[Shane Caraveo (:mixedpuppy)]

Sigh.  update eslint and it caught it this time.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3244c4fd84a1
handle contextmenu in sidebar when remote=true, r=kmag

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/3244c4fd84a1