1353136 - view page info crashes when opened from context menu in sidebar

Status: RESOLVED WORKSFORME

Description

[Shane Caraveo (:mixedpuppy)]

With patches from bug 1299371 and bug 1353073, view page-info in the sidebar crashes nightly.

STR
- apply patches mentioned
- load an addon with a sidebar
- open context menu
- select view page info

Window opens and Firefox crashes a couple seconds later.

Comment 1

[Martin Giger [:freaktechnik]]

Could not reproduce this when testing the patch from bug 1353073. The page info dialog was properly displayed and Firefox was stable. I've applied the patches on top of the current m-c tip.

Comment 2

[:shell escalante]

shane just checking, but believe resolved by later patch

Comment 3

[Shane Caraveo (:mixedpuppy)]

I was able to reproduce again on OSX 10.11.6 with a fresh pull/build from last night.  This actually doesn't require patches from the context fixes and does not require setting remote=true for extensions.  Simply run, load a sidebar, open the context menu on the sidebar, view page info.

Comment 4

[Shane Caraveo (:mixedpuppy)]

Another note, this also does not need an extension to reproduce.  You can use the bookmark sidebar and accomplish the same thing.  The bookmark and extension sidebars are structurally very similar.

- bookmark a page, place it in the bookmarks toolbar
- edit properties, check open in sidebar
- open bookmark (sidebar will appear)
- open context menu in sidebar
- select view page info

page info hangs then crashes in about 20 seconds.

Comment 5

[Marcia Knous [:marcia - needinfo? me]]

Tracking 55+ for this reproducible crash.

Comment 6

[Liz Henry (:lizzard) (needinfo? me)]

Florian, can you help find an owner for this issue?

Comment 7

[Liz Henry (:lizzard) (needinfo? me)]

Andrei, can your team try and reproduce this and link to the crash report/signature? Thanks.

Comment 8

[Florian Quèze [:florian]]

(In reply to Shane Caraveo (:mixedpuppy) from comment #4)
> Another note, this also does not need an extension to reproduce.  You can
> use the bookmark sidebar and accomplish the same thing.  The bookmark and
> extension sidebars are structurally very similar.
> 
> - bookmark a page, place it in the bookmarks toolbar
> - edit properties, check open in sidebar
> - open bookmark (sidebar will appear)
> - open context menu in sidebar
> - select view page info
> 
> page info hangs then crashes in about 20 seconds.

I can't reproduce with these steps, does it need to be a specific page? I tried with https://developer.mozilla.org/en-US/

Comment 9

[Bogdan Maris, QA [:bogdan_maris]]

I was also unable to reproduce this issue using latest Nightly 56.0a1 and Firefox 55 beta 5 on Mac OS X 10.11.

Comment 10

[Shane Caraveo (:mixedpuppy)]

I am also unable to reproduce on nightly now, closing.