Cleanup some dtrace related things

RESOLVED FIXED in Firefox 55

Status

RESOLVED FIXED
a year ago
6 months ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
mozilla55
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

Comment hidden (empty)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 3

a year ago
Jan, can you check if that works for FreeBSD? As mentioned in the commit message of the second patch, AFAICT, FreeBSD doesn't actually need the file generated by dtrace -G. Even if it does, I'd still rather remove this code anyways, it can be added after bug 1262241 (and should live entirely in js/src anyways)
Flags: needinfo?(jbeich)

Comment 4

a year ago
Doesn't build on FreeBSD which have been using bug 702179 fix for ~3 years.

../../js/src/jsarray.o: In function `js::NewDenseEmptyArray(JSContext*, JS::Handle<JSObject*>, js::NewObjectKind)':
js/src/jsarray.cpp:(.text._ZN2js18NewDenseEmptyArrayEP9JSContextN2JS6HandleIP8JSObjectEENS_13NewObjectKindE+0x3a4): undefined reference to `__dtraceenabled_javascript___object__create'
/usr/bin/ld: ../../js/src/jsarray.o: relocation R_X86_64_PC32 against `__dtraceenabled_javascript___object__create' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: final link failed: Bad value
Flags: needinfo?(jbeich)

Comment 5

a year ago
mozreview-review
Comment on attachment 8854304 [details]
Bug 1353259 - Remove rules.mk sections depending on DTRACE_LIB_DEPENDENT.

https://reviewboard.mozilla.org/r/126240/#review129046
Attachment #8854304 - Flags: review?(mshal) → review+

Comment 6

a year ago
mozreview-review
Comment on attachment 8854305 [details]
Bug 1353259 - Remove build system parts that generate a dtrace ELF object.

https://reviewboard.mozilla.org/r/126242/#review129048
Attachment #8854305 - Flags: review?(mshal) → review+

Comment 7

a year ago
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/cdba772d904d
Remove rules.mk sections depending on DTRACE_LIB_DEPENDENT. r=mshal
https://hg.mozilla.org/integration/autoland/rev/db92496e83dd
Remove build system parts that generate a dtrace ELF object. r=mshal

Updated

a year ago
Depends on: 1353558

Comment 8

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/cdba772d904d
https://hg.mozilla.org/mozilla-central/rev/db92496e83dd
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55

Updated

6 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.