Closed
Bug 1353558
Opened 8 years ago
Closed 8 years ago
--enable-dtrace fails to build on FreeBSD and Solaris
Categories
(Firefox Build System :: General, defect)
Tracking
(firefox-esr52 unaffected, firefox53 unaffected, firefox54 unaffected, firefox55 fixed)
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox-esr52 | --- | unaffected |
| firefox53 | --- | unaffected |
| firefox54 | --- | unaffected |
| firefox55 | --- | fixed |
People
(Reporter: jbeich, Assigned: jbeich)
References
Details
(Keywords: regression)
Attachments
(1 file)
GeckoProfiler is N/A on Tier3 platforms, so DTrace maybe the only way to profile JavaScript code. FreeBSD adopted DTrace from OpenSolaris, so the limitations are similar. Firefox package downstream has enabled DTrace probes *by default* a year ago, so any regressions were quickly found and fixed. Except for bug 702179 which was stalled but not required to unbreak build.
Solaris state on mozilla-central after bug 1255813 is unclear, so let's focus on FreeBSD.
$ echo "ac_add_options --enable-dtrace" >>.mozconfig
$ ./mach bootstrap
$ ./mach build
[...]
objdir/_virtualenv/bin/python config/expandlibs_exec.py --uselist -- /usr/bin/clang++ -std=gnu++11 -o jsapi-tests -Qunused-arguments -I/usr/local/include -Qunused-arguments -Wall -Wc++11-compat -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wloop-analysis -Wc++11-compat-pedantic -Wc++14-compat -Wc++14-compat-pedantic -Wc++1z-compat -Wimplicit-fallthrough -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-rtti -fno-exceptions -fno-math-errno -pipe -O -fno-omit-frame-pointer testAssemblerBuffer.o Unified_cpp_js_src_jsapi-tests0.o Unified_cpp_js_src_jsapi-tests1.o Unified_cpp_js_src_jsapi-tests2.o Unified_cpp_js_src_jsapi-tests3.o Unified_cpp_js_src_jsapi-tests4.o Unified_cpp_js_src_jsapi-tests5.o Unified_cpp_js_src_jsapi-tests6.o -pthread -Wl,-z,noexecstack -Wl,-z,text -rdynamic -Wl,-rpath-link,objdir/dist/bin -Wl,-rpath-link,objdir/dist/lib -fcolor-diagnostics ../../../mozglue/build/libmozglue.a ../../../memory/fallible/libfallible.a ../../../config/external/icu/data/libicudata.a ../../../js/src/build/libjs_static.a ../../../config/external/nspr/pr/libnspr4.so ../../../config/external/nspr/libc/libplc4.so ../../../config/external/nspr/ds/libplds4.so -lm -lm -pthread
../build/libjs_static.a(jsarray.o): In function `js::NewDenseEmptyArray(JSContext*, JS::Handle<JSObject*>, js::NewObjectKind)':
js/src/jsarray.cpp:(.text+0xa201): undefined reference to `__dtraceenabled_javascript___object__create'
js/src/jsarray.cpp:(.text+0xa2db): undefined reference to `__dtrace_javascript___object__create'
../build/libjs_static.a(jsarray.o): In function `js::NewDenseFullyAllocatedArray(JSContext*, unsigned int, JS::Handle<JSObject*>, js::NewObjectKind)':
js/src/jsarray.cpp:(.text+0xa77b): undefined reference to `__dtraceenabled_javascript___object__create'
js/src/jsarray.cpp:(.text+0xa8c9): undefined reference to `__dtrace_javascript___object__create'
../build/libjs_static.a(jsarray.o): In function `js::NewDensePartlyAllocatedArray(JSContext*, unsigned int, JS::Handle<JSObject*>, js::NewObjectKind)':
js/src/jsarray.cpp:(.text+0xad77): undefined reference to `__dtraceenabled_javascript___object__create'
js/src/jsarray.cpp:(.text+0xaed3): undefined reference to `__dtrace_javascript___object__create'
../build/libjs_static.a(jsarray.o): In function `js::NewDenseUnallocatedArray(JSContext*, unsigned int, JS::Handle<JSObject*>, js::NewObjectKind)':
js/src/jsarray.cpp:(.text+0xb365): undefined reference to `__dtraceenabled_javascript___object__create'
js/src/jsarray.cpp:(.text+0xb49d): undefined reference to `__dtrace_javascript___object__create'
../build/libjs_static.a(jsarray.o): In function `js::NewDenseCopiedArray(JSContext*, unsigned int, JS::Value const*, JS::Handle<JSObject*>, js::NewObjectKind)':
js/src/jsarray.cpp:(.text+0xb963): undefined reference to `__dtraceenabled_javascript___object__create'
js/src/jsarray.cpp:(.text+0xbab8): undefined reference to `__dtrace_javascript___object__create'
../build/libjs_static.a(jsarray.o): In function `js::NewDenseFullyAllocatedArrayWithTemplate(JSContext*, unsigned int, JSObject*)':
js/src/jsarray.cpp:(.text+0xbd33): undefined reference to `__dtraceenabled_javascript___object__create'
js/src/jsarray.cpp:(.text+0xbd77): undefined reference to `__dtrace_javascript___object__create'
../build/libjs_static.a(jsarray.o): In function `js::NewDenseCopyOnWriteArray(JSContext*, JS::Handle<js::ArrayObject*>, js::gc::InitialHeap)':
js/src/jsarray.cpp:(.text+0xbddc): undefined reference to `__dtraceenabled_javascript___object__create'
js/src/jsarray.cpp:(.text+0xbe11): undefined reference to `__dtrace_javascript___object__create'
../build/libjs_static.a(jsarray.o): In function `JSObject* NewArrayTryUseGroup<4294967295u>(JSContext*, JS::Handle<js::ObjectGroup*>, unsigned long, js::NewObjectKind)':
js/src/jsarray.cpp:(.text+0xc479): undefined reference to `__dtraceenabled_javascript___object__create'
js/src/jsarray.cpp:(.text+0xc8e6): undefined reference to `__dtraceenabled_javascript___object__create'
js/src/jsarray.cpp:(.text+0xca39): undefined reference to `__dtrace_javascript___object__create'
js/src/jsarray.cpp:(.text+0xccaa): undefined reference to `__dtrace_javascript___object__create'
../build/libjs_static.a(jsarray.o): In function `JSObject* NewArrayTryUseGroup<2046u>(JSContext*, JS::Handle<js::ObjectGroup*>, unsigned long, js::NewObjectKind)':
js/src/jsarray.cpp:(.text+0xd313): undefined reference to `__dtraceenabled_javascript___object__create'
js/src/jsarray.cpp:(.text+0xd6ec): undefined reference to `__dtraceenabled_javascript___object__create'
js/src/jsarray.cpp:(.text+0xd84c): undefined reference to `__dtrace_javascript___object__create'
js/src/jsarray.cpp:(.text+0xdad7): undefined reference to `__dtrace_javascript___object__create'
../build/libjs_static.a(jsarray.o): In function `js::NewFullyAllocatedArrayTryReuseGroup(JSContext*, JS::Handle<JSObject*>, unsigned long, js::NewObjectKind)':
js/src/jsarray.cpp:(.text+0xe094): undefined reference to `__dtraceenabled_javascript___object__create'
js/src/jsarray.cpp:(.text+0xe514): undefined reference to `__dtraceenabled_javascript___object__create'
js/src/jsarray.cpp:(.text+0xe6c0): undefined reference to `__dtrace_javascript___object__create'
../build/libjs_static.a(jsarray.o): In function `js::NewPartlyAllocatedArrayTryReuseGroup(JSContext*, JS::Handle<JSObject*>, unsigned long)':
js/src/jsarray.cpp:(.text+0xebeb): undefined reference to `__dtraceenabled_javascript___object__create'
js/src/jsarray.cpp:(.text+0xefd5): undefined reference to `__dtraceenabled_javascript___object__create'
js/src/jsarray.cpp:(.text+0xf153): undefined reference to `__dtrace_javascript___object__create'
../build/libjs_static.a(jsarray.o): In function `js::NewObjectCache::newObjectFromHit(JSContext*, int, js::gc::InitialHeap)':
js/src/jsarray.cpp:(.text._ZN2js14NewObjectCache16newObjectFromHitEP9JSContextiNS_2gc11InitialHeapE[_ZN2js14NewObjectCache16newObjectFromHitEP9JSContextiNS_2gc11InitialHeapE]+0x1a3): undefined reference to `__dtraceenabled_javascript___object__create'
js/src/jsarray.cpp:(.text._ZN2js14NewObjectCache16newObjectFromHitEP9JSContextiNS_2gc11InitialHeapE[_ZN2js14NewObjectCache16newObjectFromHitEP9JSContextiNS_2gc11InitialHeapE]+0x1e3): undefined reference to `__dtrace_javascript___object__create'
../build/libjs_static.a(Interpreter.o): In function `js::ExecuteKernel(JSContext*, JS::Handle<JSScript*>, JSObject&, JS::Value const&, js::AbstractFramePtr, JS::Value*)':
js/src/vm/Interpreter.cpp:(.text+0xfdcc): undefined reference to `__dtraceenabled_javascript___execute__start'
js/src/vm/Interpreter.cpp:(.text+0xfdfd): undefined reference to `__dtrace_javascript___execute__start'
js/src/vm/Interpreter.cpp:(.text+0xfea3): undefined reference to `__dtraceenabled_javascript___execute__done'
js/src/vm/Interpreter.cpp:(.text+0xfed3): undefined reference to `__dtrace_javascript___execute__done'
../build/libjs_static.a(Unified_cpp_js_src15.o): In function `js::jit::HandleException(js::jit::ResumeFromException*)':
objdir/js/src/Unified_cpp_js_src15.cpp:(.text+0xbc8): undefined reference to `__dtraceenabled_javascript___function__return'
objdir/js/src/Unified_cpp_js_src15.cpp:(.text+0x1df3): undefined reference to `__dtraceenabled_javascript___function__return'
../build/libjs_static.a(Unified_cpp_js_src25.o): In function `unsigned long js::gc::Arena::finalize<JSObject>(js::FreeOp*, js::gc::AllocKind, unsigned long)':
objdir/js/src/Unified_cpp_js_src25.cpp:(.text._ZN2js2gc5Arena8finalizeI8JSObjectEEmPNS_6FreeOpENS0_9AllocKindEm[_ZN2js2gc5Arena8finalizeI8JSObjectEEmPNS_6FreeOpENS0_9AllocKindEm]+0x131): undefined reference to `__dtraceenabled_javascript___object__finalize'
objdir/js/src/Unified_cpp_js_src25.cpp:(.text._ZN2js2gc5Arena8finalizeI8JSObjectEEmPNS_6FreeOpENS0_9AllocKindEm[_ZN2js2gc5Arena8finalizeI8JSObjectEEmPNS_6FreeOpENS0_9AllocKindEm]+0x148): undefined reference to `__dtrace_javascript___object__finalize'
../build/libjs_static.a(Unified_cpp_js_src26.o): In function `NewObject(JSContext*, JS::Handle<js::ObjectGroup*>, js::gc::AllocKind, js::NewObjectKind, unsigned int)':
objdir/js/src/Unified_cpp_js_src26.cpp:(.text+0x394d): undefined reference to `__dtraceenabled_javascript___object__create'
objdir/js/src/Unified_cpp_js_src26.cpp:(.text+0x399f): undefined reference to `__dtrace_javascript___object__create'
../build/libjs_static.a(Unified_cpp_js_src33.o): In function `js::probes::DTraceEnterJSFun(JSContext*, JSFunction*, JSScript*)':
objdir/js/src/Unified_cpp_js_src33.cpp:(.text+0x10501): undefined reference to `__dtrace_javascript___function__entry'
../build/libjs_static.a(Unified_cpp_js_src33.o): In function `js::probes::DTraceExitJSFun(JSContext*, JSFunction*, JSScript*)':
objdir/js/src/Unified_cpp_js_src33.cpp:(.text+0x105b1): undefined reference to `__dtrace_javascript___function__return'
../build/libjs_static.a(Unified_cpp_js_src35.o): In function `js::InterpreterFrame::prologue(JSContext*)':
objdir/js/src/Unified_cpp_js_src35.cpp:(.text+0xcdef): undefined reference to `__dtraceenabled_javascript___function__entry'
objdir/js/src/Unified_cpp_js_src35.cpp:(.text+0xd18d): undefined reference to `__dtraceenabled_javascript___function__entry'
objdir/js/src/Unified_cpp_js_src35.cpp:(.text+0xd21c): undefined reference to `__dtraceenabled_javascript___function__entry'
../build/libjs_static.a(Unified_cpp_js_src35.o): In function `js::InterpreterFrame::epilogue(JSContext*, unsigned char*)':
objdir/js/src/Unified_cpp_js_src35.cpp:(.text+0xd3a1): undefined reference to `__dtraceenabled_javascript___function__return'
../build/libjs_static.a(Unified_cpp_js_src9.o): In function `js::jit::Bailout(js::jit::BailoutStack*, js::jit::BaselineBailoutInfo**)':
objdir/js/src/Unified_cpp_js_src9.cpp:(.text+0x10a): undefined reference to `__dtraceenabled_javascript___function__return'
../build/libjs_static.a(Unified_cpp_js_src9.o): In function `js::jit::InvalidationBailout(js::jit::InvalidationBailoutStack*, unsigned long*, js::jit::BaselineBailoutInfo**)':
objdir/js/src/Unified_cpp_js_src9.cpp:(.text+0x4b84): undefined reference to `__dtraceenabled_javascript___function__return'
/usr/bin/ld: jsapi-tests: hidden symbol `__dtraceenabled_javascript___execute__done' isn't defined
/usr/bin/ld: final link failed: Bad value
Martin, have you tried to build Firefox with DTrace on NetBSD? Does it require an extra ELF object file (i.e. js-dtrace.o) like on Solaris and FreeBSD?
Flags: needinfo?(martin)
Petr, does Solaris still need dtrace -G for USDT unlike OS X? Would lack of it affect downstream builds?
Flags: needinfo?(petr.sumbera)
|
||
Comment 3•8 years ago
|
||
Jan, I'm not DTrace expert. But I beleive there was no change in regards '-G'.
At this moment we have DTrace disabled for Firefox 52 because it was failing like this:
dtrace -x nolibs -G -C -s /builds/psumbera/userland-ff-52-jinji/components/desktop/firefox/firefox-52.0.2esr/js/src/devtools/javascript-trace.d -o js-dtrace.o RegExp.o CTypes.o Library.o Parser.o StoreBuffer.o Disassembler-x86-shared.o jsarray.o jsatom.o jsdtoa.o jsmath.o jsutil.o pm_stub.o ConditionVariable.o MutexImpl.o Thread.o Initialization.o TraceLogging.o TraceLoggingGraph.o TraceLoggingTypes.o Unified_cpp_js_src0.o Unified_cpp_js_src1.o Unified_cpp_js_src10.o Unified_cpp_js_src11.o Unified_cpp_js_src12.o Unified_cpp_js_src13.o Unified_cpp_js_src14.o Unified_cpp_js_src15.o Unified_cpp_js_src16.o Unified_cpp_js_src17.o Unified_cpp_js_src18.o Unified_cpp_js_src19.o Unified_cpp_js_src2.o Unified_cpp_js_src20.o Unified_cpp_js_src21.o Unified_cpp_js_src22.o Unified_cpp_js_src23.o Unified_cpp_js_src24.o Unified_cpp_js_src25.o Unified_cpp_js_src26.o Unified_cpp_js_src27.o Unified_cpp_js_src28.o Unified_cpp_js_src29.o Unified_cpp_js_src3.o Unified_cpp_js_src30.o Unified_cpp_js_src31.o Unified_cpp_js_src32.o Unified_cpp_js_src33.o Unified_cpp_js_src34.o Unified_cpp_js_src35.o Unified_cpp_js_src36.o Unified_cpp_js_src37.o Unified_cpp_js_src38.o Unified_cpp_js_src39.o Unified_cpp_js_src4.o Unified_cpp_js_src40.o Unified_cpp_js_src5.o Unified_cpp_js_src6.o Unified_cpp_js_src7.o Unified_cpp_js_src8.o Unified_cpp_js_src9.o
dtrace: failed to link script /builds/psumbera/userland-ff-52-jinji/components/desktop/firefox/firefox-52.0.2esr/js/src/devtools/javascript-trace.d: failed to allocate space for probe
From my previous investigation it was related to js/src/jsgc.cpp...
Flags: needinfo?(petr.sumbera)
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
(In reply to Petr Sumbera from comment #3)
> dtrace: failed to link script js/src/devtools/javascript-trace.d: failed to allocate space for probe
Can you try a different compiler e.g., Clang? I remember seeing a similar issue with .o files from GCC on FreeBSD.
Flags: needinfo?(petr.sumbera)
|
||
Comment 8•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8858487 [details]
Bug 1353558 - Restore "dtrace -G" support after bug 1353259 for Solaris and FreeBSD.
https://reviewboard.mozilla.org/r/130450/#review133266
::: js/src/Makefile.in:153
(Diff revision 3)
> # we have to list them explicitly.
> $(addsuffix .$(OBJ_SUFFIX),Probes jsinterp jsobj): $(CURDIR)/javascript-trace.h
> -endif
>
> +ifndef XP_MACOSX
> +DTRACE_PROBE_OBJ = $(LIBRARY_NAME)-dtrace.$(OBJ_SUFFIX)
No point making this object name contain LIBRARY_NAME, especially when it's now "js_src".
::: js/src/Makefile.in:154
(Diff revision 3)
> +$(LIBRARY): $(DTRACE_PROBE_OBJ)
> +$(DTRACE_PROBE_OBJ): $(srcdir)/devtools/javascript-trace.d $(OBJS)
> + dtrace -x nolibs -G -C -s $< -o $@ $(filter-out $<, $^)
> +
> +OBJS += $(DTRACE_PROBE_OBJ) # for "make clean"
I don't like that it essentially relies on luck to work. Any substantial change to the build system happening in the future will break this, and since this is tier-3, it won't be noticed.
Because despite the comment, the OBJS line is what makes it work at all, because the LIBRARY rule in config/rules.mk is using OBJS in its recipe.
On the other hand, anything more involved than the current patch is going to be a *lot* of work for what essentially is a one-off for one file on a tier-3 platform. So meh. We'll see how long it takes for this to break (again).
Attachment #8858487 -
Flags: review?(mh+mozilla) → review+
Comment on attachment 8858487 [details]
Bug 1353558 - Restore "dtrace -G" support after bug 1353259 for Solaris and FreeBSD.
https://reviewboard.mozilla.org/r/130450/#review133288
::: js/src/Makefile.in:152
(Diff revision 3)
> # We can't automatically generate dependencies on auto-generated headers;
> # we have to list them explicitly.
> $(addsuffix .$(OBJ_SUFFIX),Probes jsinterp jsobj): $(CURDIR)/javascript-trace.h
> -endif
>
> +ifndef XP_MACOSX
`XP_MACOSX` is not defined by build/moz.configure/init.configure (no set_config), so before bug 1353259 the real check was `ifdef DTRACE_PROBE_OBJ`.
```
21:51:26 INFO - dtrace -x nolibs -G -C -s /builds/slave/try-m64-0000000000000000000000/build/src/js/src/devtools/javascript-trace.d -o js-dtrace.o RegExp.o CTypes.o Library.o Instruments.o Parser.o StoreBuffer.o Disassembler-x86-shared.o jsarray.o jsatom.o jsdtoa.o jsmath.o jsutil.o pm_stub.o CpuCount.o Thread.o Initialization.o Interpreter.o TraceLogging.o TraceLoggingGraph.o TraceLoggingTypes.o Unified_cpp_js_src0.o Unified_cpp_js_src1.o Unified_cpp_js_src10.o Unified_cpp_js_src11.o Unified_cpp_js_src12.o Unified_cpp_js_src13.o Unified_cpp_js_src14.o Unified_cpp_js_src15.o Unified_cpp_js_src16.o Unified_cpp_js_src17.o Unified_cpp_js_src18.o Unified_cpp_js_src19.o Unified_cpp_js_src2.o Unified_cpp_js_src20.o Unified_cpp_js_src21.o Unified_cpp_js_src22.o Unified_cpp_js_src23.o Unified_cpp_js_src24.o Unified_cpp_js_src25.o Unified_cpp_js_src26.o Unified_cpp_js_src27.o Unified_cpp_js_src28.o Unified_cpp_js_src29.o Unified_cpp_js_src3.o Unified_cpp_js_src30.o Unified_cpp_js_src31.o Unified_cpp_js_src32.o Unified_cpp_js_src33.o Unified_cpp_js_src34.o Unified_cpp_js_src35.o Unified_cpp_js_src36.o Unified_cpp_js_src37.o Unified_cpp_js_src38.o Unified_cpp_js_src39.o Unified_cpp_js_src4.o Unified_cpp_js_src40.o Unified_cpp_js_src41.o Unified_cpp_js_src42.o Unified_cpp_js_src5.o Unified_cpp_js_src6.o Unified_cpp_js_src7.o Unified_cpp_js_src8.o Unified_cpp_js_src9.o
21:51:26 INFO - Usage: dtrace [-aACeFHlqSvVwZ] [-arch i386|x86_64] [-b bufsz] [-c cmd] [-D name[=def]]
21:51:26 INFO - [-I path] [-L path] [-o output] [-p pid] [-s script] [-U name]
21:51:26 INFO - [-x opt[=val]]
21:51:26 INFO - [-P provider [[ predicate ] action ]]
21:51:26 INFO - [-m [ provider: ] module [[ predicate ] action ]]
21:51:26 INFO - [-f [[ provider: ] module: ] func [[ predicate ] action ]]
21:51:26 INFO - [-n [[[ provider: ] module: ] func: ] name [[ predicate ] action ]]
21:51:26 INFO - [-i probe-id [[ predicate ] action ]] [ args ... ]
21:51:26 INFO - predicate -> '/' D-expression '/'
21:51:26 INFO - action -> '{' D-statements '}'
21:51:26 INFO - -arch Generate programs and Mach-O files for the specified architecture
21:51:26 INFO - -a claim anonymous tracing state
21:51:26 INFO - -A generate plist(5) entries for anonymous tracing
21:51:26 INFO - -b set trace buffer size
21:51:26 INFO - -c run specified command and exit upon its completion
21:51:26 INFO - -C run cpp(1) preprocessor on script files
21:51:26 INFO - -D define symbol when invoking preprocessor
21:51:26 INFO - -e exit after compiling request but prior to enabling probes
21:51:26 INFO - -f enable or list probes matching the specified function name
21:51:26 INFO - -F coalesce trace output by function
21:51:26 INFO - -h generate a header file with definitions for static probes
21:51:26 INFO - -H print included files when invoking preprocessor
21:51:26 INFO - -i enable or list probes matching the specified probe id
21:51:26 INFO - -I add include directory to preprocessor search path
21:51:26 INFO - -l list probes matching specified criteria
21:51:26 INFO - -L add library directory to library search path
21:51:26 INFO - -m enable or list probes matching the specified module name
21:51:26 INFO - -n enable or list probes matching the specified probe name
21:51:26 INFO - -o set output file
21:51:26 INFO - -p grab specified process-ID and cache its symbol tables
21:51:26 INFO - -P enable or list probes matching the specified provider name
21:51:26 INFO - -q set quiet mode (only output explicitly traced data)
21:51:26 INFO - -s enable or list probes according to the specified D script
21:51:26 INFO - -S print D compiler intermediate code
21:51:26 INFO - -U undefine symbol when invoking preprocessor
21:51:26 INFO - -v set verbose mode (report stability attributes, arguments)
21:51:26 INFO - -V report DTrace API version
21:51:26 INFO - -w permit destructive actions
21:51:26 INFO - -x enable or modify compiler and tracing options
21:51:26 INFO - -Z permit probe descriptions that match zero probes
21:51:26 INFO - make[5]: *** [js-dtrace.o] Error 2
21:51:26 INFO - make[4]: *** [js/src/target] Error 2
```
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 11•8 years ago
|
||
Comment on attachment 8858487 [details]
Bug 1353558 - Restore "dtrace -G" support after bug 1353259 for Solaris and FreeBSD.
r? again just in case.
Attachment #8858487 -
Flags: review+ → review?(mh+mozilla)
|
|
||
Comment 12•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8858487 [details]
Bug 1353558 - Restore "dtrace -G" support after bug 1353259 for Solaris and FreeBSD.
https://reviewboard.mozilla.org/r/130450/#review134002
Attachment #8858487 -
Flags: review?(mh+mozilla) → review+
Keywords: checkin-needed
|
||
Updated•8 years ago
|
Assignee: nobody → jbeich
|
||
Comment 13•8 years ago
|
||
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/2d6ef8ca4a74
Restore "dtrace -G" support after bug 1353259 for Solaris and FreeBSD. r=glandium
Keywords: checkin-needed
|
||
Comment 14•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
|
||
Updated•8 years ago
|
status-firefox53:
--- → unaffected
status-firefox54:
--- → unaffected
status-firefox-esr52:
--- → unaffected
|
||
Comment 15•8 years ago
|
||
Sorry for late reply - I don't have an easy way to test a dtrace build on NetBSD right now, but AFAIK the tools are mostly in sync with the FreeBSD version.
Flags: needinfo?(martin)
|
|
||
Comment 16•7 years ago
|
||
As for Solaris and using Clang to test dtrace. It's not really possible now as there is missing Solaris Clang build support for Firefox. E.g. Clang is given gcc parameters and it fails. I might have look at it later...
Flags: needinfo?(petr.sumbera)
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•