1353279 - Investigate how many external strings are backed by string literals

Status: RESOLVED INCOMPLETE

(Core :: JavaScript Engine, enhancement, P3)

Description

[Tooru Fujisawa [:arai]]

separated from bug 1352323.

if an external string is backed by string literals and used many, it would be nice to atomize it to reduce the instances.

we could modify bug 1352317 patch to say the kind of external string (if it's dynamically detectable in release binary), so that it gets easier to investigate.

Comment 1

[Tooru Fujisawa [:arai]]

here's the list of external strings.

steps to reproduce:
  1. start Nightly 55.0a1 (2017-04-23) (64-bit) on OSX, with clean profile
  2. open about:memory
  3. click [Save verbose] in Save GC & CC logs

result:

count | content
------+----------------
   85 | 55.0a1
   37 | sha512
   22 | complete
   22 | minor
   21 | succeeded
   21 | nightly
   21 | 17.0
   21 | The Update was successfully installed
   21 | https://nightly.mozilla.org
   21 | Nightly 55.0a1
   18 | 0.1
   15 | partial
   14 | null
   11 | {searchTerms}
    9 | 17.*
    8 | GET
    7 | text/html
    7 | 17.0.4
    7 | 17.0.*
    7 | searchform
    6 | 39.0a1
    6 | 19.0a1
    6 | hsimp
    6 | form
    6 | application/x-suggestions+json
...

some of them seems to be update info, search provider, and some UI things.
I'll try figuring out where they're actually coming from.