1353466 - Window opened with window.open, `noopener` feature cannot close itself

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P2)

Description

[Lyza Gardner]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36

Steps to reproduce:

* `window.open('foo.html', '', 'noopener')`
* Within `foo.html`: `window.close()`


Actual results:

Logged warning "Scripts may not close windows that were not opened by script." 
Window is not closed.


Expected results:

According to current spec language[1], `foo.html`'s browsing context meets the requirements for being script-closable—`window.close` should work here.

There is some debate in an existing bug thread[2] that the current spec language here may not be web-compatible, but in any case, current behavior leads to some orphaned windows in some Web Platform Tests[3].

[1]: https://html.spec.whatwg.org/#apis-for-creating-and-navigating-browsing-contexts-by-name
[2]: https://bugzilla.mozilla.org/show_bug.cgi?id=1316857
[3]: https://github.com/w3c/web-platform-tests/pull/5306

Comment 1

[Daniel Veditz [:dveditz]]

Clearly a bug in that we're using a signal (the presence or absence of window.opener) that has nothing to do, really with what we're interpreting it to mean. We might have an opener in a window NOT opened by script (bug 1316857) or we might have a script-opened window without an opener (this bug). Probably should be fixed together by recording "script-opened-window" in some other way.

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information

Comment 3

[Anne (:annevk)]

I think this bug is the cause of a lot of the target=_blank fallout. We should reconsider its priority.

Comment 4

[Hsin-Yi Tsai (she/her) [:hsinyi]]

I'll take an action to explore resource alternatives.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1353466, 'A browsing context is script-closable ... if it is a top-level browsing context whose session history contains only one Document', r=peterv

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=be983bdbf1e17d71aeb56f7e5eb94cb4078fbb01

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1e166841f170
'A browsing context is script-closable ... if it is a top-level browsing context whose session history contains only one Document', r=peterv

Comment 8

[Dorel Luca [:dluca]]

Backed out changeset 1e166841f170 (bug 1353466) for Mochitest failures in gecko/dom/base/nsGlobalWindowOuter.cpp. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=304540428&repo=autoland&lineNumber=4081

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedTaskRun=L1zu2F-wRkqhIdEms8d64A-1&revision=1e166841f170792c79338488b1379b85b0f5c7ab

Backout:
https://hg.mozilla.org/integration/autoland/rev/e8d0f18c2300a223c31847d27196d1a8ad673515

Comment 9

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e8d0f18c2300
Backed out changeset 1e166841f170 for Mochitest failures in gecko/dom/base/nsGlobalWindowOuter.cpp. CLOSED TREE

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

aha, IsFrame() is broken in Fission.

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e191493db23199304e06872b4ace23976c817a1e

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a312f7cd30fc
'A browsing context is script-closable ... if it is a top-level browsing context whose session history contains only one Document', r=peterv

Comment 13

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/a312f7cd30fc