Make target=_blank on a/area elements imply rel=noopener by default

REOPENED
Assigned to

Status

()

enhancement
P2
normal
REOPENED
5 months ago
2 months ago

People

(Reporter: annevk, Assigned: baku)

Tracking

(Depends on 1 bug, {dev-doc-needed, site-compat})

unspecified
mozilla67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 disabled, firefox68- affected)

Details

Attachments

(1 attachment)

Reporter

Description

5 months ago

We wanted to wait an additional cycle when we added this in 65. Nightly is now at 66, so it seems we can enable this by default as there's been nothing thus far in terms of fallout?

Reporter

Updated

5 months ago
Flags: needinfo?(amarchesini)
Assignee

Comment 1

5 months ago
Flags: needinfo?(amarchesini)
Attachment #9038500 - Flags: review?(ehsan)

Comment 2

5 months ago
Comment on attachment 9038500 [details] [diff] [review]
noreferrer.patch

Review of attachment 9038500 [details] [diff] [review]:
-----------------------------------------------------------------

It's too late to land this for 66 a we're in the soft freeze, but you can try to land it in the 67 cycle.  It is a good time to send an intent to ship and wait for the next uplift while people make their comments on dev-platform.  :-)
Attachment #9038500 - Flags: review?(ehsan) → review+

Comment 3

5 months ago

BTW I really would have preferred if we had shipped this and bug 1509346 together. I r+ed this in the interest of not having the perfect be the enemy of the good...

Priority: -- → P2

Comment 4

5 months ago
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ebf9f694b72d
Enable noopener by default for area and anchor elements with target=_blank and no rel attribute set, r=ehsan

Comment 5

5 months ago
bugherder
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Component: DOM → DOM: Core & HTML

Discussed with Ehsan and considering bug 1531289's fix touches a lot of page loading and can potentially cause a lot of regressions, it is a safer bet to let this ride on with 68 nightly (along with the fix for bug 1531289) but disable the pref in beta.

Baku, can you please backout the enabling of noopener by default for 67 beta?

Status: RESOLVED → REOPENED
Flags: needinfo?(amarchesini)
Resolution: FIXED → ---
Assignee

Updated

2 months ago
Blocks: 1546415
Assignee

Comment 7

2 months ago
Flags: needinfo?(amarchesini)

[Tracking Requested - why for this release]:
This was backed out in bug 1546415. We should enable this pref in 68 and also fix bug 1531289 in 68.

comment 6 sounds rather scary about landing bug 1531289 late... either way I'm not sure I need to track this for 68.

You need to log in before you can comment on or make changes to this bug.