1353481 - When vrdisplayactivate is triggered by link traversal, VRDisplay.requestPresent should relax the user gesture requirement

Status: RESOLVED FIXED

(Core :: WebVR, enhancement)

Description

[:kip (Kearwood Gilbert)]

In order to prevent malicious scripts from taking over your VR display, the initial entry into a WebVR session with VRDisplay.requestPresent requires a user gesture.  Once the user is within a VR session, they may follow links to pages that can immediately requestPresent.  The WebVR 1.1 spec defines the vrdisplayactivate event with a "reason" value that can be set to "navigation".  Firefox emits vrdisplayactivate with the "navigation" reason on the destination page after "load", signalling the page to immediately call requestPresent if it wishes to allow the user to seamlessly continue their VR session across the two sites.

The user gesture requirement is blocking VRDisplay.requestPresent within the vrdisplayactivate event triggered during link traversal.  We will relax the user gesture requirement for VRDisplay.requestPresent during this event.  Modeled after the User Gesture Requirement implementation in Firefox, an additional precaution of a timeout (initially set to 1s with a preference), will be implemented.

Comment 1

[:kip (Kearwood Gilbert)]

Attachment: Bug 1353481 - When vrdisplayactivate is triggered by link traversal, VRDisplay.requestPresent should relax the user gesture requirement

Review commit: https://reviewboard.mozilla.org/r/126488/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/126488/

Comment 2

[:kip (Kearwood Gilbert)]

Comment on attachment 8854536 [details]
Bug 1353481 - When vrdisplayactivate is triggered by link traversal, VRDisplay.requestPresent should relax the user gesture requirement

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/126488/diff/1-2/

Comment 3

[:kip (Kearwood Gilbert)]

Comment on attachment 8854536 [details]
Bug 1353481 - When vrdisplayactivate is triggered by link traversal, VRDisplay.requestPresent should relax the user gesture requirement

A file was missing from the patch, I'll re-request review once updated

Comment 4

[:kip (Kearwood Gilbert)]

Comment on attachment 8854536 [details]
Bug 1353481 - When vrdisplayactivate is triggered by link traversal, VRDisplay.requestPresent should relax the user gesture requirement

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/126488/diff/2-3/

Comment 5

[:kip (Kearwood Gilbert)]

The missing file has been added to the patch.  I've also re-run the try push for a sanity test.

Comment 6

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8854536 [details]
Bug 1353481 - When vrdisplayactivate is triggered by link traversal, VRDisplay.requestPresent should relax the user gesture requirement

https://reviewboard.mozilla.org/r/126488/#review129328

LGTM

Comment 7

[:kip (Kearwood Gilbert)]

Comment on attachment 8854536 [details]
Bug 1353481 - When vrdisplayactivate is triggered by link traversal, VRDisplay.requestPresent should relax the user gesture requirement

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/126488/diff/3-4/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0bfae319e9ba
When vrdisplayactivate is triggered by link traversal, VRDisplay.requestPresent should relax the user gesture requirement r=daoshengmu

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0bfae319e9ba