1353523 - Adjust threshold for Gamepad button `pressed` state and introduce pref to handle slightly sticky controller buttons

Status: RESOLVED FIXED

(Core :: WebVR, enhancement)

Description

[Kevin Ngo [:ngoke]]

My HTC Vive controller trigger has a tiny bit of stickiness to it. Sometimes a trigger up doesn’t fully unset the gamepad `pressed` state. I have to pull up on the trigger a bit to release it.

In content such as A-Frame, this would cause bugs where if I released the trigger, my hand model would get often stuck in the grab/fist pose.

Adjust the default value a bit. Make it a preference to be changeable.

Comment 1

[Kevin Ngo [:ngoke]]

Example on HTC Vive, on Firefox Nightly: https://aframe.io/examples/showcase/tracked-controllers/

Comment 2

[Daosheng Mu[:daoshengmu]]

It is because HTC Vive has a threshold (0.55f) at their hardware for the trigger button. Only when the value around 0.55f will do the `pressed` state change. We can do some adjustment by our own if we want.

Comment 3

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1353523 - Add adjustable threshold value for VR controller trigger inputs;

Review commit: https://reviewboard.mozilla.org/r/131488/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/131488/

Comment 4

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8859443 [details]
Bug 1353523 - Add adjustable threshold value for VR controller trigger inputs;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/131488/diff/1-2/

Comment 5

[:kip (Kearwood Gilbert)]

Comment on attachment 8859443 [details]
Bug 1353523 - Add adjustable threshold value for VR controller trigger inputs;

https://reviewboard.mozilla.org/r/131488/#review134588

LGTM, Thanks!

Comment 6

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s f1fb9e8cfd29 -d afe865149e0e: rebasing 391015:f1fb9e8cfd29 "Bug 1353523 - Add adjustable threshold value for VR controller trigger inputs; r=kip" (tip)
merging gfx/thebes/gfxPrefs.h
merging gfx/vr/gfxVROculus.cpp
merging gfx/vr/gfxVROpenVR.cpp
merging gfx/vr/gfxVROpenVR.h
merging modules/libpref/init/all.js
warning: conflicts while merging gfx/vr/gfxVROpenVR.cpp! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 7

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8859443 [details]
Bug 1353523 - Add adjustable threshold value for VR controller trigger inputs;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/131488/diff/2-3/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a5572924d69a
Add adjustable threshold value for VR controller trigger inputs; r=kip

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a5572924d69a