Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Adjust threshold for Gamepad button `pressed` state and introduce pref to handle slightly sticky controller buttons

RESOLVED FIXED in Firefox 55

Status

()

Core
WebVR
RESOLVED FIXED
4 months ago
3 months ago

People

(Reporter: ngoke, Assigned: daoshengmu)

Tracking

(Blocks: 2 bugs)

unspecified
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

4 months ago
My HTC Vive controller trigger has a tiny bit of stickiness to it. Sometimes a trigger up doesn’t fully unset the gamepad `pressed` state. I have to pull up on the trigger a bit to release it.

In content such as A-Frame, this would cause bugs where if I released the trigger, my hand model would get often stuck in the grab/fist pose.

Adjust the default value a bit. Make it a preference to be changeable.
(Reporter)

Comment 1

4 months ago
Example on HTC Vive, on Firefox Nightly: https://aframe.io/examples/showcase/tracked-controllers/
(Reporter)

Updated

4 months ago
Blocks: 1352418
No longer depends on: 1353481
(Reporter)

Updated

4 months ago
Assignee: nobody → dmu
Blocks: 1299926
No longer blocks: 1352418
(Reporter)

Updated

4 months ago
Blocks: 1353524
(Assignee)

Comment 2

4 months ago
It is because HTC Vive has a threshold (0.55f) at their hardware for the trigger button. Only when the value around 0.55f will do the `pressed` state change. We can do some adjustment by our own if we want.
(Assignee)

Updated

3 months ago
Blocks: 1356460
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 5

3 months ago
mozreview-review
Comment on attachment 8859443 [details]
Bug 1353523 - Add adjustable threshold value for VR controller trigger inputs;

https://reviewboard.mozilla.org/r/131488/#review134588

LGTM, Thanks!
Attachment #8859443 - Flags: review?(kgilbert) → review+

Comment 6

3 months ago
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s f1fb9e8cfd29 -d afe865149e0e: rebasing 391015:f1fb9e8cfd29 "Bug 1353523 - Add adjustable threshold value for VR controller trigger inputs; r=kip" (tip)
merging gfx/thebes/gfxPrefs.h
merging gfx/vr/gfxVROculus.cpp
merging gfx/vr/gfxVROpenVR.cpp
merging gfx/vr/gfxVROpenVR.h
merging modules/libpref/init/all.js
warning: conflicts while merging gfx/vr/gfxVROpenVR.cpp! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Comment hidden (mozreview-request)

Comment 8

3 months ago
Pushed by dmu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a5572924d69a
Add adjustable threshold value for VR controller trigger inputs; r=kip
https://hg.mozilla.org/mozilla-central/rev/a5572924d69a
Status: NEW → RESOLVED
Last Resolved: 3 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.