1353484 - Update webrender to 3dd68f54e12bd5abf8ef41de4d4ec851620f7e4e

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Kartikaya Gupta (email:[e-mail])]

+++ This bug was initially created as a clone of Bug #1351480 +++

I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.

When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".

[1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh

Comment 1

[Kartikaya Gupta (email:[e-mail])]

WR @ 1c5a9bb68f6f94d1201e9d40fcc7a7a304888268

https://treeherder.mozilla.org/#/jobs?repo=try&revision=00fc4c82a63bb8b6a4745fd1db564f35701bec4c

Green

Comment 2

[Kartikaya Gupta (email:[e-mail])]

WR @ a49bfbf3172e324724421d3ff88d93d1df11328c

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6638a67b0e13df7a3cdf37812b3bd6a802467b9e

Green

Comment 3

[Kartikaya Gupta (email:[e-mail])]

WR @ dbb2f91a68109047d524a51d6ac09de46539a33e

https://treeherder.mozilla.org/#/jobs?repo=try&revision=92d4b20627ffe6ab224f981ca0cf9205ac9bbcd8

Bustage

Comment 4

[Kartikaya Gupta (email:[e-mail])]

I tried fixing up the bustage:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=607e404b902c7c7554d15d4edbaab23d4c57bafe

I didn't do a very good job, since there is an overabundance of orange.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

I tried using both Preserve3D and Flat for the new push_stacking_context parameter, neither fixed the problem. So most likely the bounds parameter to push_scroll_layer is the problem.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

... or it's something inside webrender that changed. Here's the regression range between comment 2 and comment 3. I'll try bisecting it.

*   dbb2f91 Auto merge of #1067 - glennw:remove-inner-rect, r=kvark
|\
| * cef357e Remove unused inner_rect from BorderPrimitiveCpu struct.
* |   45d0d1a Auto merge of #1066 - waywardmonkeys:vecref, r=glennw
|\ \
| |/
|/|
| * 9ff9b09 Prefer &[..] over &Vec<..>.
* |   ba14e0b Auto merge of #1061 - glennw:make-borders-great-again-1, r=kvark
|\ \
| |/
|/|
| * d544f3a Support more cases of simple border fast path.
|/
*   7487125 Auto merge of #1065 - waywardmonkeys:clippy-fixes, r=kvark
|\
| * c797ae3 A variety of clippy fixes.
|/
*   de290ce Auto merge of #1062 - kvark:split, r=glennw
|\
| * 3fcfb6c Rotation transforms for wrench
| * be249f6 introduce TransformStyle refactor Yaml string conversions
*   f894244 Auto merge of #1055 - mrobinson:clip-positioning, r=glennw
|\
| * 7253e2f Fix the way that clip positioning is specified
* 933d4e6 Auto merge of #1064 - waywardmonkeys:improve-docs, r=kvark
* a2d959b A variety of documentation fixes.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Bisection points:

@ f894244 -> https://treeherder.mozilla.org/#/jobs?repo=try&revision=83c2e3fc7b706a306e633602706abacb959866cb
@ de290ce -> https://treeherder.mozilla.org/#/jobs?repo=try&revision=252591b8205f258e99bd78febe1f7c5d4f45f655
@ ba14e0b -> https://treeherder.mozilla.org/#/jobs?repo=try&revision=a452bf4c436845d4252dee428e4ef985bf35bc63

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Narrowed regression range:

*   f894244 Auto merge of #1055 - mrobinson:clip-positioning, r=glennw
|\
| * 7253e2f Fix the way that clip positioning is specified
* 933d4e6 Auto merge of #1064 - waywardmonkeys:improve-docs, r=kvark
* a2d959b A variety of documentation fixes.

Therefore caused by #1055, or the fixup I had to do in webrender_bindings to compensate for the API change.

Comment 9

[Kartikaya Gupta (email:[e-mail])]

WR @ fa536e0c628f6115181f38d975571731d1e304ce

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e6109026fc82497f81ce4fbfa67ccf7e998a4c56

Bustage, to do with gradient API changes.

I'm still trying to figure out how to fix the orange tests, mrobinson suggested making the clip rect in push_scroll_layer relative to the content rect. I tried that and it didn't fix the problem but there might be more things I need to make relative to the content rect.

Comment 10

[Kartikaya Gupta (email:[e-mail])]

WR @ 31cbe694c2dc5ea10dad6bfb9bec59b97d5c7aad, with gradient bustage fixups

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ddaeaa01b0f0d1363f38375fc1055919f0b12997

Still as orange as before, hard to say if there's new failures.

Comment 11

[Kartikaya Gupta (email:[e-mail])]

After giving this some thought I realized that the origin of the clip bounds needs to always be 0,0 for our purposes, because it's relative to the stacking context. I verified that fixes the oranges [1]. I'll clean up the patch and add it to my patch queue.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=151c032070f24c538b03e53689752f524e7f4387

Comment 12

[Kartikaya Gupta (email:[e-mail])]

WR @ 71e4e4235fddb686a24d9aa371cfc71f07f3364b with fixups

https://treeherder.mozilla.org/#/jobs?repo=try&revision=48d7424313b2913e9c1f08a717c55ddcc2abfcdf

Green at last

Comment 13

[Kartikaya Gupta (email:[e-mail])]

WR @ d2b91d71b900f0d47bd8fe8727b67a436699cb56

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fa2d5988757f0997725bf5da2058724f4bd96175

Green

Comment 14

[Kartikaya Gupta (email:[e-mail])]

WR @ 3dd68f54e12bd5abf8ef41de4d4ec851620f7e4e

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e9bfd330b867bfb0eae37e215c382e15f639b26c

Green.

Probably a good time to land this update.

Comment 15

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1353484 - Update webrender to 3dd68f54e12bd5abf8ef41de4d4ec851620f7e4e.

Review commit: https://reviewboard.mozilla.org/r/128670/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/128670/

Comment 16

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1353484 - Update Cargo.toml and Cargo.lock files.

Review commit: https://reviewboard.mozilla.org/r/128672/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/128672/

Comment 17

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1353484 - Update calls to push_scroll_layer for API change in 7253e2f.

Review commit: https://reviewboard.mozilla.org/r/128674/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/128674/

Comment 18

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1353484 - Update calls to push_stacking_context for API change in be249f6.

Review commit: https://reviewboard.mozilla.org/r/128676/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/128676/

Comment 19

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1353484 - Update for changes to gradient APIs in 05c4293.

Review commit: https://reviewboard.mozilla.org/r/128678/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/128678/

Comment 20

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8856747 [details]
Bug 1353484 - Update webrender to 3dd68f54e12bd5abf8ef41de4d4ec851620f7e4e.

https://reviewboard.mozilla.org/r/128670/#review131170

Comment 21

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8856748 [details]
Bug 1353484 - Update Cargo.toml and Cargo.lock files.

https://reviewboard.mozilla.org/r/128672/#review131172

Comment 22

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8856749 [details]
Bug 1353484 - Update calls to push_scroll_layer for API change in 7253e2f.

https://reviewboard.mozilla.org/r/128674/#review131174

Comment 23

[Ryan Hunt [:rhunt]]

Comment on attachment 8856751 [details]
Bug 1353484 - Update for changes to gradient APIs in 05c4293.

https://reviewboard.mozilla.org/r/128678/#review131188

Comment 24

[Dzmitry Malyshau [:kvark]]

Comment on attachment 8856750 [details]
Bug 1353484 - Update calls to push_stacking_context for API change in be249f6.

https://reviewboard.mozilla.org/r/128676/#review131396

Comment 25

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/573879d4f6ea
Update webrender to 3dd68f54e12bd5abf8ef41de4d4ec851620f7e4e. r=jrmuizel,kvark,rhunt

Comment 26

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/mozilla-central/rev/573879d4f6ea