1351480 - Update webrender to 7463ae5908ca1d4065763a8753af5d72a6f78b85

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Kartikaya Gupta (email:[e-mail])]

+++ This bug was initially created as a clone of Bug #1349692 +++

I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.

When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".

[1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh

Comment 1

[Kartikaya Gupta (email:[e-mail])]

WR @ 306d33ec7cbbcc4cb5805967f125dbcd572bc7cb

https://treeherder.mozilla.org/#/jobs?repo=try&revision=87e251b03f5d48feee2c18bd2e105c4e07344737

Busted, method `request_blob_image` has 4 parameters but the declaration in trait `webrender_traits::BlobImageRenderer::request_blob_image` has 5

Comment 2

[Kartikaya Gupta (email:[e-mail])]

WR @ ea1e9805599d76394e06ca40900970d207672483 with compile fixes from last time

https://treeherder.mozilla.org/#/jobs?repo=try&revision=78a0e2bcd0f745b849945b58523e4d756336bae2

Builds, but a lot of failures. It looks like giant canvas things are broken again. Debug jobs are all orange.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

This is the regression range since the last known good build:

6e9e93e Auto merge of #1011 - glennw:scissor-targets, r=kvark
ea1e980 Auto merge of #1022 - mrobinson:u64-id, r=kvark
1c38be3 Have ScrollLayerId use u64
306d33e Auto merge of #1021 - glennw:bg-opt, r=mrobinson
df3bbb5 Remove a redundant full screen rectangle being drawn each frame.
8f92619 Auto merge of #1004 - nical:blob-img-updates, r=glennw
8b6640f Auto merge of #1015 - glennw:clip-in-out, r=kvark
44a7cd2 Address review comments.
80b500a Treat updating non-existant images as an error.
851d683 Clarify the effects of size, format and tiling when updating an image.
f0194cd Optimize GPU time spent in clears.
85c8777 Add support for clip in/out.
086f912 Allow updating images that are not raw buffers.
e2fc85e Replace an if/else expression by a match.

I'll do a couple of bisections to isolate things.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Above comment was wrong. Here's the real regression range, with a graph for easier visualizing/bisecting (blasted merge commits!)

*   ea1e980 Auto merge of #1022 - mrobinson:u64-id, r=kvark
|\
| * 1c38be3 Have ScrollLayerId use u64
|/
*   306d33e Auto merge of #1021 - glennw:bg-opt, r=mrobinson
|\
| * df3bbb5 Remove a redundant full screen rectangle being drawn each frame.
* |   8f92619 Auto merge of #1004 - nical:blob-img-updates, r=glennw
|\ \
| |/
|/|
| * 80b500a Treat updating non-existant images as an error.
| * 851d683 Clarify the effects of size, format and tiling when updating an image.
| * 086f912 Allow updating images that are not raw buffers.
| * e2fc85e Replace an if/else expression by a match.
* 8b6640f Auto merge of #1015 - glennw:clip-in-out, r=kvark
* 44a7cd2 Address review comments.
* 85c8777 Add support for clip in/out.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

https://github.com/servo/webrender/pull/1024 should fix the debug job failures.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

https://github.com/servo/webrender/pull/1025 might fix the opt failures. Try push with both those PRs applied manually on top of ea1e980: https://treeherder.mozilla.org/#/jobs?repo=try&revision=167262771a9dc1499373ec10a190556bc26affbc

Comment 7

[Kartikaya Gupta (email:[e-mail])]

I bisected with try pushes before [1] and after [2] PR 1004 landed, and that is definitely the source of the texture size crashes.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=21d6c7717186a6569f971c6b8c928fd50ad4ec6f
[2] https://treeherder.mozilla.org/#/jobs?repo=try&revision=19836ba01c7701d941a228b3fba7b1032de168ae

Comment 8

[Kartikaya Gupta (email:[e-mail])]

WR @ c1355e2a47f142d2de7f482e6138e067c33ed263

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0d7b4b57fae8943e1e1643fd66f42c8e1f9240f1

Just the texture size crashes still.

Comment 9

[Kartikaya Gupta (email:[e-mail])]

WR @ 6b1b85301244d22e5a7f6257e1289c18bc0f0335

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5307611b4b287837baa77e519956dc8643483314

Bustage again

====

WR @ 4b72bb1921628d01b08ab356c0f2365a927b711e, with bustage fixup

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b96726c4cf97169672cc938067d1f0c97a09e40c

Green (except for the X6 failure which is bug 1351777)

Comment 10

[Kartikaya Gupta (email:[e-mail])]

WR @ 855c11bfca11c9d258218930a2524f357a3790db

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1cd7ac3df82d871badf5ea5c46d4eb07348158c0

Bustage again.

Comment 11

[Ryan Hunt [:rhunt]]

It looks like one of the gradient API changes in that push and another one has landed upstream.

I have a patch for wr_bindings for both the changes so I could test things, it might be useful here. It's included in this try run in the 'update wr bindings' cset.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f33df7c2d57d521475649fd77c3c9faed1e97a94

Comment 12

[Kartikaya Gupta (email:[e-mail])]

That try push doesn't look very happy either :/. But thanks for the patch, I'll include it in my automated try pushes.

Comment 13

[Ryan Hunt [:rhunt]]

Yeah the try run has layers.advanced.background-image enabled so if you don't have that patch we should be fine.

Comment 14

[Kartikaya Gupta (email:[e-mail])]

Ah, that makes sense.

WR @ 384a434d1be0cbc53f79b007fc4cda00b2956400 with various fixups

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ef7e2e787f9fecd5f91a365d96567113bdc9a2ed

Looking better. There's an R4 failure which is an UNEXPECTED-PASS so that's ok.

Comment 15

[Kartikaya Gupta (email:[e-mail])]

WR @ 7463ae5908ca1d4065763a8753af5d72a6f78b85 with fixups

https://treeherder.mozilla.org/#/jobs?repo=try&revision=37b064409e601c7cdb2ec096a73d8ced5c963360

Green, so I'm gonna try and get this landed.

Comment 16

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1351480 - Update webrender and webrender_traits to 7463ae5908ca1d4065763a8753af5d72a6f78b85.

Review commit: https://reviewboard.mozilla.org/r/126202/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/126202/

Comment 17

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1351480 - Update Cargo.toml and Cargo.lock files.

Review commit: https://reviewboard.mozilla.org/r/126204/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/126204/

Comment 18

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1351480 - Re-vendor rust dependencies.

Review commit: https://reviewboard.mozilla.org/r/126206/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/126206/

Comment 19

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1351480 - Update call to update_image for change in 086f912ea86d053d95e5f4eec00cae0d82ee5dba.

Review commit: https://reviewboard.mozilla.org/r/126208/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/126208/

Comment 20

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1351480 - Update request_blob_image for new parameter added in 086f912ea86d053d95e5f4eec00cae0d82ee5dba.

Review commit: https://reviewboard.mozilla.org/r/126210/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/126210/

Comment 21

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1351480 - Update calls to add_image to include the ImageData::External wrapper.

Review commit: https://reviewboard.mozilla.org/r/126212/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/126212/

Comment 22

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1351480 - Update bindings for gradients.

Review commit: https://reviewboard.mozilla.org/r/126214/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/126214/

Comment 23

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1351480 - set_root_display_list got renamed to set_display_list, so update call sites.

Review commit: https://reviewboard.mozilla.org/r/126216/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/126216/

Comment 24

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1351480 - Mark a test passing again.

Review commit: https://reviewboard.mozilla.org/r/126218/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/126218/

Comment 25

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8854271 [details]
Bug 1351480 - Update webrender and webrender_traits to 7463ae5908ca1d4065763a8753af5d72a6f78b85.

https://reviewboard.mozilla.org/r/126202/#review128930

Comment 26

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8854272 [details]
Bug 1351480 - Update Cargo.toml and Cargo.lock files.

https://reviewboard.mozilla.org/r/126204/#review128932

Comment 27

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8854273 [details]
Bug 1351480 - Re-vendor rust dependencies.

https://reviewboard.mozilla.org/r/126206/#review128936

Comment 28

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8854274 [details]
Bug 1351480 - Update call to update_image for change in 086f912ea86d053d95e5f4eec00cae0d82ee5dba.

https://reviewboard.mozilla.org/r/126208/#review128942

Comment 29

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8854275 [details]
Bug 1351480 - Update request_blob_image for new parameter added in 086f912ea86d053d95e5f4eec00cae0d82ee5dba.

https://reviewboard.mozilla.org/r/126210/#review128944

Comment 30

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8854277 [details]
Bug 1351480 - Update bindings for gradients.

https://reviewboard.mozilla.org/r/126214/#review128946

Comment 31

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8854278 [details]
Bug 1351480 - set_root_display_list got renamed to set_display_list, so update call sites.

https://reviewboard.mozilla.org/r/126216/#review128948

Comment 32

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8854279 [details]
Bug 1351480 - Mark a test passing again.

https://reviewboard.mozilla.org/r/126218/#review128950

Comment 33

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Comment on attachment 8854276 [details]
Bug 1351480 - Update calls to add_image to include the ImageData::External wrapper.

https://reviewboard.mozilla.org/r/126212/#review129174

Comment 34

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/156ad88d9cde
Update webrender to 7463ae5908ca1d4065763a8753af5d72a6f78b85. r=jrmuizel
https://hg.mozilla.org/projects/graphics/rev/a0452e40488f
Update calls to add_image to include the ImageData::External wrapper. r=Jerry
https://hg.mozilla.org/projects/graphics/rev/bc30dfd39568
Update bindings for gradients. r=jrmuizel
https://hg.mozilla.org/projects/graphics/rev/6964c11a9c06
Mark a test passing again. r=jrmuizel

Comment 35

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/mozilla-central/rev/156ad88d9cde
https://hg.mozilla.org/mozilla-central/rev/a0452e40488f
https://hg.mozilla.org/mozilla-central/rev/bc30dfd39568
https://hg.mozilla.org/mozilla-central/rev/6964c11a9c06