Enable shape-outside on Nightly

NEW
Assigned to

Status

()

Core
Layout: Floats
P3
normal
a year ago
an hour ago

People

(Reporter: TYLin, Assigned: bradwerth, NeedInfo)

Tracking

(Blocks: 1 bug, {dev-doc-needed})

Firefox Tracking Flags

(Not tracked)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

This tracks all the bugs that need to be fixed before enabling shape-outside on Nightly and Aurora.
Keywords: dev-doc-needed

Updated

10 months ago
Depends on: 1373743

Updated

8 months ago
Priority: -- → P3
Summary: Enable shape-outside on Nightly and Aurora → Enable shape-outside on Nightly

Comment 1

5 months ago
layout.css.shape-outside.enabled is the flag to flip here.
(Assignee)

Updated

3 months ago
Assignee: nobody → bwerth
Comment hidden (mozreview-request)
(Assignee)

Updated

3 days ago
Attachment #8969822 - Flags: review?(dholbert)
Comment hidden (mozreview-request)
Comment on attachment 8969822 [details]
Bug 1353631 Part 1: Set preference default to true in Nightly for layout.css.shape-outside.enabled.

https://reviewboard.mozilla.org/r/238648/#review244406
Attachment #8969822 - Flags: review?(dholbert) → review+

Comment 6

3 days ago
Pushed by bwerth@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2dad6e7f5092
Set preference default to true in Nightly for layout.css.shape-outside.enabled. r=dholbert
Backed out changeset 2dad6e7f5092 (bug 1353631) for XPCShell failures on devtools/shared/tests/unit/test_css-properties-db.js

Log of the fail:
https://treeherder.mozilla.org/logviewer.html#?job_id=174898097&repo=autoland&lineNumber=7680

 INFO -  TEST-PASS | uriloader/exthandler/tests/unit/test_badMIMEType.js | took 588ms
20:13:03     INFO -  TEST-START | uriloader/exthandler/tests/unit/test_handlerService.js
20:13:04     INFO -  TEST-PASS | uriloader/exthandler/tests/unit/test_handlerService.js | took 719ms
20:13:04     INFO -  TEST-START | uriloader/exthandler/tests/unit/test_handlerService_store.js
20:13:06     INFO -  TEST-PASS | uriloader/exthandler/tests/unit/test_handlerService_store.js | took 1774ms
20:13:06     INFO -  TEST-START | uriloader/exthandler/tests/unit/test_punycodeURIs.js
20:13:06     INFO -  TEST-PASS | uriloader/exthandler/tests/unit/test_punycodeURIs.js | took 557ms
20:13:06     INFO -  Retrying tests that failed when run in parallel.
20:13:06     INFO -  TEST-START | devtools/shared/tests/unit/test_css-properties-db.js
20:13:07  WARNING -  TEST-UNEXPECTED-FAIL | devtools/shared/tests/unit/test_css-properties-db.js | xpcshell return code: 0
20:13:07     INFO -  TEST-INFO took 1092ms
20:13:07     INFO -  >>>>>>>
20:13:07     INFO -  PID 7109 | [7109, Main Thread] WARNING: Couldn't get the user appdata directory. Crash events may not be produced.: file /builds/worker/workspace/build/src/toolkit/crashreporter/nsExceptionHandler.cpp, line 2678
20:13:07     INFO -  PID 7109 | JavaScript strict warning: resource://devtools/shared/Loader.jsm, line 224: ReferenceError: reference to undefined property "name"
20:13:07     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)

Backout:
https://hg.mozilla.org/integration/autoland/rev/daaa0c840a9fb865971d59b4c5ba90d25f8cf42a

Push with the failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=2dad6e7f5092b3f52625bc339eb584f7d97163be
Flags: needinfo?(bwerth)
Looks like you need to run "./mach devtools-css-db" after applying this patch & building Firefox, and then amend the patch to include the generated changes (new entries for the pref-controlled properties in /devtools/shared/css/generated/properties-db.js )
(Or perhaps slightly better: capture that mach command's automated changes in a second patch in the series here -- to keep manual changes and automated changes separate.)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

4 hours ago
Attachment #8970182 - Flags: review?(dholbert)
Comment on attachment 8970182 [details]
Bug 1353631 Part 2: Regenerate devtools property database for properties protected by the pref.

https://reviewboard.mozilla.org/r/238994/#review244662
Attachment #8970182 - Flags: review?(dholbert) → review+

Comment 13

an hour ago
Pushed by bwerth@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fd5bd538bfe7
Part 1: Set preference default to true in Nightly for layout.css.shape-outside.enabled. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/6a0c361f18ff
Part 2: Regenerate devtools property database for properties protected by the pref. r=dholbert
You need to log in before you can comment on or make changes to this bug.